[dpdk-dev] [PATCH] meter: fix excess token bucket update in srtcm implementation

2016-09-20 Thread Nikhil Jagtap
Hi Cristian, My comments inline prefixed with [nikhil]. On 19 September 2016 at 21:21, Dumitrescu, Cristian < cristian.dumitrescu at intel.com> wrote: > > > > > -Original Message- > > From: Nikhil Jagtap [mailto:nikhil.jagtap at gmail.com] > > Sent: Wednesday, September 7, 2016 7:15 AM >

[dpdk-dev] [PATCH] meter: fix excess token bucket update in srtcm implementation

2016-09-19 Thread Dumitrescu, Cristian
> -Original Message- > From: Nikhil Jagtap [mailto:nikhil.jagtap at gmail.com] > Sent: Wednesday, September 7, 2016 7:15 AM > To: Dumitrescu, Cristian > Cc: dev at dpdk.org; Ramia, Kannan Babu ; > Nikhil Jagtap > Subject: [PATCH] meter: fix excess token bucket update in srtcm > implemen

[dpdk-dev] [PATCH] meter: fix excess token bucket update in srtcm implementation

2016-09-07 Thread Nikhil Jagtap
As per srTCM RFC 2697, we should be updating the E bucket only after the C bucket overflows. This patch fixes the current DPDK implementation, where we are updating both the buckets simultaneously at the same rate (CIR) which results in token accumulation rate of (2*CIR). Signed-off-by: Nikhil Jag