[dpdk-dev] [PATCH] lib/librte_ether: bypass code cleanup

2016-07-11 Thread Wenzhuo Lu
In testpmd code, device id is used directly to check if bypass is supported. But APP should not know the details of HW, the NIC specific info should not be exposed here. This patch adds a new rte API to check if bypass is supported. Signed-off-by: Wenzhuo Lu --- app/test-pmd/cmdline.c

[dpdk-dev] [PATCH] lib/librte_ether: bypass code cleanup

2016-07-11 Thread Thomas Monjalon
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > > Hmmm. It's true it is cleaner. But I am not sure having a generic API > > for bypass is a good idea at all. > > I was thinking to totally remove it. > > Why to remove it? > As I know there are people who use that functio

[dpdk-dev] [PATCH] lib/librte_ether: bypass code cleanup

2016-07-11 Thread Ananyev, Konstantin
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > > > Hmmm. It's true it is cleaner. But I am not sure having a generic API > > > for bypass is a good idea at all. > > > I was thinking to totally remove it. > > > > Why to remove it? > > As I know there are people who us

[dpdk-dev] [PATCH] lib/librte_ether: bypass code cleanup

2016-07-11 Thread Thomas Monjalon
2016-07-11 14:21, Wenzhuo Lu: > In testpmd code, device id is used directly to check if bypass > is supported. But APP should not know the details of HW, the NIC > specific info should not be exposed here. Right > This patch adds a new rte API to check if bypass is supported. Hmmm. It's true it

[dpdk-dev] [PATCH] lib/librte_ether: bypass code cleanup

2016-07-11 Thread Ananyev, Konstantin
Hi Thomas, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Monday, July 11, 2016 8:11 AM > To: Lu, Wenzhuo > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] lib/librte_ether: bypass code cleanup > > 2016

[dpdk-dev] [PATCH] lib/librte_ether: bypass code cleanup

2016-07-11 Thread Lu, Wenzhuo
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Monday, July 11, 2016 3:11 PM > To: Lu, Wenzhuo > Cc: dev at dpdk.org > Subject: Re: [PATCH] lib/librte_ether: bypass code cleanup > > 2016-07-11 14:21, Wenzhuo Lu: > > In testpmd code, device id is

[dpdk-dev] [PATCH] lib/librte_ether: bypass code cleanup

2016-07-11 Thread Lu, Wenzhuo
> -Original Message- > From: Wu, Jingjing > Sent: Monday, July 11, 2016 3:51 PM > To: Lu, Wenzhuo; dev at dpdk.org > Cc: thomas.monjalon at 6wind.com; Lu, Wenzhuo > Subject: RE: [dpdk-dev] [PATCH] lib/librte_ether: bypass code cleanup > > Hi, Wenzhuo > > I

[dpdk-dev] [PATCH] lib/librte_ether: bypass code cleanup

2016-07-11 Thread Wu, Jingjing
stpmd, including "bypass_is_supported". Thanks Jingjing > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Monday, July 11, 2016 2:21 PM > To: dev at dpdk.org > Cc: thomas.monjalon at 6wind.com; Lu, Wenzhuo >