Hi Thomas, > -----Original Message----- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Monday, July 11, 2016 8:11 AM > To: Lu, Wenzhuo > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] lib/librte_ether: bypass code cleanup > > 2016-07-11 14:21, Wenzhuo Lu: > > In testpmd code, device id is used directly to check if bypass > > is supported. But APP should not know the details of HW, the NIC > > specific info should not be exposed here. > > Right > > > This patch adds a new rte API to check if bypass is supported. > > Hmmm. It's true it is cleaner. But I am not sure having a generic API > for bypass is a good idea at all. > I was thinking to totally remove it.
Why to remove it? As I know there are people who use that functionality. > Maybe we can try to have a specific API by including ixgbe_bypass.h in > the application. Hmm, isn't that what we were trying to get rid of in last few years? HW specific stuff? Konstantin
