Re: [dpdk-dev] [PATCH] ipsec: include high order bytes of esn in pkt len

Hi Konstantin, Thank you for the review. I will send a revised patch which addresses your comments. Thanks, Lukasz On 19.05.2019 16:47, Ananyev, Konstantin wrote: > > Hi Lukasz, > Thanks for clarifications. > Looks good in general. > Few small comments below. > Konstantin > >> When esn is use

Re: [dpdk-dev] [PATCH] ipsec: include high order bytes of esn in pkt len

Hi Lukasz, Thanks for clarifications. Looks good in general. Few small comments below. Konstantin > When esn is used then high-order 32 bits are included in ICV > calculation however are not transmitted. Update packet length > to be consistent with auth data offset and length before crypto > op

Re: [dpdk-dev] [PATCH] ipsec: include high order bytes of esn in pkt len

From: Ananyev, Konstantin Sent: Tuesday, April 30, 2019 5:05 PM To: Lukas Bartosik Cc: dev@dpdk.org; Anoob Joseph Subject: RE: [PATCH] ipsec: include high order bytes of esn in pkt len > -Original Message- > From: Lukasz Bartosik [mailto:lbarto...@ma

Re: [dpdk-dev] [PATCH] ipsec: include high order bytes of esn in pkt len

> -Original Message- > From: Lukasz Bartosik [mailto:lbarto...@marvell.com] > Sent: Tuesday, April 30, 2019 3:56 PM > To: Ananyev, Konstantin > Cc: dev@dpdk.org; ano...@marvell.com; Lukasz Bartosik > Subject: [PATCH] ipsec: include high order bytes of esn in pkt len > > When esn is us

[dpdk-dev] [PATCH] ipsec: include high order bytes of esn in pkt len

When esn is used then high-order 32 bits are included in ICV calculation however are not transmitted. Update packet length to be consistent with auth data offset and length before crypto operation. High-order 32 bits of esn will be removed from packet length in crypto post processing. Change-Id: I