Re: [dpdk-dev] [PATCH] eal: force gcc to inline rte_movX function

2018-04-18 Thread Thomas Monjalon
18/04/2018 04:43, Chen, Junjie J: > Thanks to point this out. I agree for the title change. > > Do you want me to send v2 patch? Or you can handle it when committing? > > > > > Sometimes gcc does not inline the function despite keyword *inline*, > > > > we obeserve rte_movX is not inline when do

Re: [dpdk-dev] [PATCH] eal: force gcc to inline rte_movX function

2018-04-17 Thread Chen, Junjie J
Thanks to point this out. I agree for the title change. Do you want me to send v2 patch? Or you can handle it when committing? > > > Sometimes gcc does not inline the function despite keyword *inline*, > > > we obeserve rte_movX is not inline when doing performance profiling, > > > so use *alway

Re: [dpdk-dev] [PATCH] eal: force gcc to inline rte_movX function

2018-04-17 Thread Bruce Richardson
On Tue, Apr 17, 2018 at 03:22:06PM +0200, Thomas Monjalon wrote: > 12/04/2018 07:16, Junjie Chen: > > From: "Chen, Junjie" > > > > Sometimes gcc does not inline the function despite keyword *inline*, > > we obeserve rte_movX is not inline when doing performance profiling, > > so use *always_inlin

Re: [dpdk-dev] [PATCH] eal: force gcc to inline rte_movX function

2018-04-17 Thread Thomas Monjalon
12/04/2018 07:16, Junjie Chen: > From: "Chen, Junjie" > > Sometimes gcc does not inline the function despite keyword *inline*, > we obeserve rte_movX is not inline when doing performance profiling, > so use *always_inline* keyword to force gcc to inline the function. > > Signed-off-by: Chen, Jun

[dpdk-dev] [PATCH] eal: force gcc to inline rte_movX function

2018-04-11 Thread Junjie Chen
From: "Chen, Junjie" Sometimes gcc does not inline the function despite keyword *inline*, we obeserve rte_movX is not inline when doing performance profiling, so use *always_inline* keyword to force gcc to inline the function. Signed-off-by: Chen, Junjie --- .../common/include/arch/x86/rte_mem