Re: [dpdk-dev] [PATCH] devtools: fix check symbol change script

2020-03-23 Thread David Marchand
On Thu, Mar 19, 2020 at 3:44 PM Nithin Dabilpuram wrote: > diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh > index c5434f3..19ce82f 100755 > --- a/devtools/check-symbol-change.sh > +++ b/devtools/check-symbol-change.sh > @@ -17,13 +17,13 @@ build_map_changes() >

Re: [dpdk-dev] [PATCH] devtools: fix check symbol change script

2020-03-22 Thread Jerin Jacob
On Thu, Mar 19, 2020 at 8:14 PM Nithin Dabilpuram wrote: > > Fix check symbol change script to detect new diff file when > it is in between "--- /dev/null" to "b/lib/...". > Current awk line expects line to start with "a/..." > which is not always true for all diffs. > As a result if in_map was '

Re: [dpdk-dev] [PATCH] devtools: fix check symbol change script

2020-03-19 Thread Bing Zhao
> -Original Message- > From: Neil Horman > Sent: Thursday, March 19, 2020 11:41 PM > To: David Marchand > Cc: Thomas Monjalon ; dev ; > Jerin Jacob Kollanukkaran ; Nithin Dabilpuram > ; dpdk stable ; Bing > Zhao > Subject: Re: [PATCH] devtools: fix check symbol change script > > On Thu,

Re: [dpdk-dev] [PATCH] devtools: fix check symbol change script

2020-03-19 Thread Neil Horman
On Thu, Mar 19, 2020 at 03:56:03PM +0100, David Marchand wrote: > On Thu, Mar 19, 2020 at 3:44 PM Nithin Dabilpuram > wrote: > > > > Fix check symbol change script to detect new diff file when > > it is in between "--- /dev/null" to "b/lib/...". > > Current awk line expects line to start with "a/

Re: [dpdk-dev] [PATCH] devtools: fix check symbol change script

2020-03-19 Thread David Marchand
On Thu, Mar 19, 2020 at 3:44 PM Nithin Dabilpuram wrote: > > Fix check symbol change script to detect new diff file when > it is in between "--- /dev/null" to "b/lib/...". > Current awk line expects line to start with "a/..." > which is not always true for all diffs. > As a result if in_map was '

[dpdk-dev] [PATCH] devtools: fix check symbol change script

2020-03-19 Thread Nithin Dabilpuram
Fix check symbol change script to detect new diff file when it is in between "--- /dev/null" to "b/lib/...". Current awk line expects line to start with "a/..." which is not always true for all diffs. As a result if in_map was '1' earlier, it will not be changed to '0' and we get check patch error