Re: [dpdk-dev] [PATCH] cycles: add isb before read cntvct_el0

2020-03-10 Thread Jerin Jacob
On Tue, Mar 10, 2020 at 8:09 AM Linhaifeng wrote: > > > > -邮件原件- > 发件人: Jerin Jacob [mailto:jerinjac...@gmail.com] > 发送时间: 2020年3月9日 23:43 > 收件人: Linhaifeng > 抄送: dev@dpdk.org; tho...@monjalon.net; Lilijun (Jerry) > ; chenchanghu ; xudingke > > 主题: R

Re: [dpdk-dev] [PATCH] cycles: add isb before read cntvct_el0

2020-03-10 Thread Jerin Jacob
Linhaifeng > > > Sent: Monday, March 9, 2020 5:23 PM > > > To: dev@dpdk.org; tho...@monjalon.net > > > Cc: chenchanghu ; xudingke > > > ; Lilijun (Jerry) > > > Subject: [dpdk-dev] [PATCH] cycles: add isb before read cntvct_el0 > > > > > >

Re: [dpdk-dev] [PATCH] cycles: add isb before read cntvct_el0

2020-03-10 Thread Linhaifeng
t; Subject: RE: [PATCH] cycles: add isb before read cntvct_el0 > > Hi Haifeng, > > > -Original Message- > > From: dev On Behalf Of Linhaifeng > > Sent: Monday, March 9, 2020 5:23 PM > > To: dev@dpdk.org; tho...@monjalon.net > > Cc: chenchanghu ; xuding

Re: [dpdk-dev] [PATCH] cycles: add isb before read cntvct_el0

2020-03-10 Thread Gavin Hu
Hi Haifeng, > -Original Message- > From: dev On Behalf Of Linhaifeng > Sent: Monday, March 9, 2020 5:23 PM > To: dev@dpdk.org; tho...@monjalon.net > Cc: chenchanghu ; xudingke > ; Lilijun (Jerry) > Subject: [dpdk-dev] [PATCH] cycles: add isb before read cntvct_el0 &

Re: [dpdk-dev] [PATCH] cycles: add isb before read cntvct_el0

2020-03-09 Thread Jerin Jacob
On Mon, Mar 9, 2020 at 2:43 PM Linhaifeng wrote: > > We nead isb rather than dsb to sync system counter to cntvct_el0. # Currently rte_rdtsc() does not have dsb. Right? or any barriers. # Why do you need it? If it regarding, getting accurate value then use rte_rdtsc_precise(). > > Signed-off-by:

[dpdk-dev] [PATCH] cycles: add isb before read cntvct_el0

2020-03-09 Thread Linhaifeng
We should use isb rather than dsb to sync system counter to cntvct_el0. Signed-off-by: Linhaifeng --- lib/librte_eal/common/include/arch/arm/rte_atomic_64.h | 3 +++ lib/librte_eal/common/include/arch/arm/rte_cycles_64.h | 2 ++ 2 files changed, 5 insertions(+) diff --git a/lib/librte_eal/commo

[dpdk-dev] [PATCH] cycles: add isb before read cntvct_el0

2020-03-09 Thread Linhaifeng
We should use isb rather than dsb to sync system counter to cntvct_el0. Signed-off-by: Haifeng Lin --- lib/librte_eal/common/include/arch/arm/rte_atomic_64.h | 3 +++ lib/librte_eal/common/include/arch/arm/rte_cycles_64.h | 2 ++ 2 files changed, 5 insertions(+) diff --git a/lib/librte_eal/comm

[dpdk-dev] [PATCH] cycles: add isb before read cntvct_el0

2020-03-09 Thread Linhaifeng
We should use isb rather than dsb to sync system counter to cntvct_el0. Signed-off-by: Haifeng Lin --- lib/librte_eal/common/include/arch/arm/rte_atomic_64.h | 3 +++ lib/librte_eal/common/include/arch/arm/rte_cycles_64.h | 2 ++ 2 files changed, 5 insertions(+) diff --git a/lib/librte_eal/common/

Re: [dpdk-dev] [PATCH] cycles: add isb before read cntvct_el0

2020-03-09 Thread David Marchand
On Mon, Mar 9, 2020 at 10:14 AM Linhaifeng wrote: > > We nead isb rather than dsb to sync system counter to cntvct_el0. I'll leave the arm maintainers look at this, but I have a comment on the form. > > Signed-off-by: Haifeng Lin > --- > lib/librte_eal/common/include/arch/arm/rte_atomic_64.h

[dpdk-dev] [PATCH] cycles: add isb before read cntvct_el0

2020-03-09 Thread Linhaifeng
We nead isb rather than dsb to sync system counter to cntvct_el0. Signed-off-by: Haifeng Lin --- lib/librte_eal/common/include/arch/arm/rte_atomic_64.h | 3 +++ lib/librte_eal/common/include/arch/arm/rte_cycles_64.h | 2 ++ 2 files changed, 5 insertions(+) diff --git a/lib/librte_eal/common/inc