[dpdk-dev] [PATCH] Pass verbose flag to kernel module

2014-10-15 Thread Thomas Monjalon
Sergio, I'd like to see a v2 patch with your explanations in commit log and with a Signed-off-by. > > - CROSS_COMPILE=$(CROSS) > > + V=$(if $(V),1,0) CROSS_COMPILE=$(CROSS) Minor nits: - paren is not needed for one letter variable - V option should go to the end to keep thing

[dpdk-dev] [PATCH] Pass verbose flag to kernel module

2014-10-15 Thread Gonzalez Monroy, Sergio
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, October 15, 2014 1:05 PM > To: De Lara Guarch, Pablo; Gonzalez Monroy, Sergio > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] Pass verbose flag to kernel

[dpdk-dev] [PATCH] Pass verbose flag to kernel module

2014-10-13 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Sergio Gonzalez > Monroy > Sent: Monday, October 06, 2014 5:09 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] Pass verbose flag to kernel module > > --- > mk/rte.module.mk

[dpdk-dev] [PATCH] Pass verbose flag to kernel module

2014-10-09 Thread Thomas Monjalon
Hi Sergio, 2014-10-09 10:37, Sergio Gonzalez Monroy: > On Wed, Oct 08, 2014 at 07:05:32PM +0200, Thomas Monjalon wrote: > > Hi Sergio, > > > > 2014-10-06 17:09, Sergio Gonzalez Monroy: > > > --- a/mk/rte.module.mk > > > +++ b/mk/rte.module.mk > > > @@ -78,7 +78,7 @@ build: _postbuild > > > $(MOD

[dpdk-dev] [PATCH] Pass verbose flag to kernel module

2014-10-09 Thread Sergio Gonzalez Monroy
On Wed, Oct 08, 2014 at 07:05:32PM +0200, Thomas Monjalon wrote: > Hi Sergio, > > 2014-10-06 17:09, Sergio Gonzalez Monroy: > > --- a/mk/rte.module.mk > > +++ b/mk/rte.module.mk > > @@ -78,7 +78,7 @@ build: _postbuild > > $(MODULE).ko: $(SRCS_LINKS) > > @if [ ! -f $(notdir Makefile) ]; then l

[dpdk-dev] [PATCH] Pass verbose flag to kernel module

2014-10-08 Thread Thomas Monjalon
Hi Sergio, 2014-10-06 17:09, Sergio Gonzalez Monroy: > --- a/mk/rte.module.mk > +++ b/mk/rte.module.mk > @@ -78,7 +78,7 @@ build: _postbuild > $(MODULE).ko: $(SRCS_LINKS) > @if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi > @$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDI

[dpdk-dev] [PATCH] Pass verbose flag to kernel module

2014-10-06 Thread Sergio Gonzalez Monroy
--- mk/rte.module.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mk/rte.module.mk b/mk/rte.module.mk index c4ca3fd..bd3c596 100644 --- a/mk/rte.module.mk +++ b/mk/rte.module.mk @@ -78,7 +78,7 @@ build: _postbuild $(MODULE).ko: $(SRCS_LINKS) @if [ ! -f $(notdir Make