Hi Sergio, 2014-10-09 10:37, Sergio Gonzalez Monroy: > On Wed, Oct 08, 2014 at 07:05:32PM +0200, Thomas Monjalon wrote: > > Hi Sergio, > > > > 2014-10-06 17:09, Sergio Gonzalez Monroy: > > > --- a/mk/rte.module.mk > > > +++ b/mk/rte.module.mk > > > @@ -78,7 +78,7 @@ build: _postbuild > > > $(MODULE).ko: $(SRCS_LINKS) > > > @if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi > > > @$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDIR) O=$(RTE_KERNELDIR) \ > > > - CROSS_COMPILE=$(CROSS) > > > + V=$(if $(V),1,0) CROSS_COMPILE=$(CROSS) > > > > Please could you explain why it is needed? > > The variable V should be inherited by the recursive make. > > It's working without your patch in my test. > > You are right. If you set V=1 in the commmand line it will inherit and pass > it down. > In the curent framework, we do not force V to be 1, just to be defined (coud > be V=y > or V=enable, etc). > This patch was just forcing the value to be 1 as it is the required value for > the > kernel makefiles. > > It is not a big deal and we could approach this by specifiying on the docs to > be V=1 > or any other way you think more appropiate?
Oh OK, I didn't imagine passing other value to V ;) It's better to fix makefile than doc. So I'm OK with this patch. -- Thomas
