Re: [RFC v3 08/26] dev: move unrelated macros from header

2022-08-24 Thread Thomas Monjalon
24/08/2022 13:52, Morten Brørup: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 24/08/2022 08:50, David Marchand: > > > On Fri, Jul 29, 2022 at 3:22 PM David Marchand > > > wrote: > > > > > > I don't like them either. > > > > > > Not sure where to put them though... > > > > > > > > > >

RE: [RFC v3 08/26] dev: move unrelated macros from header

2022-08-24 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, 24 August 2022 09.39 > > 24/08/2022 08:50, David Marchand: > > On Fri, Jul 29, 2022 at 3:22 PM David Marchand > > wrote: > > > > > > On Fri, Jul 29, 2022 at 11:59 AM Bruce Richardson > > > wrote: > > > > > > Personally, I re

Re: [RFC v3 08/26] dev: move unrelated macros from header

2022-08-24 Thread Thomas Monjalon
24/08/2022 08:50, David Marchand: > On Fri, Jul 29, 2022 at 3:22 PM David Marchand > wrote: > > > > On Fri, Jul 29, 2022 at 11:59 AM Bruce Richardson > > wrote: > > > > > Personally, I really don't like these macros at all. I think having > > > > > the > > > > > check explicitly in the code woul

Re: [RFC v3 08/26] dev: move unrelated macros from header

2022-08-23 Thread David Marchand
On Fri, Jul 29, 2022 at 3:22 PM David Marchand wrote: > > On Fri, Jul 29, 2022 at 11:59 AM Bruce Richardson > wrote: > > > > Personally, I really don't like these macros at all. I think having the > > > > check explicitly in the code would be far more readable, and would only > > > > be > > > >

Re: [RFC v3 08/26] dev: move unrelated macros from header

2022-07-29 Thread David Marchand
On Fri, Jul 29, 2022 at 11:59 AM Bruce Richardson wrote: > > > Personally, I really don't like these macros at all. I think having the > > > check explicitly in the code would be far more readable, and would only be > > > one line of code longer than the macro call. Is there some private header >

Re: [RFC v3 08/26] dev: move unrelated macros from header

2022-07-29 Thread Bruce Richardson
On Thu, Jul 28, 2022 at 09:32:38PM +0200, David Marchand wrote: > On Thu, Jul 28, 2022 at 6:38 PM Bruce Richardson > wrote: > > > > On Thu, Jul 28, 2022 at 05:26:22PM +0200, David Marchand wrote: > > > RTE_FUNC_PTR_OR_* macros have nothing to do with the rte_device object > > > and associated API.

Re: [RFC v3 08/26] dev: move unrelated macros from header

2022-07-28 Thread David Marchand
On Thu, Jul 28, 2022 at 6:38 PM Bruce Richardson wrote: > > On Thu, Jul 28, 2022 at 05:26:22PM +0200, David Marchand wrote: > > RTE_FUNC_PTR_OR_* macros have nothing to do with the rte_device object > > and associated API. > > Move them to rte_common.h and include it where needed. > > > > Signed-o

Re: [RFC v3 08/26] dev: move unrelated macros from header

2022-07-28 Thread Bruce Richardson
On Thu, Jul 28, 2022 at 05:26:22PM +0200, David Marchand wrote: > RTE_FUNC_PTR_OR_* macros have nothing to do with the rte_device object > and associated API. > Move them to rte_common.h and include it where needed. > > Signed-off-by: David Marchand > --- Personally, I really don't like these ma

[RFC v3 08/26] dev: move unrelated macros from header

2022-07-28 Thread David Marchand
RTE_FUNC_PTR_OR_* macros have nothing to do with the rte_device object and associated API. Move them to rte_common.h and include it where needed. Signed-off-by: David Marchand --- drivers/common/qat/qat_device.c| 1 + drivers/compress/qat/qat_comp_pmd.c| 1 +