On Fri, Jul 29, 2022 at 11:59 AM Bruce Richardson <bruce.richard...@intel.com> wrote: > > > Personally, I really don't like these macros at all. I think having the > > > check explicitly in the code would be far more readable, and would only be > > > one line of code longer than the macro call. Is there some private header > > > file we could move these to instead of rte_common.h so we can drop their > > > use in future if we decide to? > > > > I don't like them either. > > Not sure where to put them though... > > > > My "grep-all" shows no user in the projects consuming DPDK I track. > > We could mark those macros deprecated, fix our code and drop them later. > > > +1 to that. > Can they be marked as deprecated as part of the move perhaps (assuming we > get agreement to kill them?)
Yes. I'll wait for others to chime in, which means this will wait for after my days off :-). -- David Marchand