Re: [RFC v2] ethdev: an API for cache stashing hints

2024-10-25 Thread Andrew Rybchenko
On 10/23/24 20:59, Mattias Rönnblom wrote: On 2024-07-16 00:11, Wathsala Vithanage wrote: ... +/** + * + * @warning + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice + * + * Discover cache stashing hints and object types supported in the ethernet + * device. +

RE: [RFC v2] ethdev: an API for cache stashing hints

2024-10-24 Thread Wathsala Wathawana Vithanage
> If we had a hwtopo API in DPDK, we could just use a node id in such a graph > (of CPUs and caches) to describe were the data ideally would land. > In such a case, you could have a node id for DDR as well, and thus you could > drop the notion of "stashing". Just a "drop off the data here, please,

Re: [RFC v2] ethdev: an API for cache stashing hints

2024-10-23 Thread Stephen Hemminger
On Wed, 23 Oct 2024 19:59:35 +0200 Mattias Rönnblom wrote: > > diff --git a/lib/ethdev/ethdev_driver.h b/lib/ethdev/ethdev_driver.h > > index 883e59a927..b90dc8793b 100644 > > --- a/lib/ethdev/ethdev_driver.h > > +++ b/lib/ethdev/ethdev_driver.h > > @@ -1235,6 +1235,70 @@ typedef int (*eth_count_

Re: [RFC v2] ethdev: an API for cache stashing hints

2024-10-23 Thread Mattias Rönnblom
On 2024-07-16 00:11, Wathsala Vithanage wrote: An application provides cache stashing hints to the ethernet devices to improve memory access latencies from the CPU and the NIC. This patch introduces three distinct hints for this purpose. The RTE_ETH_DEV_STASH_HINT_HOST_WILLNEED hint indicates th

RE: [RFC v2] ethdev: an API for cache stashing hints

2024-10-04 Thread Wathsala Wathawana Vithanage
> > >> > > >> And I can see set() has two different APIs, > > >> 'rte_eth_dev_stashing_hints_rx' & 'rte_eth_dev_stashing_hints_tx', > > >> is there a reason to have two separate APIs instead of having one > > >> which gets RX & TX as argument, as done in internal device ops? > > > > > > Some types/

Re: [RFC v2] ethdev: an API for cache stashing hints

2024-10-04 Thread Stephen Hemminger
On Sun, 22 Sep 2024 22:43:55 +0100 Ferruh Yigit wrote: > >> > >> And I can see set() has two different APIs, > >> 'rte_eth_dev_stashing_hints_rx' & > >> 'rte_eth_dev_stashing_hints_tx', is there a reason to have two separate > >> APIs > >> instead of having one which gets RX & TX as argument, a

Re: [RFC v2] ethdev: an API for cache stashing hints

2024-09-22 Thread Ferruh Yigit
On 7/26/2024 9:01 PM, Wathsala Wathawana Vithanage wrote: >> rte_eth_X_get_capability() >> > > rte_eth_dev_stashing_hints_discover is somewhat similar. > >> Instead of adding RTE_ETH_DEV_CAPA_ macro and contaminating >> 'rte_eth_dev_info' with this edge use case, what do you think follow above >>

RE: [RFC v2] ethdev: an API for cache stashing hints

2024-07-26 Thread Wathsala Wathawana Vithanage
> rte_eth_X_get_capability() > rte_eth_dev_stashing_hints_discover is somewhat similar. > Instead of adding RTE_ETH_DEV_CAPA_ macro and contaminating > 'rte_eth_dev_info' with this edge use case, what do you think follow above > design and have dedicated get capability API? I think it's better

Re: [RFC v2] ethdev: an API for cache stashing hints

2024-07-22 Thread Ferruh Yigit
On 7/15/2024 11:11 PM, Wathsala Vithanage wrote: > An application provides cache stashing hints to the ethernet devices to > improve memory access latencies from the CPU and the NIC. This patch > introduces three distinct hints for this purpose. > > The RTE_ETH_DEV_STASH_HINT_HOST_WILLNEED hint in

Re: [RFC v2] ethdev: an API for cache stashing hints

2024-07-19 Thread Honnappa Nagarahalli
> On Jul 16, 2024, at 9:27 PM, Stephen Hemminger > wrote: > > On Mon, 15 Jul 2024 22:11:41 + > Wathsala Vithanage wrote: > >> An application provides cache stashing hints to the ethernet devices to >> improve memory access latencies from the CPU and the NIC. This patch >> introduces thre

RE: [RFC v2] ethdev: an API for cache stashing hints

2024-07-18 Thread Wathsala Wathawana Vithanage
> > My initial reaction is negative on this. The DPDK does not need more nerd > knobs for performance. If it is a performance win, it should be automatic and > handled by the driver. > > If you absolutely have to have another flag, then it should be in existing > config > (yes, extend the ABI) r

RE: [RFC v2] ethdev: an API for cache stashing hints

2024-07-17 Thread Konstantin Ananyev
> An application provides cache stashing hints to the ethernet devices to > improve memory access latencies from the CPU and the NIC. This patch > introduces three distinct hints for this purpose. > > The RTE_ETH_DEV_STASH_HINT_HOST_WILLNEED hint indicates that the host > (CPU) requires the data

Re: [RFC v2] ethdev: an API for cache stashing hints

2024-07-16 Thread Stephen Hemminger
On Mon, 15 Jul 2024 22:11:41 + Wathsala Vithanage wrote: > An application provides cache stashing hints to the ethernet devices to > improve memory access latencies from the CPU and the NIC. This patch > introduces three distinct hints for this purpose. > > The RTE_ETH_DEV_STASH_HINT_HOST_WI

[RFC v2] ethdev: an API for cache stashing hints

2024-07-15 Thread Wathsala Vithanage
An application provides cache stashing hints to the ethernet devices to improve memory access latencies from the CPU and the NIC. This patch introduces three distinct hints for this purpose. The RTE_ETH_DEV_STASH_HINT_HOST_WILLNEED hint indicates that the host (CPU) requires the data written by th