> > >> > > >> And I can see set() has two different APIs, > > >> 'rte_eth_dev_stashing_hints_rx' & 'rte_eth_dev_stashing_hints_tx', > > >> is there a reason to have two separate APIs instead of having one > > >> which gets RX & TX as argument, as done in internal device ops? > > > > > > Some types/hints may only apply to a single queue direction, so I > > > thought it would be better to separate them out into separate Rx and > > > Tx APIs for ease of comprehension/use for the developer. > > > In fact, underneath, it uses one API for both Rx and Tx. > > > > > > > Hi Wathsala, > > > > Do you still pursue this RFC, should we expect a new version for this > > release? > > > > Did you have any change to measure the impact of the changes in this patch? > > > > > > Btw, do you think the LLC aware lcore selection patch [1] can be > > relevant or can it help for the cases this patch addresses? > > > Don't think this is ready for 24.11 release. The patch fails multiple tests, > has > some doc issues and would need more exmaples and support. > > Since it requires an ABI change, if you want to pursue it further send a new > version and maybe it will be ready for next ABI breaking release 25.11.
I agree, I don't think it will be ready for 24.11 release. I will be sending out another version of this in the coming days. As we discussed in the summit, this also requires some work in the kernel to make it functional.
