On 5/4/2023 8:13 AM, Denis Pryazhennikov wrote:
> I think my patch isn't correct.
> I would say that
> - fec_capa is a set of bits produced by 'RTE_ETH_FEC_MODE_TO_CAPA()';
> - fec_mode is an element of 'enum rte_eth_fec_mode'.
>
> Based on this definition, replacing 'fec_capa' with 'fec_mode' sho
I think my patch isn't correct.
I would say that
- fec_capa is a set of bits produced by 'RTE_ETH_FEC_MODE_TO_CAPA()';
- fec_mode is an element of 'enum rte_eth_fec_mode'.
Based on this definition, replacing 'fec_capa' with 'fec_mode' should
involve changing the parameter type.
Probably I should
On 4/28/2023 11:27 AM, Denis Pryazhennikov wrote:
> Only one valid FEC mode can be get by rte_eth_fec_get().
> The previous name implied that more than one FEC mode
> can be obtained.
+1 and patch looks good.
But isn't this valid for 'rte_eth_fec_set()', it gets 'fec_mode'. FEC
capability has its
Only one valid FEC mode can be get by rte_eth_fec_get().
The previous name implied that more than one FEC mode
can be obtained.
Documentation was updated accordingly.
Signed-off-by: Denis Pryazhennikov
Acked-by: Ivan Malov
Acked-by: Viacheslav Galaktionov
---
lib/ethdev/rte_ethdev.c | 8 --
4 matches
Mail list logo
