Re: [PATCH v4] vdpa/ifc: fix update_datapath error handling

2022-11-10 Thread Taekyung Kim
On Thu, Nov 10, 2022 at 10:38:55AM +0100, David Marchand wrote: > On Thu, Nov 10, 2022 at 10:34 AM Ali Alnubani wrote: > > > > I think the mail for v4 is lost. > > > > Whenever I send a patch, I received "Your message to dev awaits > > > moderator approval" > > > > from dev-ow...@dpdk.org with the

Re: [PATCH v4] vdpa/ifc: fix update_datapath error handling

2022-11-10 Thread Maxime Coquelin
: [PATCH v4] vdpa/ifc: fix update_datapath error handling Hi Taekyung, Adding Thomas and Ali who maintains the patchwork instance. On 11/10/22 05:02, Taekyung Kim wrote: On Thu, Nov 10, 2022 at 01:53:50AM +, Xia, Chenbo wrote: Hi Kim, -Original Message- From: Taekyung Kim Sent

Re: [PATCH v4] vdpa/ifc: fix update_datapath error handling

2022-11-10 Thread David Marchand
On Thu, Nov 10, 2022 at 10:34 AM Ali Alnubani wrote: > > > I think the mail for v4 is lost. > > > Whenever I send a patch, I received "Your message to dev awaits > > moderator approval" > > > from dev-ow...@dpdk.org with the reason "Post by non-member to a > > members-only list". > > > Maybe, the

[PATCH v4] vdpa/ifc: fix update_datapath error handling

2022-11-10 Thread Taekyung Kim
Stop and return the error code when update_datapath fails. update_datapath prepares resources for the vdpa device. The driver should not perform any further actions if update_datapath returns an error. Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver") Cc: sta...@dpdk.org Signed-off-by: Tae

RE: [PATCH v4] vdpa/ifc: fix update_datapath error handling

2022-11-10 Thread Ali Alnubani
> >> > >>> -Original Message- > >>> From: Taekyung Kim > >>> Sent: Tuesday, November 8, 2022 4:56 PM > >>> To: dev@dpdk.org > >>> Cc: Xia, Chenbo ; Pei, Andy > ; > >>> kim.tae.ky...@navercorp.com; maxime.

Re: [PATCH v4] vdpa/ifc: fix update_datapath error handling

2022-11-10 Thread Maxime Coquelin
: Xia, Chenbo ; Pei, Andy ; kim.tae.ky...@navercorp.com; maxime.coque...@redhat.com; sta...@dpdk.org; Wang, Xiao W Subject: [PATCH v4] vdpa/ifc: fix update_datapath error handling Stop and return the error code when update_datapath fails. update_datapath prepares resources for the vdpa device. The

Re: [PATCH v4] vdpa/ifc: fix update_datapath error handling

2022-11-09 Thread Taekyung Kim
rcorp.com; maxime.coque...@redhat.com; sta...@dpdk.org; > > Wang, Xiao W > > Subject: [PATCH v4] vdpa/ifc: fix update_datapath error handling > > > > Stop and return the error code when update_datapath fails. > > update_datapath prepares resources for the vdpa device. >

RE: [PATCH v4] vdpa/ifc: fix update_datapath error handling

2022-11-09 Thread Xia, Chenbo
Hi Kim, > -Original Message- > From: Taekyung Kim > Sent: Tuesday, November 8, 2022 4:56 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Pei, Andy ; > kim.tae.ky...@navercorp.com; maxime.coque...@redhat.com; sta...@dpdk.org; > Wang, Xiao W > Subject: [PATCH v4] vdpa/

Re: [PATCH v4] vdpa/ifc: fix update_datapath error handling

2022-11-09 Thread Taekyung Kim
dy ; > > kim.tae.ky...@navercorp.com; maxime.coque...@redhat.com; > > sta...@dpdk.org; Wang, Xiao W > > Subject: [PATCH v4] vdpa/ifc: fix update_datapath error handling > > > > Stop and return the error code when update_datapath fails. > > update_datapath prepares reso

Re: [PATCH v4] vdpa/ifc: fix update_datapath error handling

2022-11-09 Thread Taekyung Kim
Hi Maxime, Thanks for your review. On Tue, Nov 08, 2022 at 02:49:39PM +0100, Maxime Coquelin wrote: > Hi Taekyung, > > On 11/8/22 09:56, Taekyung Kim wrote: > > Stop and return the error code when update_datapath fails. > > update_datapath prepares resources for the vdpa device. > > The driver s

RE: [PATCH v4] vdpa/ifc: fix update_datapath error handling

2022-11-08 Thread Pei, Andy
> -Original Message- > From: Taekyung Kim > Sent: Tuesday, November 8, 2022 4:56 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Pei, Andy ; > kim.tae.ky...@navercorp.com; maxime.coque...@redhat.com; > sta...@dpdk.org; Wang, Xiao W > Subject: [PATCH v4] vdpa/ifc: f

Re: [PATCH v4] vdpa/ifc: fix update_datapath error handling

2022-11-08 Thread Maxime Coquelin
Hi Taekyung, On 11/8/22 09:56, Taekyung Kim wrote: Stop and return the error code when update_datapath fails. update_datapath prepares resources for the vdpa device. The driver should not perform any further actions if update_datapath returns an error. Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf