On 11/10/22 10:34, Ali Alnubani wrote:
-----Original Message-----
From: Maxime Coquelin <maxime.coque...@redhat.com>
Sent: Thursday, November 10, 2022 11:20 AM
To: Taekyung Kim <kim.tae.ky...@navercorp.com>; NBU-Contact-Thomas
Monjalon (EXTERNAL) <tho...@monjalon.net>; Ali Alnubani
<alia...@nvidia.com>
Cc: dev@dpdk.org; Pei, Andy <andy....@intel.com>; sta...@dpdk.org;
Wang, Xiao W <xiao.w.w...@intel.com>; Xia, Chenbo
<chenbo....@intel.com>
Subject: Re: [PATCH v4] vdpa/ifc: fix update_datapath error handling
Hi Taekyung,
Adding Thomas and Ali who maintains the patchwork instance.
On 11/10/22 05:02, Taekyung Kim wrote:
On Thu, Nov 10, 2022 at 01:53:50AM +0000, Xia, Chenbo wrote:
Hi Kim,
-----Original Message-----
From: Taekyung Kim <kim.tae.ky...@navercorp.com>
Sent: Tuesday, November 8, 2022 4:56 PM
To: dev@dpdk.org
Cc: Xia, Chenbo <chenbo....@intel.com>; Pei, Andy
<andy....@intel.com>;
kim.tae.ky...@navercorp.com; maxime.coque...@redhat.com;
sta...@dpdk.org;
Wang, Xiao W <xiao.w.w...@intel.com>
Subject: [PATCH v4] vdpa/ifc: fix update_datapath error handling
Stop and return the error code when update_datapath fails.
update_datapath prepares resources for the vdpa device.
The driver should not perform any further actions
if update_datapath returns an error.
Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver")
Cc: sta...@dpdk.org
Signed-off-by: Taekyung Kim <kim.tae.ky...@navercorp.com>
---
v4:
* Add rte_vdpa_unregister_device in ifcvf_pci_probe
v3:
* Fix coding style
v2:
* Revert the prepared resources before returning an error
* Rebase to 22.11 rc2
* Add fixes and cc for backport
---
drivers/vdpa/ifc/ifcvf_vdpa.c | 27 +++++++++++++++++++++++----
1 file changed, 23 insertions(+), 4 deletions(-)
I can't find your patch in patchwork:
http://patchwork.dpdk.org/project/dpdk/list/?series=&submitter=2877&sta
te=*&q=&archive=both&delegate=
so it's difficult to review and merge. Do you know why or is it possible
that you send a new version to make it show on Patchwork today?
Thanks,
Chenbo
Hi Chenbo,
First, thanks for your review.
I will send a new version for this patch soon.
I think the mail for v4 is lost.
Whenever I send a patch, I received "Your message to dev awaits
moderator approval"
from dev-ow...@dpdk.org with the reason "Post by non-member to a
members-only list".
Maybe, the reason is that this is the first time that I submit a patch.
No, I don't think subscription is needed, there should be another issue.
Ali & Thomas, any idea why it happens?
Hello,
Subscription to the dev mailing list is required for posting without moderator
approval.
I see that Taekyung is a member only since Nov 08. Postings prior to his
subscription are waiting moderation.
Ok, thanks. I did not know!
Maxime
Thanks,
Ali
