Re:RE: [PATCH v4] ip_frag: add IPv4 options fragment and test data

2022-03-21 Thread Huichao Cai
Hi Konstantin, >Could you explain why do we need that define at all? >As I can read the code, right now IPV4_IPOPT_MANUAL is always defined, >so all '#else' blocks are simply dead code. >Is there any reason to keep it? >If so, then the code probably need to be re-ordered somehow, >to make '

RE: [PATCH v4] ip_frag: add IPv4 options fragment and test data

2022-03-21 Thread Ananyev, Konstantin
Hi Huichao, > According to RFC791,the options may appear or not in datagrams. > They must be implemented by all IP modules (host and gateways). > What is optional is their transmission in any particular datagram, > not their implementation.So we have to deal with it during the > fragmenting proces

[PATCH v4] ip_frag: add IPv4 options fragment and test data

2022-03-15 Thread Huichao Cai
According to RFC791,the options may appear or not in datagrams. They must be implemented by all IP modules (host and gateways). What is optional is their transmission in any particular datagram, not their implementation.So we have to deal with it during the fragmenting process.Add some test data fo