Hi Konstantin, >Could you explain why do we need that define at all? >As I can read the code, right now IPV4_IPOPT_MANUAL is always defined, >so all '#else' blocks are simply dead code. >Is there any reason to keep it? >If so, then the code probably need to be re-ordered somehow, >to make '#else' part to be enabled and executed: >let say a separate test-case(s), and/or separate function or extra parameter >for test_get_ipv4_opt(). The code for the '#else' part is a relatively simple way to organize the test data, there is no need to stitch all the data together manually, but it is not as freely organized as the '#if' part of the code, and it was intended that as an alternative, I will remove the code of the '#else' part and resend the patch. Huichao Cai
- [PATCH v4] ip_frag: add IPv4 options fragment and test... Huichao Cai
- RE: [PATCH v4] ip_frag: add IPv4 options fragment... Ananyev, Konstantin
- Re:RE: [PATCH v4] ip_frag: add IPv4 options f... Huichao Cai
- [PATCH v5] ip_frag: add IPv4 options fragment and... Huichao Cai
- RE: [PATCH v5] ip_frag: add IPv4 options frag... Ananyev, Konstantin
- Re:RE: [PATCH v5] ip_frag: add IPv4 optio... Huichao Cai
- RE: Re:RE: [PATCH v5] ip_frag: add IP... Ananyev, Konstantin
- Re: [PATCH v5] ip_frag: add IPv4... Aaron Conole
- Re:Re: [PATCH v5] ip_frag: a... Huichao Cai
- [PATCH v6] ip_frag: add IPv4 options fragment... Huichao Cai
- Re: [PATCH v6] ip_frag: add IPv4 options ... Thomas Monjalon
- Re: [PATCH v6] ip_frag: add IPv4 opti... Thomas Monjalon
- Re:Re: [PATCH v6] ip_frag: add I... Huichao Cai