Re: [PATCH v3 1/6] common/mlx5: consider local functions as internal

2022-02-25 Thread Ferruh Yigit
On 2/25/2022 6:38 PM, Thomas Monjalon wrote: 25/02/2022 19:01, Ferruh Yigit: On 2/24/2022 11:25 PM, Michael Baum wrote: The functions which are not explicitly marked as internal were exported because the local catch-all rule was missing in the version script. After adding the missing rule, all

Re: [PATCH v3 1/6] common/mlx5: consider local functions as internal

2022-02-25 Thread Thomas Monjalon
25/02/2022 19:01, Ferruh Yigit: > On 2/24/2022 11:25 PM, Michael Baum wrote: > > The functions which are not explicitly marked as internal > > were exported because the local catch-all rule was missing in the > > version script. > > After adding the missing rule, all local functions are hidden. > >

Re: [PATCH v3 1/6] common/mlx5: consider local functions as internal

2022-02-25 Thread Ferruh Yigit
On 2/24/2022 11:25 PM, Michael Baum wrote: The functions which are not explicitly marked as internal were exported because the local catch-all rule was missing in the version script. After adding the missing rule, all local functions are hidden. The function mlx5_get_device_guid is used in anothe

[PATCH v3 1/6] common/mlx5: consider local functions as internal

2022-02-24 Thread Michael Baum
The functions which are not explicitly marked as internal were exported because the local catch-all rule was missing in the version script. After adding the missing rule, all local functions are hidden. The function mlx5_get_device_guid is used in another library, so it needs to be exported (as int