On 2/24/2022 11:25 PM, Michael Baum wrote:
The functions which are not explicitly marked as internal
were exported because the local catch-all rule was missing in the
version script.
After adding the missing rule, all local functions are hidden.
The function mlx5_get_device_guid is used in another library,
so it needs to be exported (as internal).
Because the local functions were exported as non-internal
in DPDK 21.11, any change in these functions would break the ABI.
An ABI exception is added for this library, considering that all
functions are either local or internal.
When a function is not listed explicitly in .map file, it shouldn't
be exported at all.
So I am not sure if this exception is required, did you get
warning for tool, or is this theoretical?
cc'ed David and Ray for comment.
Signed-off-by: Michael Baum <michae...@nvidia.com>
Acked-by: Matan Azrad <ma...@nvidia.com>
<...>
