Re: [PATCH v3] app/testpmd: support ddp dump command for ice

2022-05-23 Thread David Marchand
On Sat, May 21, 2022 at 3:20 AM Zhang, Qi Z wrote: > > > > Dump DDP runtime configure into a binary(package) file from ice PF port. > > > > > > > > Add command line: > > > > ddp dump > > > > > > > > Parameters: > > > >the PF Port ID > > > >dumped runtime configure file, i

RE: [PATCH v3] app/testpmd: support ddp dump command for ice

2022-05-20 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Qi Z > Sent: Friday, May 20, 2022 11:07 AM > To: David Marchand ; Yang, SteveX > > Cc: dev ; Zhang, Yuying ; Ferruh > Yigit ; Andrew Rybchenko > ; Thomas Monjalon > Subject: RE: [PATCH v3] app/testpmd: suppo

RE: [PATCH v3] app/testpmd: support ddp dump command for ice

2022-05-19 Thread Zhang, Qi Z
> -Original Message- > From: David Marchand > Sent: Thursday, May 19, 2022 8:13 PM > To: Yang, SteveX > Cc: dev ; Zhang, Yuying ; Zhang, Qi > Z ; Ferruh Yigit ; Andrew > Rybchenko ; Thomas Monjalon > > Subject: Re: [PATCH v3] app/testpmd: support ddp dump

Re: [PATCH v3] app/testpmd: support ddp dump command for ice

2022-05-19 Thread David Marchand
On Wed, May 18, 2022 at 9:07 AM Steve Yang wrote: > > Dump DDP runtime configure into a binary(package) file from ice PF port. > > Add command line: > ddp dump > > Parameters: >the PF Port ID >dumped runtime configure file, if not a absolute path, > it

Re: [PATCH v3] app/testpmd: support ddp dump command for ice

2022-05-19 Thread Andrew Rybchenko
On 5/18/22 18:24, Stephen Hemminger wrote: On Wed, 18 May 2022 06:58:06 + Steve Yang wrote: +#define ICE_BUFF_SIZE 0x000c9000 Having magic size hard coded in testpmd is bad idea. If there is driver specific size it should be exposed by API + size = ICE_BUFF_SIZE; + buff = (

Re: [PATCH v3] app/testpmd: support ddp dump command for ice

2022-05-18 Thread Stephen Hemminger
On Wed, 18 May 2022 06:58:06 + Steve Yang wrote: > +#define ICE_BUFF_SIZE0x000c9000 Having magic size hard coded in testpmd is bad idea. If there is driver specific size it should be exposed by API > + size = ICE_BUFF_SIZE; > + buff = (uint8_t *)malloc(ICE_BUFF_SIZE); Cast o

[PATCH v3] app/testpmd: support ddp dump command for ice

2022-05-18 Thread Steve Yang
Dump DDP runtime configure into a binary(package) file from ice PF port. Add command line: ddp dump Parameters: the PF Port ID dumped runtime configure file, if not a absolute path, it will be dumped to testpmd running directory. For example: testpmd>