Re: [PATCH v2 11/20] net/virtio: annotate lock for guest announce

2023-03-02 Thread David Marchand
On Thu, Mar 2, 2023 at 10:28 AM Maxime Coquelin wrote: > On 3/2/23 10:26, David Marchand wrote: > > On Mon, Feb 27, 2023 at 5:28 PM Maxime Coquelin > > wrote: > >> As discussed with David off-list, I think we could simplify and inline > >> virtio_dev_pause()/virtio_dev_resume() into virtio_notify

Re: [PATCH v2 11/20] net/virtio: annotate lock for guest announce

2023-03-02 Thread Maxime Coquelin
On 3/2/23 10:26, David Marchand wrote: On Mon, Feb 27, 2023 at 5:28 PM Maxime Coquelin wrote: As discussed with David off-list, I think we could simplify and inline virtio_dev_pause()/virtio_dev_resume() into virtio_notify_peers() since there are no other users of these functions (see below)

Re: [PATCH v2 11/20] net/virtio: annotate lock for guest announce

2023-03-02 Thread David Marchand
On Mon, Feb 27, 2023 at 5:28 PM Maxime Coquelin wrote: > As discussed with David off-list, I think we could simplify and inline > virtio_dev_pause()/virtio_dev_resume() into virtio_notify_peers() since > there are no other users of these functions (see below). I was looking at doing this and, as

RE: [PATCH v2 11/20] net/virtio: annotate lock for guest announce

2023-02-27 Thread Xia, Chenbo
Hi David & Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, February 28, 2023 12:28 AM > To: David Marchand ; Xia, Chenbo > > Cc: dev@dpdk.org; tho...@monjalon.net > Subject: Re: [PATCH v2 11/20] net/virtio: annotate lock for guest announce

Re: [PATCH v2 11/20] net/virtio: annotate lock for guest announce

2023-02-27 Thread Maxime Coquelin
Hi, On 2/27/23 09:24, David Marchand wrote: Hello Chenbo, Adding Maxime too. On Mon, Feb 27, 2023 at 3:05 AM Xia, Chenbo wrote: @@ -1217,7 +1217,7 @@ virtio_notify_peers(struct rte_eth_dev *dev) } /* If virtio port just stopped, no need to send RARP */ - if (virtio_dev_pau

Re: [PATCH v2 11/20] net/virtio: annotate lock for guest announce

2023-02-27 Thread David Marchand
Hello Chenbo, Adding Maxime too. On Mon, Feb 27, 2023 at 3:05 AM Xia, Chenbo wrote: > > @@ -1217,7 +1217,7 @@ virtio_notify_peers(struct rte_eth_dev *dev) > > } > > > > /* If virtio port just stopped, no need to send RARP */ > > - if (virtio_dev_pause(dev) < 0) { > > + if (vi

RE: [PATCH v2 11/20] net/virtio: annotate lock for guest announce

2023-02-26 Thread Xia, Chenbo
Hi David, > -Original Message- > From: David Marchand > Sent: Friday, February 24, 2023 11:12 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Maxime Coquelin ; Xia, > Chenbo > Subject: [PATCH v2 11/20] net/virtio: annotate lock for guest announce > > Expo

[PATCH v2 11/20] net/virtio: annotate lock for guest announce

2023-02-24 Thread David Marchand
Expose requirements for helpers dealing with the VIRTIO_DEV_TO_HW(dev)->state_lock lock. Signed-off-by: David Marchand --- drivers/net/virtio/virtio_ethdev.c | 8 drivers/net/virtio/virtio_ethdev.h | 7 +-- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/net/v