On Thu, Mar 2, 2023 at 10:28 AM Maxime Coquelin <maxime.coque...@redhat.com> wrote: > On 3/2/23 10:26, David Marchand wrote: > > On Mon, Feb 27, 2023 at 5:28 PM Maxime Coquelin > > <maxime.coque...@redhat.com> wrote: > >> As discussed with David off-list, I think we could simplify and inline > >> virtio_dev_pause()/virtio_dev_resume() into virtio_notify_peers() since > >> there are no other users of these functions (see below). > > > > I was looking at doing this and, as we discussed offlist, realised > > what the "inject" code was doing. > > > > I don't like the idea of keeping virtio_inject_pkts as a helper. > > This is tightly linked to the hw->started + usleep() trick, and this > > code has no check about its requirement on hw->started == 0. > > I'd rather "inline" and remove this helper too. > > Makes sense, do you want to submit it or are you willing me to do it?
I'll handle it, either during this release, or the next one. This code has always been ugly, this can wait one more release. -- David Marchand
