Re: [EXT] Re: [PATCH v2 1/1] ml/cnxk: fix multiple coverity issues

2023-03-16 Thread Thomas Monjalon
16/03/2023 18:02, Srikanth Yalavarthi: > > -Original Message- > > From: Thomas Monjalon > > Sent: 16 March 2023 22:30 > > To: Srikanth Yalavarthi > > Cc: Prince Takkar ; Shivah Shankar Shankar Narayan > > Rao ; dev@dpdk.org; Anup Prabhu > > >

RE: [EXT] Re: [PATCH v2 1/1] ml/cnxk: fix multiple coverity issues

2023-03-16 Thread Srikanth Yalavarthi
> -Original Message- > From: Thomas Monjalon > Sent: 16 March 2023 22:30 > To: Srikanth Yalavarthi > Cc: Prince Takkar ; Shivah Shankar Shankar Narayan > Rao ; dev@dpdk.org; Anup Prabhu > > Subject: [EXT] Re: [PATCH v2 1/1] ml/cnxk: fix multiple coverity is

Re: [PATCH v2 1/1] ml/cnxk: fix multiple coverity issues

2023-03-16 Thread Thomas Monjalon
16/03/2023 10:33, Srikanth Yalavarthi: > Added checks for null pointers. Removed logically dead code. > Fix division or modulo by zero. Fix evaluation order violation > issues. Fix potential memory leak in xstats function. I think it would be better to split this patch a little, so we can easily s

[PATCH v2 1/1] ml/cnxk: fix multiple coverity issues

2023-03-16 Thread Srikanth Yalavarthi
Added checks for null pointers. Removed logically dead code. Fix division or modulo by zero. Fix evaluation order violation issues. Fix potential memory leak in xstats function. Coverity issue: 383658 383659, 383664, 383665 Fixes: 817e3e55bb18 ("ml/cnxk: support simulator environment") Fixes: da33