16/03/2023 18:02, Srikanth Yalavarthi: > > -----Original Message----- > > From: Thomas Monjalon <tho...@monjalon.net> > > Sent: 16 March 2023 22:30 > > To: Srikanth Yalavarthi <syalavar...@marvell.com> > > Cc: Prince Takkar <ptak...@marvell.com>; Shivah Shankar Shankar Narayan > > Rao <sshankarn...@marvell.com>; dev@dpdk.org; Anup Prabhu > > <apra...@marvell.com> > > Subject: [EXT] Re: [PATCH v2 1/1] ml/cnxk: fix multiple coverity issues > > > > External Email > > > > ---------------------------------------------------------------------- > > 16/03/2023 10:33, Srikanth Yalavarthi: > > > Added checks for null pointers. Removed logically dead code. > > > Fix division or modulo by zero. Fix evaluation order violation issues. > > > Fix potential memory leak in xstats function. > > > > I think it would be better to split this patch a little, so we can easily > > see what > > are the reasons for the changes. > > Separate patch for each Coverity issue?
Maybe yes. Or try to group similar causes.
