Re: [PATCH v2] net/tap: fix to populate fds in secondary process

2022-01-28 Thread Ferruh Yigit
On 1/28/2022 9:55 AM, kumaraparameshwaran rathinavel wrote: > +static int > +tap_mp_req_start_rxtx(const struct rte_mp_msg *request, __rte_unused const void *peer) > +{ I asked last time but I don't remember the response, what should be in the 'peer' variable? The peer variable is currently

Re: [PATCH v2] net/tap: fix to populate fds in secondary process

2022-01-28 Thread kumaraparameshwaran rathinavel
Hi Ferruh, Please find the consolidated comments for the review. I had missed answering a few of them in my previous email. On Mon, Jan 24, 2022 at 6:05 PM Ferruh Yigit wrote: > On 1/24/2022 12:12 PM, Kumara Parameshwaran wrote: > > From: Kumara Parameshwaran > > > > When a tap device is hotpl

Re: [PATCH v2] net/tap: fix to populate fds in secondary process

2022-01-25 Thread Kumara Parameshwaran
From: Ferruh Yigit Sent: 24 January 2022 18:05 To: Kumara Parameshwaran ; dev@dpdk.org Cc: Kumara Parameshwaran ; sta...@dpdk.org Subject: Re: [PATCH v2] net/tap: fix to populate fds in secondary process On 1/24/2022 12:12 PM, Kumara Parameshwaran wrote

Re: [PATCH v2] net/tap: fix to populate fds in secondary process

2022-01-24 Thread Ferruh Yigit
On 1/24/2022 12:37 PM, Kumara Parameshwaran wrote: From: Kumara Parameshwaran When a tap device is hotplugged to primary process which in turn adds the device to all secondary process, the secondary process does a tap_mp_attach_queues, but the fds are not populated in the primary during the prob

Re: [PATCH v2] net/tap: fix to populate fds in secondary process

2022-01-24 Thread Ferruh Yigit
On 1/24/2022 12:54 PM, kumaraparameshwaran rathinavel wrote: On Mon, Jan 24, 2022 at 6:05 PM Ferruh Yigit mailto:ferruh.yi...@intel.com>> wrote: On 1/24/2022 12:12 PM, Kumara Parameshwaran wrote: > From: Kumara Parameshwaran mailto:kparamesh...@vmware.com>> > > When a tap de

Re: [PATCH v2] net/tap: fix to populate fds in secondary process

2022-01-24 Thread kumaraparameshwaran rathinavel
On Mon, Jan 24, 2022 at 6:05 PM Ferruh Yigit wrote: > On 1/24/2022 12:12 PM, Kumara Parameshwaran wrote: > > From: Kumara Parameshwaran > > > > When a tap device is hotplugged to primary process which in turn > > adds the device to all secondary process, the secondary process > > does a tap_mp_a

[PATCH v2] net/tap: fix to populate fds in secondary process

2022-01-24 Thread Kumara Parameshwaran
From: Kumara Parameshwaran When a tap device is hotplugged to primary process which in turn adds the device to all secondary process, the secondary process does a tap_mp_attach_queues, but the fds are not populated in the primary during the probe they are populated during the queue_setup, added a

Re: [PATCH v2] net/tap: fix to populate fds in secondary process

2022-01-24 Thread Ferruh Yigit
On 1/24/2022 12:12 PM, Kumara Parameshwaran wrote: From: Kumara Parameshwaran When a tap device is hotplugged to primary process which in turn adds the device to all secondary process, the secondary process does a tap_mp_attach_queues, but the fds are not populated in the primary during the pro

[PATCH v2] net/tap: fix to populate fds in secondary process

2022-01-24 Thread Kumara Parameshwaran
From: Kumara Parameshwaran When a tap device is hotplugged to primary process which in turn adds the device to all secondary process, the secondary process does a tap_mp_attach_queues, but the fds are not populated in the primary during the probe they are populated during the queue_setup, added a