RE: [PATCH v16 3/3] drivers/net: add diagnostics macros to make code portable

2025-01-29 Thread Ali Alnubani
> -Original Message- > From: Andre Muezerie > Sent: Thursday, January 30, 2025 5:38 AM > To: Ali Alnubani > Cc: dev@dpdk.org; step...@networkplumber.org; bruce.richard...@intel.com > Subject: Re: [PATCH v16 3/3] drivers/net: add diagnostics macros to make code > port

Re: [PATCH v16 3/3] drivers/net: add diagnostics macros to make code portable

2025-01-29 Thread Andre Muezerie
crosoft.com > > > Cc: dev@dpdk.org; step...@networkplumber.org; bruce.richard...@intel.com > > > Subject: [PATCH v16 3/3] drivers/net: add diagnostics macros to make code > > > portable > > > > > > It was a common pattern to have "GCC diagnostic igno

RE: [PATCH v16 3/3] drivers/net: add diagnostics macros to make code portable

2025-01-29 Thread Ali Alnubani
> -Original Message- > From: Ali Alnubani > Sent: Wednesday, January 29, 2025 11:08 PM > To: Andre Muezerie > Cc: dev@dpdk.org; step...@networkplumber.org; bruce.richard...@intel.com > Subject: RE: [PATCH v16 3/3] drivers/net: add diagnostics macros to ma

RE: [PATCH v16 3/3] drivers/net: add diagnostics macros to make code portable

2025-01-29 Thread Ali Alnubani
> -Original Message- > From: Andre Muezerie > Sent: Wednesday, January 22, 2025 12:36 AM > To: andre...@linux.microsoft.com > Cc: dev@dpdk.org; step...@networkplumber.org; bruce.richard...@intel.com > Subject: [PATCH v16 3/3] drivers/net: add diagnostics macros to ma

RE: [PATCH v16 3/3] drivers/net: add diagnostics macros to make code portable

2025-01-23 Thread Morten Brørup
> From: Andre Muezerie [mailto:andre...@linux.microsoft.com] > Sent: Tuesday, 21 January 2025 23.36 > > It was a common pattern to have "GCC diagnostic ignored" pragmas > sprinkled over the code and only activate these pragmas for certain > compilers (gcc and clang). Clang supports GCC's pragma fo

[PATCH v16 3/3] drivers/net: add diagnostics macros to make code portable

2025-01-21 Thread Andre Muezerie
It was a common pattern to have "GCC diagnostic ignored" pragmas sprinkled over the code and only activate these pragmas for certain compilers (gcc and clang). Clang supports GCC's pragma for compatibility with existing source code, so #pragma GCC diagnostic and #pragma clang diagnostic are synonym