On Wed, Jan 29, 2025 at 09:10:40PM +0000, Ali Alnubani wrote: > > -----Original Message----- > > From: Ali Alnubani > > Sent: Wednesday, January 29, 2025 11:08 PM > > To: Andre Muezerie <andre...@linux.microsoft.com> > > Cc: dev@dpdk.org; step...@networkplumber.org; bruce.richard...@intel.com > > Subject: RE: [PATCH v16 3/3] drivers/net: add diagnostics macros to make > > code > > portable > > > > > -----Original Message----- > > > From: Andre Muezerie <andre...@linux.microsoft.com> > > > Sent: Wednesday, January 22, 2025 12:36 AM > > > To: andre...@linux.microsoft.com > > > Cc: dev@dpdk.org; step...@networkplumber.org; bruce.richard...@intel.com > > > Subject: [PATCH v16 3/3] drivers/net: add diagnostics macros to make code > > > portable > > > > > > It was a common pattern to have "GCC diagnostic ignored" pragmas > > > sprinkled over the code and only activate these pragmas for certain > > > compilers (gcc and clang). Clang supports GCC's pragma for > > > compatibility with existing source code, so #pragma GCC diagnostic > > > and #pragma clang diagnostic are synonyms for Clang > > > (https://clang.llvm.org/docs/UsersManual.html). > > > > > > Now that effort is being made to make the code compatible with MSVC > > > these expressions would become more complex. It makes sense to hide > > > this complexity behind macros. This makes maintenance easier as these > > > macros are defined in a single place. As a plus the code becomes > > > more readable as well. > > > > > > Signed-off-by: Andre Muezerie <andre...@linux.microsoft.com> > > > --- > > > > Hello, > > > > This patch is causing a build failure on PowerPC64, affecting both cross- > > compilation on x86_64 and native builds on PowerPC64 systems: > > > > drivers/net/mlx5/mlx5_rxtx_vec_altivec.h:77:3: error: cast discards > > 'volatile' > > qualifier from pointer target type [-Werror=cast-qual] > > Compiler: powerpc64le-linux-gnu-gcc 9.4.0 > > > > > Regards, > > Ali
Hi Ali. Sorry for the trouble caused. Unfortunately the CI pipeline did not catch this. A patch fixing this issue was submitted earlier today: https://patches.dpdk.org/project/dpdk/patch/1738172139-31201-1-git-send-email-andre...@linux.microsoft.com/ Regards, Andre Muezerie
