01/11/2022 11:07, Shun Hao:
> This patch fixes this by making all action flags definition as 64-bit
> data type.
No, it is defining as unsigned long long.
[...]
> /* Actions */
> -#define MLX5_FLOW_ACTION_DROP (1u << 0)
> -#define MLX5_FLOW_ACTION_QUEUE (1u << 1)
> -#define MLX5_FLOW_ACTION_RSS
Hi,
> -Original Message-
> From: Shun Hao
> Sent: Tuesday, November 1, 2022 12:07 PM
> To: Slava Ovsiienko ; Matan Azrad
> ; Ori Kam ; Bing Zhao
>
> Cc: dev@dpdk.org; Raslan Darawsheh ;
> sta...@dpdk.org
> Subject: [PATCH v1] net/mlx5: fix action flag data
MLX5_FLOW_ACTION flags are used as uint64_t now, but some old flags
are not defined as 64 bits. So if they are type casted to uint64 after
bitwise operations, the high 32-bit data might be incorrect.
E.g. Currently MLX5_FLOW_ACTION_DROP is defined as 0x1u, when it is used
like:
(action_fla
3 matches
Mail list logo
