RE: [EXTERNAL] Re: [PATCH 4/4] net/netvsc: cache device parameters for hot plug events

2025-02-03 Thread Long Li
> From: Stephen Hemminger > Sent: Wednesday, January 29, 2025 7:59 PM > To: Long Li > Cc: lon...@linuxonhyperv.com; Ferruh Yigit ; Andrew > Rybchenko ; Wei Hu ; > dev@dpdk.org > Subject: Re: [EXTERNAL] Re: [PATCH 4/4] net/netvsc: cache device parameters > for hot plug ev

Re: [EXTERNAL] Re: [PATCH 4/4] net/netvsc: cache device parameters for hot plug events

2025-01-29 Thread Stephen Hemminger
On Wed, 29 Jan 2025 00:10:12 + Long Li wrote: > Another approach is to modify EAL to never delete driver arguments when a > device is removed. i.e., It doesn't call rte_devargs_remove() on device > removal, instead keep those devargs for the lifetime of the process. Do you > think this is

RE: [EXTERNAL] Re: [PATCH 4/4] net/netvsc: cache device parameters for hot plug events

2025-01-28 Thread Long Li
ice parameters > for hot plug events > > On Wed, 29 Jan 2025 00:10:12 + > Long Li wrote: > > > > Subject: [EXTERNAL] Re: [PATCH 4/4] net/netvsc: cache device > > > parameters for hot plug events > > > > > > On Mon, 27 Jan 2025 17:35:06 -

Re: [EXTERNAL] Re: [PATCH 4/4] net/netvsc: cache device parameters for hot plug events

2025-01-28 Thread Stephen Hemminger
On Wed, 29 Jan 2025 00:10:12 + Long Li wrote: > > Subject: [EXTERNAL] Re: [PATCH 4/4] net/netvsc: cache device parameters for > > hot plug events > > > > On Mon, 27 Jan 2025 17:35:06 -0800 > > lon...@linuxonhyperv.com wrote: > > > > > @

RE: [EXTERNAL] Re: [PATCH 4/4] net/netvsc: cache device parameters for hot plug events

2025-01-28 Thread Long Li
> Subject: [EXTERNAL] Re: [PATCH 4/4] net/netvsc: cache device parameters for > hot plug events > > On Mon, 27 Jan 2025 17:35:06 -0800 > lon...@linuxonhyperv.com wrote: > > > @@ -1409,9 +1424,6 @@ eth_hn_dev_uninit(struct rte_eth_dev *eth_dev) > >

Re: [PATCH 4/4] net/netvsc: cache device parameters for hot plug events

2025-01-28 Thread Stephen Hemminger
On Mon, 27 Jan 2025 17:35:06 -0800 lon...@linuxonhyperv.com wrote: > From: Long Li > > If a device is hot removed and hot plugged, it needs the same driver > parameters that are passed to EAL. However, during device removal, all > EAL driver parameters are freed as part of the cleanup. > > Cach

Re: [PATCH 4/4] net/netvsc: cache device parameters for hot plug events

2025-01-28 Thread Stephen Hemminger
On Mon, 27 Jan 2025 17:35:06 -0800 lon...@linuxonhyperv.com wrote: > @@ -1409,9 +1424,6 @@ eth_hn_dev_uninit(struct rte_eth_dev *eth_dev) > ret_stop = hn_dev_stop(eth_dev); > hn_dev_close(eth_dev); > > - free(hv->vf_devargs); > - hv->vf_devargs = NULL; > - > hn_detach(h

[PATCH 4/4] net/netvsc: cache device parameters for hot plug events

2025-01-27 Thread longli
From: Long Li If a device is hot removed and hot plugged, it needs the same driver parameters that are passed to EAL. However, during device removal, all EAL driver parameters are freed as part of the cleanup. Cache those driver parameters for future hot plug events. Because we don't know which