> From: Stephen Hemminger <step...@networkplumber.org> > Sent: Wednesday, January 29, 2025 7:59 PM > To: Long Li <lon...@microsoft.com> > Cc: lon...@linuxonhyperv.com; Ferruh Yigit <ferruh.yi...@amd.com>; Andrew > Rybchenko <andrew.rybche...@oktetlabs.ru>; Wei Hu <w...@microsoft.com>; > dev@dpdk.org > Subject: Re: [EXTERNAL] Re: [PATCH 4/4] net/netvsc: cache device parameters > for hot plug events > > On Wed, 29 Jan 2025 00:10:12 +0000 > Long Li <lon...@microsoft.com> wrote: > > > Another approach is to modify EAL to never delete driver arguments when a > device is removed. i.e., It doesn't call rte_devargs_remove() on device > removal, > instead keep those devargs for the lifetime of the process. Do you think this > is a > better approach? This will save work if other drivers want to cache devargs > list for > device hot plug events. > > Agree, that having devargs be smart enough to maintain the list for future > hotplug > is sensible. > Do other drivers that support hotplug have the same issue, or does no one ever > use devargs with things like failsafe.
This usage is most from netvsc and failsafe. The other driver using it is ifpga. But it looks it doesn't handle hot remove. I'm going to write a patch to have EAL cache devargs. Ferruh, is it okay that the first three patches can be merged? Thanks, Long
