Re: [PATCH 2/4] app/testpmd: fix burst option parsing

2024-03-13 Thread Stephen Hemminger
On Wed, 13 Mar 2024 12:09:01 + Ferruh Yigit wrote: > > Which is really close to the existing log message. > > > > if (rec_nb_pkts == 0) > > rte_exit(EXIT_FAILURE, > >

Re: [PATCH 2/4] app/testpmd: fix burst option parsing

2024-03-13 Thread Ferruh Yigit
On 3/13/2024 11:13 AM, David Marchand wrote: > On Wed, Mar 13, 2024 at 11:37 AM Ferruh Yigit wrote: >> >> On 3/13/2024 7:24 AM, David Marchand wrote: >>> On Tue, Mar 12, 2024 at 5:47 PM Ferruh Yigit wrote: On 3/8/2024 2:48 PM, David Marchand wrote: > rte_eth_dev_info_get() is not su

Re: [PATCH 2/4] app/testpmd: fix burst option parsing

2024-03-13 Thread David Marchand
On Wed, Mar 13, 2024 at 11:37 AM Ferruh Yigit wrote: > > On 3/13/2024 7:24 AM, David Marchand wrote: > > On Tue, Mar 12, 2024 at 5:47 PM Ferruh Yigit wrote: > >> > >> On 3/8/2024 2:48 PM, David Marchand wrote: > >>> rte_eth_dev_info_get() is not supposed to fail for a valid port_id, but > >>> for

Re: [PATCH 2/4] app/testpmd: fix burst option parsing

2024-03-13 Thread Ferruh Yigit
On 3/13/2024 7:24 AM, David Marchand wrote: > On Tue, Mar 12, 2024 at 5:47 PM Ferruh Yigit wrote: >> >> On 3/8/2024 2:48 PM, David Marchand wrote: >>> rte_eth_dev_info_get() is not supposed to fail for a valid port_id, but >>> for the theoretical case when it would fail, raise an error rather than

Re: [PATCH 2/4] app/testpmd: fix burst option parsing

2024-03-13 Thread David Marchand
On Tue, Mar 12, 2024 at 5:47 PM Ferruh Yigit wrote: > > On 3/8/2024 2:48 PM, David Marchand wrote: > > rte_eth_dev_info_get() is not supposed to fail for a valid port_id, but > > for the theoretical case when it would fail, raise an error rather than > > skip subsequent options. > > > > Fixes: 6f5

Re: [PATCH 2/4] app/testpmd: fix burst option parsing

2024-03-12 Thread Ferruh Yigit
On 3/8/2024 2:48 PM, David Marchand wrote: > rte_eth_dev_info_get() is not supposed to fail for a valid port_id, but > for the theoretical case when it would fail, raise an error rather than > skip subsequent options. > > Fixes: 6f51deb903b2 ("app/testpmd: check status of getting ethdev info") > C

[PATCH 2/4] app/testpmd: fix burst option parsing

2024-03-08 Thread David Marchand
rte_eth_dev_info_get() is not supposed to fail for a valid port_id, but for the theoretical case when it would fail, raise an error rather than skip subsequent options. Fixes: 6f51deb903b2 ("app/testpmd: check status of getting ethdev info") Cc: sta...@dpdk.org Signed-off-by: David Marchand ---