Re: [PATCH 2/3] power: defer lcore variable allocation

2024-12-16 Thread David Marchand
On Fri, Dec 13, 2024 at 7:58 AM Mattias Rönnblom wrote: > On 2024-12-12 08:57, David Marchand wrote: > > clb_multiwait, clb_pause and clb_scale_freq callbacks can only be > > reached after a successful call to > > rte_power_ethdev_pmgmt_queue_enable. > > Triggering an allocation in them means we a

Re: [PATCH 2/3] power: defer lcore variable allocation

2024-12-12 Thread Mattias Rönnblom
On 2024-12-12 08:57, David Marchand wrote: On Fri, Dec 6, 2024 at 12:29 PM Mattias Rönnblom wrote: I would wrap all RTE_LCORE_VAR_LCORE() and RTE_LCORE_VAR(). static struct pmd_core_cfg * get_cfg_lcore(unsigned int lcore_id) { assure_lcore_cfgs_alloced(); return RTE_LCORE_VAR

Re: [PATCH 2/3] power: defer lcore variable allocation

2024-12-11 Thread David Marchand
On Fri, Dec 6, 2024 at 12:29 PM Mattias Rönnblom wrote: > I would wrap all RTE_LCORE_VAR_LCORE() and RTE_LCORE_VAR(). > > static struct pmd_core_cfg * > get_cfg_lcore(unsigned int lcore_id) > { > assure_lcore_cfgs_alloced(); > return RTE_LCORE_VAR_LCORE(lcore_cfgs, lcore_id); > } >

Re: [PATCH 2/3] power: defer lcore variable allocation

2024-12-06 Thread Mattias Rönnblom
On 2024-12-05 18:57, David Marchand wrote: The lcore variable in this code unit is only used through rte_power_ethdev_pmgmt_queue_*() public symbols. Defer the unconditional lcore variable allocation in those symbols. Fixes: 130643319579 ("power: keep per-lcore state in lcore variable") Cc: sta

[PATCH 2/3] power: defer lcore variable allocation

2024-12-05 Thread David Marchand
The lcore variable in this code unit is only used through rte_power_ethdev_pmgmt_queue_*() public symbols. Defer the unconditional lcore variable allocation in those symbols. Fixes: 130643319579 ("power: keep per-lcore state in lcore variable") Cc: sta...@dpdk.org Signed-off-by: David Marchand