Re: [PATCH 2/3] drivers/common: add diagnostics macros to make code portable

2024-12-27 Thread Andre Muezerie
> Cc: dev@dpdk.org, Andre Muezerie > > Subject: [PATCH 2/3] drivers/common: add diagnostics macros to make code > > portable > > Date: Thu, 26 Dec 2024 17:33:15 -0800 > > X-Mailer: git-send-email 1.8.3.1 > > > > It was a common pattern to have "GCC diagnostic

Re: [PATCH 2/3] drivers/common: add diagnostics macros to make code portable

2024-12-27 Thread Stephen Hemminger
On Thu, 26 Dec 2024 17:33:15 -0800 Andre Muezerie wrote: > From: Andre Muezerie > To: Bruce Richardson , Konstantin Ananyev > , Jingjing Wu , > Praveen Shetty > Cc: dev@dpdk.org, Andre Muezerie > Subject: [PATCH 2/3] drivers/common: add diagnostics macros to make

[PATCH 2/3] drivers/common: add diagnostics macros to make code portable

2024-12-26 Thread Andre Muezerie
It was a common pattern to have "GCC diagnostic ignored" pragmas sprinkled over the code and only activate these pragmas for certain compilers (gcc and clang). Clang supports GCC’s pragma for compatibility with existing source code, so #pragma GCC diagnostic and #pragma clang diagnostic are synonym