On Thu, 26 Dec 2024 17:33:15 -0800 Andre Muezerie <andre...@linux.microsoft.com> wrote:
> From: Andre Muezerie <andre...@linux.microsoft.com> > To: Bruce Richardson <bruce.richard...@intel.com>, Konstantin Ananyev > <konstantin.v.anan...@yandex.ru>, Jingjing Wu <jingjing...@intel.com>, > Praveen Shetty <praveen.she...@intel.com> > Cc: dev@dpdk.org, Andre Muezerie <andre...@linux.microsoft.com> > Subject: [PATCH 2/3] drivers/common: add diagnostics macros to make code > portable > Date: Thu, 26 Dec 2024 17:33:15 -0800 > X-Mailer: git-send-email 1.8.3.1 > > It was a common pattern to have "GCC diagnostic ignored" pragmas > sprinkled over the code and only activate these pragmas for certain > compilers (gcc and clang). Clang supports GCC’s pragma for > compatibility with existing source code, so #pragma GCC diagnostic > and #pragma clang diagnostic are synonyms for Clang > (https://clang.llvm.org/docs/UsersManual.html). As much as possible, these should be fixed. Disabling warnings hides too many pre-existing bugs.
