Re: [PATCH] reorder: improve buffer structure layout

2023-04-14 Thread Tyler Retzlaff
On Fri, Apr 14, 2023 at 10:26:26AM +0100, Bruce Richardson wrote: > On Fri, Apr 14, 2023 at 10:43:43AM +0200, Volodymyr Fialko wrote: > > Rearrange the reorder buffer structure to prevent padding to extra one > > cache line. > > > > Current layout: > > struct rte_reorder_buffer { > > char

Re: [PATCH] reorder: improve buffer structure layout

2023-04-14 Thread Stephen Hemminger
On Fri, 14 Apr 2023 15:54:13 +0100 Bruce Richardson wrote: > On Fri, Apr 14, 2023 at 07:52:30AM -0700, Stephen Hemminger wrote: > > On Fri, 14 Apr 2023 10:43:43 +0200 > > Volodymyr Fialko wrote: > > > > > diff --git a/lib/reorder/rte_reorder.c b/lib/reorder/rte_reorder.c > > > index f55f38370

Re: [PATCH] reorder: improve buffer structure layout

2023-04-14 Thread Bruce Richardson
On Fri, Apr 14, 2023 at 07:52:30AM -0700, Stephen Hemminger wrote: > On Fri, 14 Apr 2023 10:43:43 +0200 > Volodymyr Fialko wrote: > > > diff --git a/lib/reorder/rte_reorder.c b/lib/reorder/rte_reorder.c > > index f55f383700..7418202b04 100644 > > --- a/lib/reorder/rte_reorder.c > > +++ b/lib/reor

Re: [PATCH] reorder: improve buffer structure layout

2023-04-14 Thread Stephen Hemminger
On Fri, 14 Apr 2023 10:43:43 +0200 Volodymyr Fialko wrote: > diff --git a/lib/reorder/rte_reorder.c b/lib/reorder/rte_reorder.c > index f55f383700..7418202b04 100644 > --- a/lib/reorder/rte_reorder.c > +++ b/lib/reorder/rte_reorder.c > @@ -46,9 +46,10 @@ struct rte_reorder_buffer { > char n

Re: [PATCH] reorder: improve buffer structure layout

2023-04-14 Thread Bruce Richardson
On Fri, Apr 14, 2023 at 10:43:43AM +0200, Volodymyr Fialko wrote: > Rearrange the reorder buffer structure to prevent padding to extra one > cache line. > > Current layout: > struct rte_reorder_buffer { > char name[RTE_REORDER_NAMESIZE]; > uint32_t min_seqn; > unsigned int

[PATCH] reorder: improve buffer structure layout

2023-04-14 Thread Volodymyr Fialko
Rearrange the reorder buffer structure to prevent padding to extra one cache line. Current layout: struct rte_reorder_buffer { char name[RTE_REORDER_NAMESIZE]; uint32_t min_seqn; unsigned int memsize; // -> padding to cache align (cir_buffer is also cache aligned) s