RE: [PATCH] mempool: fix get objects from mempool with cache

2022-01-28 Thread Morten Brørup
Olivier, thank you for the detailed feedback on my mempool RFC and patches. We might disagree on some points, but that is the point of having a discussion. :-) > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Monday, 24 January 2022 16.39 > > Hi Morten, > > Few comments below. > >

Re: [PATCH] mempool: fix get objects from mempool with cache

2022-01-24 Thread Olivier Matz
On Mon, Jan 24, 2022 at 04:38:58PM +0100, Olivier Matz wrote: > On Fri, Jan 14, 2022 at 05:36:50PM +0100, Morten Brørup wrote: > > --- a/lib/mempool/rte_mempool.h > > +++ b/lib/mempool/rte_mempool.h > > @@ -1443,6 +1443,10 @@ rte_mempool_put(struct rte_mempool *mp, void *obj) > > > > /** > > *

Re: [PATCH] mempool: fix get objects from mempool with cache

2022-01-24 Thread Olivier Matz
Hi Morten, Few comments below. On Fri, Jan 14, 2022 at 05:36:50PM +0100, Morten Brørup wrote: > A flush threshold for the mempool cache was introduced in DPDK version > 1.3, but rte_mempool_do_generic_get() was not completely updated back > then, and some inefficiencies were introduced. > > This

Re: [PATCH] mempool: fix get objects from mempool with cache

2022-01-18 Thread Bruce Richardson
On Tue, Jan 18, 2022 at 09:25:22AM +0100, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Monday, 17 January 2022 18.35 > > > > On Fri, Jan 14, 2022 at 05:36:50PM +0100, Morten Brørup wrote: > > > A flush threshold for the mempool cache was introduced

RE: [PATCH] mempool: fix get objects from mempool with cache

2022-01-18 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Monday, 17 January 2022 18.35 > > On Fri, Jan 14, 2022 at 05:36:50PM +0100, Morten Brørup wrote: > > A flush threshold for the mempool cache was introduced in DPDK > version > > 1.3, but rte_mempool_do_generic_get() was not compl

Re: [PATCH] mempool: fix get objects from mempool with cache

2022-01-17 Thread Bruce Richardson
On Fri, Jan 14, 2022 at 05:36:50PM +0100, Morten Brørup wrote: > A flush threshold for the mempool cache was introduced in DPDK version > 1.3, but rte_mempool_do_generic_get() was not completely updated back > then, and some inefficiencies were introduced. > > This patch fixes the following in rte

[PATCH] mempool: fix get objects from mempool with cache

2022-01-14 Thread Morten Brørup
A flush threshold for the mempool cache was introduced in DPDK version 1.3, but rte_mempool_do_generic_get() was not completely updated back then, and some inefficiencies were introduced. This patch fixes the following in rte_mempool_do_generic_get(): 1. The code that initially screens the cache