On Mon, Jan 24, 2022 at 04:38:58PM +0100, Olivier Matz wrote:
> On Fri, Jan 14, 2022 at 05:36:50PM +0100, Morten Brørup wrote:
> > --- a/lib/mempool/rte_mempool.h
> > +++ b/lib/mempool/rte_mempool.h
> > @@ -1443,6 +1443,10 @@ rte_mempool_put(struct rte_mempool *mp, void *obj)
> >
> > /**
> > * @internal Get several objects from the mempool; used internally.
> > + *
> > + * If cache is enabled, objects are returned from the cache in Last In
> > First
> > + * Out (LIFO) order for the benefit of CPUs with small L1 cache.
> > + *
> > * @param mp
> > * A pointer to the mempool structure.
> > * @param obj_table
> > @@ -1452,7 +1456,7 @@ rte_mempool_put(struct rte_mempool *mp, void *obj)
> > * @param cache
> > * A pointer to a mempool cache structure. May be NULL if not needed.
> > * @return
> > - * - >=0: Success; number of objects supplied.
> > + * - 0: Success; got n objects.
> > * - <0: Error; code of ring dequeue function.
> > */
> > static __rte_always_inline int
>
> I think that part should be in a separate commit too. This is a
> documentation fix, which is easily backportable (and should be
> backported) (Fixes: af75078fece3 ("first public release")).
I see that the same change is also part of this commit:
https://patches.dpdk.org/project/dpdk/patch/20211223100741.21292-1-chenzhiheng0...@gmail.com/
I think it is better to have a doc fix commit, and remove this chunk
from this patch.
