Re: [RFC] app/testpmd: use RSS conf from software when configuring DCB

Hi Stephen, Sorry for the delay. On Thur, Oct 10 at 2024 6:30AM, Stephen Hemminger wrote: On Wed, 12 Apr 2023 17:52:39 +0800 Min Zhou wrote: In the testpmd command, we have to stop the port firstly before configuring the DCB. However, some PMDs may execute a hardware reset during the port st

Re: [PATCH 0/5] Increase minimum meson version

:07 PM zhoumin <mailto:zhou...@loongson.cn>> wrote: Hi David, On Tues, Oct 8, 2024 at 8:28AM, David Marchand wrote: > Hello CI guys, > > On Fri, Sep 20, 2024 at 2:57 PM Bruce Richardson > mailto:bruce.richard...@intel.com>> wrote: >>

Re: [PATCH] net/mvneta: fix possible out-of-bounds write

Recheck-request: loongarch-compilation -- Just for a test, please ignore.

Just for a test, please ignore

Recheck-request: loongarch-compilation -- Just for a test, please ignore.

Re: [PATCH 0/5] Increase minimum meson version

Hi David, On Tues, Oct 8, 2024 at 8:28AM, David Marchand wrote: Hello CI guys, On Fri, Sep 20, 2024 at 2:57 PM Bruce Richardson wrote: This patchset proposed increasing the minimum meson version to 0.57 and makes changes to update our build files appropriately for that change: replacing depre

Re: [PATCH v7 01/21] net/ntnic: add ethdev and makes PMD available

Hi Patrick, Thanks for giving the link of commit `a6c3ec342ee1`. However I cannot checkout this commit in the next-net repository because the commit ID is not exist in the history of next-net repository. Could you find it? It seems that the commit `a6c3ec342ee1` is nearly identical to the c

Re: [PATCH v7 01/21] net/ntnic: add ethdev and makes PMD available

annot find this commit id in the history of next-net-main and next-net-for-main from the latest update. Did I miss one there? It seems that this series should rebase on the latest update of next-net (see below). On Fri, July 12, 2024 at 1:54PM, Patrick Robb wrote: Hello Zhoumin, It

Re: [PATCH v5 1/2] power: introduce PM QoS API on CPU wide

Hi Huisong, I knew that this patchset was based on the *dpdk-next-net* repository in our previous communication. However, maybe it's better to rebase this pactchset on the *dpdk* repository. Because the CI system is not smart enough to recognize the patchset as a change for the *dpdk-next-net*

Re: Email based retest request process: proposal for new pull/re-apply feature

On Tue, Mar 19, 2024 at 5:30PM, Patrick Robb wrote: On Tue, Mar 19, 2024 at 4:37 AM zhoumin wrote: One more thing I want to confirm is whether we should apply the patch onto the branch commit which existed at the time when that patch was submitted or onto the latest tip of branch if users

Re: [PATCH] doc: add dma perf feature details

On Mon, Mar 18, 2024 at 6:17PM, Amit Prakash Shukla wrote: Update dma perf test document with below support features: 1. Memory-to-device and device-to-memory copy. 2. Skip support. 3. Scatter-gather support. Signed-off-by: Amit Prakash Shukla --- doc/guides/tools/dmaperf.rst | 89 +

Re: Email based retest request process: proposal for new pull/re-apply feature

ould be a valid format if contexts are optional: Recheck-request: rebase=main Okay, I agree that contexts should not be considered by labs when we use rebase - but of course we will still store the contexts (if they are submitted) alongside the key value args. In the future there may be an appli

Re: Email based retest request process: proposal for new pull/re-apply feature

On Wed, Feb 21, 2024 at 2:24AM, Patrick Robb wrote: On Tue, Feb 20, 2024 at 1:12 PM Aaron Conole > wrote: Why not something like: Recheck-request: [attribute-list],[test-list]... For example, then we can do: Recheck-request: rebase=[identifier],.

Re: [PATCH 1/1] test/hash: fix error log output

On Wed, Sep 13, 2023 at 3:30PM, Stephen Hemminger wrote: On Tue, 12 Sep 2023 19:52:39 +0800 Min Zhou wrote: diff --git a/app/test/test_hash_readwrite.c b/app/test/test_hash_readwrite.c index 74ca13912f..4997a01249 100644 --- a/app/test/test_hash_readwrite.c +++ b/app/test/test_hash_readwrite

Re: [PATCH 1/1] drivers/net: fix checking for Tx simple

I'm sorry, I think the checking logic is certainly right after I read more codes in other drivers. I just wanted to use the i40e_xmit_pkts() function to send packets via testpmd. I noticed that the tx_simple_allowed should be false if I want to use the function to send packets. So, I'm studying

Re: [RFC] app/testpmd: use RSS conf from software when configuring DCB

Hi Ferruh, On Wed, June 7, 2023 at 2:09AM, Ferruh Yigit wrote: On 5/8/2023 2:21 AM, zhoumin wrote: Kindly ping. Hi Min, Sorry for the delay. Should we solve this problem by modifying PMDs? Is it suitable to maintain the RSS configurations for NIC by testpmd in order to set DCB? On Thur

Re: [PATCH v3] net/ixgbe: add proper memory barriers for some Rx functions

Hi Jiawen, On Tues, June 13, 2023 at 11:30PM, Jiawen Wu wrote: On Tuesday, June 13, 2023 9:43 AM, zhoumin wrote: On Mon, June 12, 2023 at 8:44PM, Thomas Monjalon wrote: 12/06/2023 13:58, zhoumin: On Mon, June 12, 2023 at 6:26PM, Thomas Monjalon wrote: 15/05/2023 04:10, Zhang, Qi Z: From

Re: [PATCH v3] net/ixgbe: add proper memory barriers for some Rx functions

Hi Thomas, On Mon, June 12, 2023 at 8:44PM, Thomas Monjalon wrote: 12/06/2023 13:58, zhoumin: On Mon, June 12, 2023 at 6:26PM, Thomas Monjalon wrote: 15/05/2023 04:10, Zhang, Qi Z: From: Ruifeng Wang From: Min Zhou --- v3: - Use rte_smp_rmb() as the proper memory barrier instead of

Re: [PATCH v3] net/ixgbe: add proper memory barriers for some Rx functions

Hi Thomas, On Mon, June 12, 2023 at 6:26PM, Thomas Monjalon wrote: 15/05/2023 04:10, Zhang, Qi Z: From: Ruifeng Wang From: Min Zhou Segmentation fault has been observed while running the ixgbe_recv_pkts_lro() function to receive packets on the Loongson 3C5000 processor which has 64 cores an

Re: [RFC] app/testpmd: use RSS conf from software when configuring DCB

Kindly ping. Should we solve this problem by modifying PMDs? Is it suitable to maintain the RSS configurations for NIC by testpmd in order to set DCB? On Thur, Apr 27, 2023 at 4:33PM, zhoumin wrote: Kindly ping. Any comments or suggestions will be appreciated. Best regards Min On 2023

Re: [PATCH v2] net/ixgbe: add proper memory barriers for some Rx functions

Hi Qi, On Thur, May 4, 2023 at 9:33PM, Zhang, Qi Z wrote: -Original Message- From: Morten Brørup Sent: Thursday, May 4, 2023 9:22 PM To: zhoumin ; Konstantin Ananyev Cc: dev@dpdk.org; maob...@loongson.cn; Yang, Qiming ; Wu, Wenjun1 ; ruifeng.w...@arm.com; d...@linux.vnet.ibm.com

Re: [PATCH v2] net/ixgbe: add proper memory barriers for some Rx functions

Hi Morten, On Thur, May 4, 2023 at 9:21PM, Morten Brørup wrote: From: zhoumin [mailto:zhou...@loongson.cn] Sent: Thursday, 4 May 2023 15.17 Hi Konstantin, Thanks for your  comments. On 2023/5/1 下午9:29, Konstantin Ananyev wrote: Segmentation fault has been observed while running the

Re: [PATCH v2] net/ixgbe: add proper memory barriers for some Rx functions

Hi Ruifeng, Thanks for your review. On Thur, May 4, 2023 at 2:13PM, Ruifeng Wang wrote: -Original Message- From: Konstantin Ananyev Sent: Monday, May 1, 2023 9:29 PM To: zhou...@loongson.cn Cc: dev@dpdk.org; maob...@loongson.cn; qiming.y...@intel.com; wenjun1...@intel.com; Ruifeng Wan

Re: [PATCH v2] net/ixgbe: add proper memory barriers for some Rx functions

Hi Konstantin, Thanks for your  comments. On 2023/5/1 下午9:29, Konstantin Ananyev wrote: Segmentation fault has been observed while running the ixgbe_recv_pkts_lro() function to receive packets on the Loongson 3C5000 processor which has 64 cores and 4 NUMA nodes. From the ixgbe_recv_pkts_lro()

Re: [PATCH v2] net/ixgbe: add proper memory barriers for some Rx functions

Hi Morten, Thanks for your comments. On Fri, Apr 28, 2023 at 2:27PM, Morten Brørup wrote: From: Zhang, Qi Z [mailto:qi.z.zh...@intel.com] Sent: Friday, 28 April 2023 05.44 From: Min Zhou Sent: Monday, April 24, 2023 5:06 PM Segmentation fault has been observed while running the ixgbe_recv_p

Re: [PATCH v2] net/ixgbe: add proper memory barriers for some Rx functions

Hi Qi, Thanks for your review. On Fri, Apr 28, 2023 at 11:43AM, Zhang, Qi Z wrote: -Original Message- From: Min Zhou Sent: Monday, April 24, 2023 5:06 PM To: Yang, Qiming ; Wu, Wenjun1 ; zhou...@loongson.cn Cc: dev@dpdk.org; maob...@loongson.cn Subject: [PATCH v2] net/ixgbe: add prop

Re: [PATCH] net/ixgbe: consider DCB/VMDq conf when getting RSS conf

Hi Qi, Thanks your kind review. On Thu, Apr 27, 2023 at 7:01PM, Zhang, Qi Z wrote: -Original Message- From: Min Zhou Sent: Wednesday, April 12, 2023 6:02 PM To: Yang, Qiming ; Wu, Wenjun1 ; zhou...@loongson.cn Cc: dev@dpdk.org; maob...@loongson.cn Subject: [PATCH] net/ixgbe: consider

Re: [PATCH] net/ixgbe: consider DCB/VMDq conf when getting RSS conf

Kindly ping. Any comments or suggestions will be appreciated. Best regards Min On Wed, Apr 12, 2023 at 6:01PM, Min Zhou wrote: The mrqe field of MRQC register is an enum. From the Intel 82599 datasheet, we know that these values below for the mrqe field are all related to RSS configuration:

Re: [RFC] app/testpmd: use RSS conf from software when configuring DCB

Kindly ping. Any comments or suggestions will be appreciated. Best regards Min On 2023/4/12 下午5:52, Min Zhou wrote: In the testpmd command, we have to stop the port firstly before configuring the DCB. However, some PMDs may execute a hardware reset during the port stop, such as ixgbe. Some ki

Re: [PATCH 1/1] net/ixgbe: add a proper memory barrier for LoongArch

Hi Bibo, On Sat, Apr 22, 2023 at 8:29AM, bibo, mao wrote: 在 2023/4/21 9:12, zhoumin 写道: On Fri, Apr 7, 2023 at 4:50PM, Min Zhou wrote: Segmentation fault has been observed while running the ixgbe_recv_pkts_lro() function to receive packets on the Loongson 3C5000 processor which has 64

Re: [PATCH 1/1] net/ixgbe: add a proper memory barrier for LoongArch

On Fri, Apr 7, 2023 at 4:50PM, Min Zhou wrote: Segmentation fault has been observed while running the ixgbe_recv_pkts_lro() function to receive packets on the Loongson 3C5000 processor which has 64 cores and 4 NUMA nodes. Reason is the read ordering of the status and the rest of the descriptor f

Re: [PATCH] malloc: enhance NUMA affinity heuristic

/home/zhoumin/dpdk/build/app/test/dpdk-test' '--file-prefix=eal_flags_c_opt_autotest' '--proc-type=secondary' '--lcores' '0-1,2@(5-7),(3-5)@(0,2),(0,6),7' Error - process did not run ok with valid corelist value Test Failed The logs don't give the full

Re: [PATCH v3 1/4] eal: add generic support for reading PMU events

Hi Tomasz, On Tue, Nov 29, 2022 at 5:28 PM, Tomasz Duszynski wrote: Add support for programming PMU counters and reading their values in runtime bypassing kernel completely. This is especially useful in cases where CPU cores are isolated (nohz_full) i.e run dedicated tasks. In such cases one ca

Re: [PATCH v8 0/6] Introduce support for LoongArch architecture

Hi, David, It is hard to find words to express my gratitude. On Thu, Oct 6, 2022 at 19:49, David Marchand wrote: Hello Min, On Tue, Oct 4, 2022 at 5:41 PM Min Zhou wrote: Dear team, The following patch set is intended to support DPDK running on LoongArch architecture. LoongArch is the gen

Re: [PATCH v2] vhost: fix build

Hi, Maxime, Thanks a lot for your kind reply. This patch is very useful and relieves the concerns in my heart. On Wed, Oct 5, 2022 at 22:51, Maxime Coquelin wrote: Hi Min, On 9/26/22 05:25, zhoumin wrote: Hi Chenbo, On Mon, 26 Sep 2022, 10:57, Xia, Chenbo wrote: Hi Min, -Original

Re: [PATCH v2] vhost: fix build

Hi, Maxime, Thanks a lot for your kind reply. This patch is very useful and relieves the concerns in my heart. On Wed, Oct 5, 2022 at 22:51, Maxime Coquelin wrote: Hi Min, On 9/26/22 05:25, zhoumin wrote: Hi Chenbo, On Mon, 26 Sep 2022, 10:57, Xia, Chenbo wrote: Hi Min, -Original

Re: [PATCH v7 0/7] Introduce support for LoongArch architecture

Hi, David, Thanks for your kind reply. On Tue, Oct 4, 2022 at 00:30, David Marchand wrote: Hello Min, On Sat, Oct 1, 2022 at 4:26 PM zhoumin wrote: I'm Sorry, I misunderstood the 'instructions' you said. The process of making the toolchain is a little complicated. So I mad

Re: [PATCH v7 1/7] eal/loongarch: support LoongArch architecture

Hi, David, Thanks a lot for your helpful reply. On Tue, Oct 4, 2022 at 01:15, David Marchand wrote: On Fri, Sep 30, 2022 at 10:02 AM Min Zhou wrote: Add all necessary elements for DPDK to compile and run EAL on LoongArch64 Soc. This includes: - EAL library implementation for LoongArch ISA.

Re: [PATCH v7 0/7] Introduce support for LoongArch architecture

On Tue, Oct 4, 2022 at 14:59, David Marchand wrote: On Fri, Sep 30, 2022 at 10:02 AM Min Zhou wrote: Dear team, The following patch set is intended to support DPDK running on LoongArch architecture. LoongArch is the general processor architecture of Loongson Corporation and is a new RISC IS

Re: [PATCH v7 0/7] Introduce support for LoongArch architecture

Hi, Ali, Thanks for your kind reply. On Mon, Oct 3, 2022 at 16:14, Ali Alnubani wrote: -Original Message- From: David Marchand Sent: Friday, September 30, 2022 5:21 PM To: zhoumin Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; bruce.richard...@intel.com; anatoly.bura...@intel.com

Re: [PATCH v7 0/7] Introduce support for LoongArch architecture

Hi, David, Thanks a lot for your helpful reply. On Fri, Sep 30, 2022 at 22:20, David Marchand wrote: On Fri, Sep 30, 2022 at 12:05 PM zhoumin wrote: On Fri, Sep 30, 2022 at 16:13, David Marchand wrote: On Fri, Sep 30, 2022 at 10:02 AM Min Zhou wrote: The online documents of LoongArch

Re: [PATCH v7 0/7] Introduce support for LoongArch architecture

Hi, David, Thanks a lot for your kind reply. On Fri, Sep 30, 2022 at 16:13, David Marchand wrote: Hello, On Fri, Sep 30, 2022 at 10:02 AM Min Zhou wrote: Dear team, The following patch set is intended to support DPDK running on LoongArch architecture. LoongArch is the general processor arc

Re: [PATCH v2] vhost: fix build

Hi Chenbo, On Mon, 26 Sep 2022, 10:57, Xia, Chenbo wrote: Hi Min, -Original Message- From: Min Zhou Sent: Monday, August 29, 2022 4:29 PM To: david.march...@redhat.com; maxime.coque...@redhat.com; Xia, Chenbo ; zhou...@loongson.cn Cc: dev@dpdk.org; maob...@loongson.cn Subject: [PATCH

Re: [PATCH v6 0/7] Introduce support for LoongArch architecture

Kindly ping. Could anyone give some feedback? Thanks. On 2022年08月27日 16:59, Min Zhou wrote: Dear team, The following patch set is intended to support DPDK running on LoongArch architecture. LoongArch is the general processor architecture of Loongson Corporation and is a new RISC ISA, which i

Re: [PATCH v6 0/7] Introduce support for LoongArch architecture

Kindly ping. Any feedback is appreciated. On 2022年08月27日 16:59, Min Zhou wrote: Dear team, The following patch set is intended to support DPDK running on LoongArch architecture. LoongArch is the general processor architecture of Loongson Corporation and is a new RISC ISA, which is a bit like

Re: [PATCH v2] vhost: fix build

Kindly ping. Any feedback is appreciated. On 2022年08月29日 16:29, Min Zhou wrote: On CentOS 8 or Debian 10.4 systems using gcc 12.1 to cross compile DPDK, gcc shows a following warning which will cause build to fail when build is run with -werror: In function 'mbuf_to_desc', inlined from '

Re: [PATCH v6 0/7] Introduce support for LoongArch architecture

Sincerely ping. On Sat, 27 Aug, 2022 at 16:59 +0800, Min Zhou wrote: Dear team, The following patch set is intended to support DPDK running on LoongArch architecture. LoongArch is the general processor architecture of Loongson Corporation and is a new RISC ISA, which is a bit like MIPS or RIS

Re: [PATCH v2] vhost: fix build

Sincerely ping. On 2022年08月29日 16:29, Min Zhou wrote: On CentOS 8 or Debian 10.4 systems using gcc 12.1 to cross compile DPDK, gcc shows a following warning which will cause build to fail when build is run with -werror: In function 'mbuf_to_desc', inlined from 'vhost_enqueue_async_packed'

Re: [PATCH v5 1/7] eal/loongarch: support LoongArch architecture

Hi David, Thank you very much for your reminder. On Thu, Aug 25, 2022 at 22:04, David Marchand wrote: On Thu, Aug 25, 2022 at 3:56 PM David Marchand wrote: This is only a first pass. Additionnally, please run ./devtools/check-meson.py. I see tabulations where we expect spaces. OK, thanks.

Re: [PATCH v5 1/7] eal/loongarch: support LoongArch architecture

Hi David, I appreciate you giving me these helpful comments. On Thu, Aug 25, 2022 at 21:56, David Marchand wrote: This is only a first pass. On Wed, Aug 24, 2022 at 10:31 AM Min Zhou wrote: diff --git a/MAINTAINERS b/MAINTAINERS index 32ffdd1a61..f00b82b5ce 100644 --- a/MAINTAINERS +++ b/MAI

Re: [PATCH v1] vhost: fix build

Hi David, Thanks for your kind reply. On Wed, Aug 24, 2022 at 22:09, David Marchand wrote: On Mon, Aug 22, 2022 at 9:42 AM Min Zhou wrote: This patch fixes the following build failure seen on CentOS 8 with gcc 12.1 because of uninitialized struct variable: [..] ../lib/vhost/virtio_net.c:

Re: [PATCH v1] vhost: fix build

Ping. On Mon, Aug 22, 2022 at 15:42, Min Zhou wrote: This patch fixes the following build failure seen on CentOS 8 with gcc 12.1 because of uninitialized struct variable: [..] ../lib/vhost/virtio_net.c:1159:18: warning: 'buf_vec[0].buf_addr' may be used uninitialized [-Wmaybe-uninitialized

Re: [v3 00/24] Support LoongArch architecture

On 2022年07月21日 00:33, David Marchand wrote: Hello, On Mon, Jun 6, 2022 at 3:11 PM Min Zhou wrote: Dear team, The following patch set is intended to support DPDK running on LoongArch architecture. LoongArch is the general processor architecture of Loongson and is a new RISC ISA, which is a

Re: [v3 01/24] eal/loongarch: add atomic operations for LoongArch

Ping for review or feedback for this new arch support. Thanks, Min On 2022年06月06日 21:10, Min Zhou wrote: This patch adds architecture specific atomic operations for LoongArch architecture. These implementations use standard atomics of toolchain and heavily reference generic atomics codes. Sig

Re: [v1 05/24] eal/loongarch: add spinlock operations for LoongArch

Stephen, Thanks for your comments! I'm evaluating the generic code of spinlock on std atomics of LoongArch toolchain. An updated patch will come later. On 2022/5/28 下午11:54, Stephen Hemminger wrote: On Sat, 28 May 2022 17:32:52 +0800 Min Zhou wrote: This patch adds spinlock operations for L

Re: [v1 01/24] eal/loongarch: add atomic operations for LoongArch

Stephen, Thanks for your comments! I'm evaluating the atomic operations of LoongArch toolchain. An updated patch will come later. On 2022/5/28 下午11:52, Stephen Hemminger wrote: On Sat, 28 May 2022 17:32:48 +0800 Min Zhou wrote: This patch adds architecture specific atomic operations for Loo