On Wed, Sep 13, 2023 at 3:30PM, Stephen Hemminger wrote:
On Tue, 12 Sep 2023 19:52:39 +0800
Min Zhou <zhou...@loongson.cn> wrote:

diff --git a/app/test/test_hash_readwrite.c
b/app/test/test_hash_readwrite.c index 74ca13912f..4997a01249 100644
--- a/app/test/test_hash_readwrite.c
+++ b/app/test/test_hash_readwrite.c
@@ -162,7 +162,7 @@ init_params(int use_ext, int use_htm, int rw_lf,
int use_jhash)
        handle = rte_hash_create(&hash_params);
        if (handle == NULL) {
-               printf("hash creation failed");
+               printf("hash creation failed\n");
Errors should be writen to stderr, not stdout?
It looks like the hash test doesn't do that anywhere though.

Agree! The errors should go to stderr. However, there are many such cases in app/test that errors were written to stderr.  It requires huge effort to fix them.

Regards,

Min


Reply via email to