[dpdk-dev] device reset handling with igb_uio

2019-06-14 Thread Santosh R
->vfio_pci_ioctl->vfio_msi_enable->pci_alloc_irq_vectors/vfio_msi_set_vector_signal->request_irq Regards -Santosh

Re: [dpdk-dev] [PATCH v2 2/2] eal: force IOVA to particular mode

2018-09-25 Thread Santosh Shukla
Hi Eric, On Tuesday 25 September 2018 02:12 AM, Zhang, Qing Long (Eric) wrote: > External Email > > Hi Santosh/Anatoly, > Any comments on the v2 patch which uses EAL option to let user configure > iova mode as suggested? > > Thanks > Eric > > -Original Messag

Re: [dpdk-dev] [PATCH] eal: force IOVA mode to physical

2018-08-30 Thread santosh
On Thursday 30 August 2018 07:26 PM, Legacy, Allain wrote: > External Email > >> -Original Message----- >> From: santosh [mailto:santosh.shu...@caviumnetworks.com] >> Sent: Thursday, August 30, 2018 8:59 AM >> To: hemant.agra...@nxp.com; Gaëtan Rivet; Burakov, A

Re: [dpdk-dev] [PATCH] eal: force IOVA mode to physical

2018-08-30 Thread santosh
On Thursday 30 August 2018 05:43 PM, Hemant wrote: > External Email > > Hi, > > On 8/30/2018 3:13 PM, Gaëtan Rivet wrote: >> Hi, >> >> On Thu, Aug 30, 2018 at 10:09:04AM +0100, Burakov, Anatoly wrote: >>> On 29-Aug-18 4:58 PM, eric zhang wrote: This patch adds a configuration option to force

Re: [dpdk-dev] [PATCH] net/octeontx: fix packet corruption on Tx

2018-08-17 Thread santosh
s: 9e747589bd4c ("net/octeontx: add packet transmit burst function") > Cc: sta...@dpdk.org > > Reported-by: Vikas Aggarwal > Signed-off-by: Jerin Jacob > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH] event/octeontx: prefetch mbuf instead of wqe

2018-07-17 Thread santosh
On Tuesday 17 July 2018 08:03 PM, Pavan Nikhilesh wrote: > Prefetch mbuf pointer instead of wqe when SSO receives pkt from PKI. > > Signed-off-by: Pavan Nikhilesh > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v2 1/2] eal: remove deprecated function returning mbuf pool ops name

2018-06-27 Thread santosh
On Tuesday 26 June 2018 03:26 PM, Olivier Matz wrote: > External Email > > rte_eal_mbuf_default_mempool_ops() is replaced by > rte_mbuf_best_mempool_ops(). > > Signed-off-by: Olivier Matz > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v2 2/2] eal: remove experimental tag from user mbuf pool ops func

2018-06-27 Thread santosh
On Tuesday 26 June 2018 03:26 PM, Olivier Matz wrote: > External Email > > Remove experimental tag from rte_eal_mbuf_user_pool_ops(). > > Signed-off-by: Olivier Matz > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH] mempool/octeontx: fix pool to aura mapping

2018-06-27 Thread santosh
> > Signed-off-by: Pavan Nikhilesh > --- Acked-by: Santosh Shukla Nits: May be introduce a macro something like #define AURA_IDX(gpool) (gpool << FPA_GAURA_SHIFT) Thanks.

Re: [dpdk-dev] [PATCH] mbuf: remove experimental tag from pool ops functions

2018-06-11 Thread santosh
ubject: [dpdk-dev] [PATCH] mbuf: remove experimental tag from pool ops >> functions >> X-Mailer: git-send-email 2.7.4 >> >> Signed-off-by: Hemant Agrawal Acked-by: Santosh Shukla Thanks.

Re: [dpdk-dev] [PATCH] eal: copy optarg when parsing mempool ops name

2018-05-06 Thread santosh
he latter could be clobbered > later and result in reading wrong mbuf pool ops name > by rte_mempool library. > > Typically, this flaw could be avoided by using strdup() > to remember the string value of the option. > > Fixes: a103a97e7191 ("eal: allow user to override default

Re: [dpdk-dev] [PATCH v3 00/68] Memory Hotplug for DPDK

2018-04-05 Thread santosh
ourtesy of Gowrishankar @ IBM > - Fixes for mempool size calculation > - Added convenience memseg walk() API's > - Added alloc validation callback > > v2: - fixed deadlock at init > - reverted rte_panic changes at init, this is now handled inside IPC Tested-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v3 10/11] mempool: remove callback to register memory area

2018-04-04 Thread santosh
On Monday 26 March 2018 09:39 PM, Andrew Rybchenko wrote: > The callback is not required any more since there is a new callback > to populate objects using provided memory area which provides > the same information. > > Signed-off-by: Andrew Rybchenko > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v3 08/11] mempool/octeontx: prepare to remove register memory area op

2018-04-04 Thread santosh
On Monday 26 March 2018 09:39 PM, Andrew Rybchenko wrote: > Callback to populate pool objects has all required information and > executed a bit later than register memory area callback. > > Signed-off-by: Andrew Rybchenko > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v3 06/11] mempool: remove callback to get capabilities

2018-04-04 Thread santosh
icient to describe mempool driver features. If required > in the future, API which returns structured information may be > added. > > Signed-off-by: Andrew Rybchenko > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v3 05/11] mempool: add op to populate objects using provided memory

2018-04-04 Thread santosh
: Andrew Rybchenko > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v3 04/11] mempool: add op to calculate memory size to be allocated

2018-04-04 Thread santosh
n accordance with driver requirements and > advertise requirements on minimum memory chunk size and alignment > in a generic way. > > Bump ABI version since the patch breaks it. > > Suggested-by: Olivier Matz > Signed-off-by: Andrew Rybchenko > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v3 03/11] mempool: ensure the mempool is initialized before populating

2018-04-04 Thread santosh
Andrew Rybchenko > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v4 2/2] octeontx: move mbox to common folder

2018-04-03 Thread santosh
reg += SSO_VHGRP_PF_MBOX(1); >> +if (octeontx_mbox_set_reg(reg)) { >> +mbox_log_err("Invalid Failed to set mbox_reg"); >> +return -EINVAL; >> +} >> +} >> + >> rte_wmb(); >> mbox_log_dbg("Domain=%d group=%d total_ssovfs=%d", res->domain, >> res->vfid, sdev.total_ssovfs); > With above changes: > > Acked-by: Jerin Jacob > Acked-by: Santosh Shukla Thanks.

Re: [dpdk-dev] [PATCH v4 1/2] drivers: add common folder

2018-04-03 Thread santosh
On Monday 02 April 2018 02:39 PM, Pavan Nikhilesh wrote: > Add driver/common folder and skeleton makefile for adding commonly used > functions across mempool, event and net devices. > > Signed-off-by: Pavan Nikhilesh > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v4] ethdev: replace bus specific struct with generic dev

2018-04-02 Thread santosh
Hello David, On Friday 30 March 2018 08:59 PM, David Marchand wrote: > On Fri, Mar 30, 2018 at 5:17 PM, Ferruh Yigit wrote: >> Public struct rte_eth_dev_info has a "struct rte_pci_device" field in it >> although it is common for all ethdev in all buses. >> >> Replacing pci specific struct with g

[dpdk-dev] [PATCH] net/octeontx: remove redundent driver name update

2018-04-02 Thread Santosh Shukla
Cc: sta...@dpdk.org Signed-off-by: Santosh Shukla --- drivers/net/octeontx/octeontx_ethdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c index 90dd249a6..b3512393a 100644 --- a/drivers/net/octeontx

Re: [dpdk-dev] [PATCH 2/4] eal: do not use physical addresses in IOVA as VA mode

2018-04-02 Thread santosh
On Monday 02 April 2018 03:32 PM, Burakov, Anatoly wrote: > On 02-Apr-18 6:35 AM, santosh wrote: >> >> On Sunday 01 April 2018 05:56 PM, Anatoly Burakov wrote: >>> We already use VA addresses for IOVA purposes everywhere if we're in >>> RTE_IOVA

Re: [dpdk-dev] [PATCH 2/4] eal: do not use physical addresses in IOVA as VA mode

2018-04-01 Thread santosh
On Sunday 01 April 2018 05:56 PM, Anatoly Burakov wrote: > We already use VA addresses for IOVA purposes everywhere if we're in > RTE_IOVA_VA mode: > 1) rte_malloc_virt2phy()/rte_malloc_virt2iova() always return VA addresses > 2) Because of 1), memzone's IOVA is set to VA address on reserve > 3

Re: [dpdk-dev] [PATCH] ethdev: replace bus specific struct with generic dev

2018-03-29 Thread santosh
t/null/rte_eth_null.c | 1 + > drivers/net/octeontx/octeontx_ethdev.c| 2 +- Resending, as mailman had issues sending to too many recipient. nits: patch apply failed on tip 20526313, applied manually. with that: Acked-by: Santosh Shukla [..]

Re: [dpdk-dev] [PATCH v2 13/41] eal: replace memseg with memseg lists

2018-03-24 Thread santosh
On Saturday 24 March 2018 04:38 PM, Burakov, Anatoly wrote: > On 24-Mar-18 6:01 AM, santosh wrote: >> Hi Anatoly, >> >> Thanks for good work!. >> Few observations: >> # Noticed performance regression for thunderx platform for l3fwd application, >> drops by

Re: [dpdk-dev] [PATCH v2 13/41] eal: replace memseg with memseg lists

2018-03-23 Thread santosh
Hi Anatoly, On Wednesday 07 March 2018 10:26 PM, Anatoly Burakov wrote: > Before, we were aggregating multiple pages into one memseg, so the > number of memsegs was small. Now, each page gets its own memseg, > so the list of memsegs is huge. To accommodate the new memseg list > size and to keep t

Re: [dpdk-dev] [PATCH v1 0/9] mempool: prepare to add bucket driver

2018-03-14 Thread santosh
Hi Andrew, On Saturday 10 March 2018 09:09 PM, Andrew Rybchenko wrote: [...] > RFCv1 -> RFCv2: > - add driver ops to calculate required memory size and populate > mempool objects, remove extra flags which were required before > to control it > - transition of octeontx and dpaa drive

Re: [dpdk-dev] [PATCH] net/octeontx: use the new offload APIs

2018-03-11 Thread santosh
On Friday 09 March 2018 12:37 AM, Pavan Nikhilesh wrote: > Use the new Rx/Tx offload APIs and remove the old style offloads. > > Signed-off-by: Pavan Nikhilesh > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v1 1/9] mempool: add op to calculate memory size to be allocated

2018-03-11 Thread santosh
Hi Andrew, On Saturday 10 March 2018 09:09 PM, Andrew Rybchenko wrote: > Size of memory chunk required to populate mempool objects depends > on how objects are stored in the memory. Different mempool drivers > may have different requirements and a new operation allows to > calculate memory size i

Re: [dpdk-dev] [RFC v2 03/17] mempool/octeontx: add callback to calculate memory size

2018-03-10 Thread santosh
Hi Andrew, On Saturday 10 March 2018 09:19 PM, Andrew Rybchenko wrote: > Hi Santosh, > > On 02/01/2018 04:40 PM, santosh wrote: >> On Thursday 01 February 2018 03:31 PM, santosh wrote: >>> Hi Andrew, >>> >>> >>> On Thursday 01 February 2018 11:

[dpdk-dev] [PATCH v1 2/2] net/octeontx: fix for uninitialized scalar var

2018-02-20 Thread Santosh Shukla
Fixes: f18b146c498d ("net/octeontx: create ethdev ports") Coverity issue: 195045 Cc: sta...@dpdk.org Signed-off-by: Santosh Shukla --- drivers/net/octeontx/octeontx_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/d

[dpdk-dev] [PATCH v1 1/2] net/octeontx: fix null pointer dereference

2018-02-20 Thread Santosh Shukla
Fixes: f18b146c498d ("net/octeontx: create ethdev ports") Coverity issue: 195040 Cc: sta...@dpdk.org Signed-off-by: Santosh Shukla --- drivers/net/octeontx/octeontx_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/d

Re: [dpdk-dev] [PATCH 08/10] event/octeontx: add option to use fpavf as chunk pool

2018-02-18 Thread santosh
Hi Pavan, On Saturday 17 February 2018 03:06 AM, Pavan Nikhilesh wrote: > Add compile-time configurable option to force TIMvf to use Octeontx > FPAvf pool manager as its chunk pool. > When FPAvf is used as pool manager the TIMvf automatically frees the > chunks to FPAvf through gpool-id. > > Sign

Re: [dpdk-dev] [PATCH v2] net/octeontx: register fpa as platform HW mempool

2018-02-04 Thread santosh
On Sunday 04 February 2018 09:03 PM, Pavan Nikhilesh wrote: > Register octeontx-fpavf as platform HW mempool when net/octeontx pmd is > used. > > Signed-off-by: Pavan Nikhilesh > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH 2/4] bus/dpaa: fix registering dpaa mempool ops

2018-02-04 Thread santosh
; + /* Register DPAA mempool ops only if any DPAA device has > + * been detected. > + */ > + if (!TAILQ_EMPTY(&rte_dpaa_bus.device_list)) > + rte_mbuf_set_platform_mempool_ops(DPAA_MEMPOOL_OPS_NAME); > change will fix octeontx regression introduced by eal mempool patch. Acked-by: Santosh Shukla

Re: [dpdk-dev] Fw: [PATCH FIX-OPTION-1] mbuf: fix the logic of user mempool ops API

2018-02-03 Thread santosh
Hi Hemant, On Sunday 04 February 2018 11:52 AM, Shukla, Santosh wrote: > The existing rte_eal_mbuf_default mempool ops can return the compile time > default ops name if the user has not provided command line inputs for > mempool ops name. It will break the logic of best mempool ops a

Re: [dpdk-dev] [RFC v2 03/17] mempool/octeontx: add callback to calculate memory size

2018-02-01 Thread santosh
On Thursday 01 February 2018 03:31 PM, santosh wrote: > Hi Andrew, > > > On Thursday 01 February 2018 11:48 AM, Jacob, Jerin wrote: >> The driver requires one and only one physically contiguous >> memory chunk for all objects. >> >> Signed-off-by: Andrew Ry

Re: [dpdk-dev] [RFC v2 01/17] mempool: fix phys contig check if populate default skipped

2018-02-01 Thread santosh
On Thursday 01 February 2018 03:44 PM, Olivier Matz wrote: > On Thu, Feb 01, 2018 at 01:00:12PM +0300, Andrew Rybchenko wrote: >> On 02/01/2018 12:30 PM, santosh wrote: >>> On Thursday 01 February 2018 02:48 PM, Andrew Rybchenko wrote: >>>> On 02/01/2018 12:09 PM, sa

Re: [dpdk-dev] [RFC v2 01/17] mempool: fix phys contig check if populate default skipped

2018-02-01 Thread santosh
On Thursday 01 February 2018 03:30 PM, Andrew Rybchenko wrote: > On 02/01/2018 12:30 PM, santosh wrote: >> On Thursday 01 February 2018 02:48 PM, Andrew Rybchenko wrote: >>> On 02/01/2018 12:09 PM, santosh wrote: >>>> On Thursday 01 February 2018 12:24 PM, Andrew R

[dpdk-dev] [RFC v2 03/17] mempool/octeontx: add callback to calculate memory size

2018-02-01 Thread santosh
Hi Andrew, On Thursday 01 February 2018 11:48 AM, Jacob, Jerin wrote: > The driver requires one and only one physically contiguous > memory chunk for all objects. > > Signed-off-by: Andrew Rybchenko > --- > drivers/mempool/octeontx/rte_mempool_octeontx.c | 25 > + > 1

Re: [dpdk-dev] [RFC v2 01/17] mempool: fix phys contig check if populate default skipped

2018-02-01 Thread santosh
On Thursday 01 February 2018 02:48 PM, Andrew Rybchenko wrote: > On 02/01/2018 12:09 PM, santosh wrote: >> On Thursday 01 February 2018 12:24 PM, Andrew Rybchenko wrote: >>> On 02/01/2018 08:05 AM, santosh wrote: >>>> On Wednesday 31 January 2018 10:15 PM, Olivier Ma

Re: [dpdk-dev] [RFC v2 01/17] mempool: fix phys contig check if populate default skipped

2018-02-01 Thread santosh
On Thursday 01 February 2018 12:24 PM, Andrew Rybchenko wrote: > On 02/01/2018 08:05 AM, santosh wrote: >> On Wednesday 31 January 2018 10:15 PM, Olivier Matz wrote: >>> On Tue, Jan 23, 2018 at 01:15:56PM +, Andrew Rybchenko wrote: >>>> There is no

Re: [dpdk-dev] [RFC v2 01/17] mempool: fix phys contig check if populate default skipped

2018-01-31 Thread santosh
;s strange that the mp->flags are > updated with capabilities only in rte_mempool_populate_default(). > I see that this behavior is removed later in the patchset since the > get_capa() is removed! > > However maybe this single patch could go in 18.02. > +Santosh +

Re: [dpdk-dev] [PATCH 03/18] octeontx: align dynamic log names with standard

2018-01-25 Thread santosh
On Thursday 25 January 2018 02:30 PM, Harry van Haaren wrote: > This commit aligns the names for dynamic logging with > the newly defined logging format. > > Signed-off-by: Harry van Haaren > > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v6 5/7] app/testpmd: set preferred mempool as default pktpool

2018-01-22 Thread santosh
eviewed-by: Olivier Matz > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v6 4/7] mbuf: pktmbuf pool create helper for specific mempool ops

2018-01-22 Thread santosh
On Monday 22 January 2018 07:21 PM, Hemant Agrawal wrote: > Introduce a new helper for pktmbuf pool, which will allow > the application to optionally specify the mempool ops name > as well. > > Signed-off-by: Hemant Agrawal > Acked-by: Olivier Matz > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v6 3/7] mbuf: add pool ops name selection API helpers

2018-01-22 Thread santosh
orm registered and compile time configured. > > Signed-off-by: Hemant Agrawal > Acked-by: Olivier Matz > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v6 2/7] mbuf: maintain user and compile time mempool ops name

2018-01-22 Thread santosh
gt; Acked-by: Olivier Matz > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v6 1/7] eal: prefix mbuf pool ops name with user defined

2018-01-22 Thread santosh
On Monday 22 January 2018 07:21 PM, Hemant Agrawal wrote: > This patch prefix the mbuf pool ops name with "user" to indicate > that it is user defined. > > Signed-off-by: Hemant Agrawal > Acked-by: Olivier Matz > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH] mempool/octeontx: fix natural alignment being optimized out

2018-01-18 Thread santosh
ixes: aecb8e093b52 ("event/octeontx: introduce specialized mbox message > copy") > Cc: sta...@dpdk.org > > Signed-off-by: Pavan Nikhilesh > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [RFC PATCH 2/6] mempool: implement clustered object allocation

2018-01-17 Thread santosh
  if (total_elt_sz == 0) >>>   return 0; >>>   +    if (flags & MEMPOOL_F_CAPA_ALLOCATE_IN_CLUSTERS) { >>> +    unsigned int align_shift = >>> +    rte_bsf32( >>> +    rte_align32pow2(total_elt_sz * >>> +    i

Re: [dpdk-dev] [PATCH] mempool/octeontx: use smp instead of io barrier

2018-01-07 Thread santosh
On Thursday 04 January 2018 05:09 PM, Pavan Nikhilesh wrote: > Use smp barrier instead of IO barrier when sending mbox request as the > write has to be reflected between cores not IO devices. > > Signed-off-by: Pavan Nikhilesh > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH 2/2] net: enable IOVA mode for PMDs

2018-01-05 Thread santosh
Hi Maxim, On Friday 05 January 2018 04:02 PM, Maxime Coquelin wrote: > Hi Jianfeng, > > On 10/11/2017 12:33 PM, Jianfeng Tan wrote: >> If we want to enable IOVA mode, introduced by >> commit 93878cf0255e ("eal: introduce helper API for IOVA mode"), >> we need PMDs (for PCI devices) to expose this

Re: [dpdk-dev] [PATCH 1/2] mempool: indicate the usages of multi memzones

2018-01-05 Thread santosh
On Tuesday 19 December 2017 04:32 PM, Olivier MATZ wrote: > On Tue, Dec 19, 2017 at 04:16:33PM +0530, Hemant Agrawal wrote: >> Hi Olivier, >> >> On 12/19/2017 3:54 PM, Olivier MATZ wrote: >>> Hi Hemant, >>> >>> On Wed, Dec 06, 2017 at 06:01:12PM +0530, Hemant Agrawal wrote: This is required f

Re: [dpdk-dev] [PATCH 4/5] event/octeontx: implement dynamic logging

2017-12-31 Thread santosh
On Tuesday 19 December 2017 05:55 PM, Pavan Nikhilesh wrote: > Signed-off-by: Pavan Nikhilesh > --- same comment for otx_ssovf_init_log Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH 3/5] mempool/octeontx: implement dynamic logging

2017-12-31 Thread santosh
On Tuesday 19 December 2017 05:55 PM, Pavan Nikhilesh wrote: > Signed-off-by: Pavan Nikhilesh > --- Same nits comment for otx_pool_init_log Acked-by: santosh shukla

Re: [dpdk-dev] [PATCH 2/5] net/octeontx: implement dynamic logging

2017-12-31 Thread santosh
On Tuesday 19 December 2017 05:55 PM, Pavan Nikhilesh wrote: > Signed-off-by: Pavan Nikhilesh > --- nits: s / otx_net_init_log / octeontx_net_init_log Rest LGTM, Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH 1/5] net/thunderx: implement dynamic logging

2017-12-31 Thread santosh
On Tuesday 19 December 2017 05:55 PM, Pavan Nikhilesh wrote: > Signed-off-by: Pavan Nikhilesh > --- LGTM. Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v2 2/2] event/octeontx: fix Rx adapter port id mapping

2017-12-18 Thread santosh
ort event Rx adapter") > > Signed-off-by: Pavan Nikhilesh > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v2 1/2] net/octeontx: add channel to port id mapping

2017-12-18 Thread santosh
ap > +++ b/drivers/net/octeontx/rte_pmd_octeontx_version.map > @@ -2,3 +2,9 @@ DPDK_17.11 { > > local: *; > }; > + > +DPDK_18.04 { > + global: > + > + octeontx_pchan_map; > +}; nits: better be rte_octeontx_pchan_map refer http://dpdk.org/browse/dpdk/tree/drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map#n4 Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH] net/octeontx: advertise supported mbuf pool ops

2017-12-18 Thread santosh
On Thursday 14 December 2017 02:01 PM, Pavan Nikhilesh wrote: > Advertise mempool/octeontx as the only supported mempool ops when the > application checks using `rte_eth_dev_pool_ops_supported`. > > Signed-off-by: Pavan Nikhilesh > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH 2/2] mempool/octeontx: clean up memory area registration

2017-12-17 Thread santosh
the dependency. Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH 1/2] mempool: notify mempool area after mempool alloc

2017-12-17 Thread santosh
On Friday 15 December 2017 09:30 PM, Pavan Nikhilesh wrote: > Mempool creation needs to be completed first before notifying mempool to > register the mempool area. > > Signed-off-by: Pavan Nikhilesh > --- LGTM. Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH] test/mempool_perf: improve default mempool ops selection

2017-12-12 Thread santosh
On Sunday 19 November 2017 10:25 AM, Jerin Jacob wrote: > Use of rte_eal_mbuf_default_mempool_ops() API will > allow to override pool handler through "--mbuf-pool-ops-name" > eal command line argument. > > Signed-off-by: Jerin Jacob > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH] test/mempool: improve default mempool ops selection

2017-12-12 Thread santosh
mempool_set_ops_byname(default_pool, > - RTE_MBUF_DEFAULT_MEMPOOL_OPS, NULL) < 0) { > + rte_eal_mbuf_default_mempool_ops(), NULL) < 0) { > printf("cannot set %s handler\n", > RTE_MBUF_DEFAULT_MEMPOOL_OPS); Pl. replace error printf _ops with _mbuf_default_mempool_ops. With that: Acked-by: Santosh Shukla Thanks.

Re: [dpdk-dev] [PATCH 02/14] drivers: change the deprecated memseg physaddr to iova

2017-12-07 Thread santosh
On Friday 08 December 2017 10:51 AM, Hemant Agrawal wrote: > DPAA and DPAA2 drivers were using memseg physaddr, which > has been deprecated. > > Fixes: 7ba49d39f14c ("mem: rename segment address from physical to IOVA") > Cc: Santosh Shukla > Cc: sta...@dpdk.org >

[dpdk-dev] [PATCH v5 2/3] doc: add mempool and octeontx mempool device

2017-11-06 Thread Santosh Shukla
This commit adds a section to the docs listing the mempool device PMDs available. It then adds the octeontx fpavf mempool PMD to the listed mempool devices. Cc: John McNamara Signed-off-by: Santosh Shukla --- v4 --> v5: * Replaced `Ref :` with `See :doc:` (John) * Renamed section f

[dpdk-dev] [PATCH v5 3/3] doc: use correct mempool ops handle name

2017-11-06 Thread Santosh Shukla
Fixes: f820b5896631 ("doc: add octeontx ethdev driver documentation") Signed-off-by: Santosh Shukla Acked-by: Jerin Jacob Acked-by: John McNamara --- doc/guides/nics/octeontx.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/nics/octeontx.rst b/doc/g

[dpdk-dev] [PATCH v5 1/3] doc: add platform guide

2017-11-06 Thread Santosh Shukla
/octeontx.rst. Cc: John McNamara Signed-off-by: Santosh Shukla --- v4 --> v5: * Replaced `Ref:` with `Sec :doc:` as per John review comment. * * Renamed Feature to Features (john). * * Replaced Section from `Platform Device Driver` to `Platform Specific guide` (john). * s/Intel Corporation / Cavium

[dpdk-dev] [PATCH v5 0/3] Doc misc

2017-11-06 Thread Santosh Shukla
; 4: * Replaced `Ref:` with `Sec :doc:` as per John review comment. * Renamed Feature to Features (john). * Replaced Section from `Platform Device Driver` to `Platform Specific guide` (john). Thanks. Discussion history; [1] http://dpdk.org/dev/patchwork/patch/29893/ Santosh Shukla (3): doc:

Re: [dpdk-dev] [PATCH] mempool: increase ABI version

2017-11-06 Thread santosh
Fixes: 6eac187bff30 ("mempool: add flags arg in xmem size and usage") > > Signed-off-by: Thomas Monjalon > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v4 02/15] mem: introduce IOVA type

2017-11-06 Thread santosh
On Monday 06 November 2017 02:07 PM, Thomas Monjalon wrote: > 06/11/2017 06:38, santosh: >> On Monday 06 November 2017 07:11 AM, Thomas Monjalon wrote: >>> The IO virtual addresses may be used instead of physical addresses. >>> As IOVA is more generic, it should be

Re: [dpdk-dev] [PATCH v4 15/15] doc: add IOVA aware API changes in release notes

2017-11-05 Thread santosh
; > The release notes describe the new available API with IOVA wording. > > Signed-off-by: Thomas Monjalon > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v4 09/15] mempool: rename address mapping function to IOVA

2017-11-05 Thread santosh
; Signed-off-by: Thomas Monjalon > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v4 08/15] mempool: rename addresses from physical to IOVA

2017-11-05 Thread santosh
ned-off-by: Thomas Monjalon > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v4 07/15] memzone: rename address from physical to IOVA

2017-11-05 Thread santosh
On Monday 06 November 2017 07:11 AM, Thomas Monjalon wrote: > The struct rte_memzone field .phys_addr is renamed to .iova. > The deprecated name is kept in an anonymous union to avoid breaking > the API. > > Signed-off-by: Thomas Monjalon > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v4 05/15] malloc: rename address mapping function to IOVA

2017-11-05 Thread santosh
On Monday 06 November 2017 07:11 AM, Thomas Monjalon wrote: > The function rte_malloc_virt2phy() is renamed to rte_malloc_virt2iova(). > The deprecated name is kept as an alias to avoid breaking the API. > > Signed-off-by: Thomas Monjalon > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v4 04/15] mem: rename address mapping function to IOVA

2017-11-05 Thread santosh
n) in the VA case. > > Note: the new function rte_mem_virt2iova() function matches the > behaviour implemented in rte_mem_virt2phy() by the commit > 680f6c12600f ("mem: honor IOVA mode in virt2phy") > > Signed-off-by: Thomas Monjalon > --- Acked-by: Santosh Shukla Thanks.

Re: [dpdk-dev] [PATCH v4 01/15] mem: hide physical address error in VA mode

2017-11-05 Thread santosh
On Monday 06 November 2017 07:11 AM, Thomas Monjalon wrote: > If the IOVA mode is not using physical addresses, > no need to log an error about physical address issue. > > Signed-off-by: Thomas Monjalon > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v4 02/15] mem: introduce IOVA type

2017-11-05 Thread santosh
ping, i.e. the same value. > + */ I guess - that description applicable for iova=va mode and for iova=pa mode - Need to do explicit virt2phy translation. I believe you mis-wrote - s/physical addressing mode/virtual addressing mode. With that: Acked-by: Santosh Shukla Thanks. > +typedef uint

Re: [dpdk-dev] [PATCH v3 4/6] eal/memory: rename memory API to iova types

2017-11-03 Thread santosh
On Friday 03 November 2017 04:41 PM, Thomas Monjalon wrote: > 20/10/2017 14:31, Santosh Shukla: >> Renamed memory translational api to _iova types. >> The following api renamed from: >> >> rte_mempool_populate_phys() >> rte_mempool_populate_phys_tab() >

Re: [dpdk-dev] [PATCH] eal: force IOVA PA mode if KNI module inserted

2017-11-01 Thread santosh
rruh Yigit > --- > Cc: Jianfeng Tan > Cc: Jerin Jacob > Cc: Santosh Shukla > Cc: Thomas Monjalon > > This patch superseded following one: > http://dpdk.org/dev/patchwork/patch/31071/ > --- > lib/librte_eal/linuxapp/eal/eal.c | 9 + > 1 file changed, 9 in

Re: [dpdk-dev] [PATCH] eal: disable IOVA mode detection by default

2017-11-01 Thread santosh
On Wednesday 01 November 2017 04:01 PM, Thomas Monjalon wrote: > 01/11/2017 02:07, Ferruh Yigit: >> Fix kernel crash with KNI because KNI requires physical addresses. >> >> A config option introduced to disable IOVA mode detection and to set it >> to physical address by default. Disabling config o

Re: [dpdk-dev] [PATCH] eal: disable IOVA mode detection by default

2017-10-31 Thread santosh
On Wednesday 01 November 2017 06:37 AM, Ferruh Yigit wrote: > Fix kernel crash with KNI because KNI requires physical addresses. > > A config option introduced to disable IOVA mode detection and to set it > to physical address by default. Disabling config option will enable IOVA > mode detection.

Re: [dpdk-dev] [PATCH] net/octeontx: fix build for gcc < 4.6

2017-10-25 Thread santosh
Fixes: 9e747589bd4c ("net/octeontx: add packet transmit burst function") > > Signed-off-by: Ferruh Yigit > --- Acked-by: Santosh Shukla Thanks.

Re: [dpdk-dev] [PATCH v2] pci: fix check uio bind

2017-10-24 Thread santosh
t; not-blacklisted devices depending on the bus scan mode. > > Fixes: 815c7deaed2d ("pci: get IOMMU class on Linux") > > Signed-off-by: Jianfeng Tan > --- > v2: > - Accept two suggestions from Gaetan. v2, looks good to me. Acked-by: Santosh Shukla Thanks.

Re: [dpdk-dev] [PATCH v3 1/6] eal: rename phys addr to iova addr

2017-10-23 Thread santosh
On Tuesday 24 October 2017 02:02 AM, Thomas Monjalon wrote: > 20/10/2017 14:31, Santosh Shukla: >> Renamed data type from phys_addr_t to iova_addr_t. >> >> Signed-off-by: Santosh Shukla >> Reviewed-by: Anatoly Burakov > Suggested title: > mem: rename p

Re: [dpdk-dev] [PATCH v3 2/6] eal/memory: rename buf physaddr to buf iovaaddr

2017-10-23 Thread santosh
On Tuesday 24 October 2017 02:04 AM, Thomas Monjalon wrote: > 20/10/2017 14:31, Santosh Shukla: >> Rename buf_physaddr to buf_iovaaddr >> >> Signed-off-by: Santosh Shukla >> Reviewed-by: Anatoly Burakov > Suggested title: > mbuf: rename physical address

Re: [dpdk-dev] [PATCH v3 0/6] make dpdk iova aware

2017-10-23 Thread santosh
Hi Thomas, On Monday 23 October 2017 08:28 PM, Thomas Monjalon wrote: > 20/10/2017 14:31, Santosh Shukla: >> v3: >> Include v2 review comment and rebased on >> top of upstream tip commit:6b9ed026a8704 >> >> >> v2: >> Include build fixes reported

Re: [dpdk-dev] [PATCH v3 5/6] doc: remove dpdk iova aware notice

2017-10-23 Thread santosh
Hi Thomas, On Tuesday 24 October 2017 01:59 AM, Thomas Monjalon wrote: > 20/10/2017 14:31, Santosh Shukla: >> Removed dpdk iova aware ABI deprecation notice, >> and updated ABI change details in release_17.11.rst. >> >> Signed-off-by: Santosh Shukla >> Acked-b

[dpdk-dev] [PATCH v1] mempool/octeontx: remove dead code from gpool2handle

2017-10-20 Thread Santosh Shukla
Coverity Issue: 195000 Fixes: 02fd6c744350 ("mempool/octeontx: support allocation") Signed-off-by: Santosh Shukla --- drivers/mempool/octeontx/octeontx_fpavf.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/mempool/octeontx/octeontx_fpavf.c b/drivers/mempoo

[dpdk-dev] [PATCH v4 3/3] doc: use correct mempool ops handle name

2017-10-20 Thread Santosh Shukla
Fixes: f820b5896631 ("doc: add octeontx ethdev driver documentation") Signed-off-by: Santosh Shukla --- doc/guides/nics/octeontx.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/nics/octeontx.rst b/doc/guides/nics/octeontx.rst index 2527aa3e3..d40d1f

[dpdk-dev] [PATCH v4 0/3] Octeontx doc misc

2017-10-20 Thread Santosh Shukla
Patch 1: Introduce platform/ entry in guide. That has information about platform drivers. ( As per discussion[1]) Patch 2: Introduce mempool/ entry in guide. (Refer discussion[1]) Patch 3: Misc Fix for nic/octeontx.rst Thanks. [1] http://dpdk.org/dev/patchwork/patch/29893/ Santosh Shukla (3

[dpdk-dev] [PATCH v4 2/3] doc: add mempool and octeontx mempool device

2017-10-20 Thread Santosh Shukla
This commit adds a section to the docs listing the mempool device PMDs available. It then adds the octeontx fpavf mempool PMD to the listed mempool devices. Cc: John McNamara Signed-off-by: Santosh Shukla --- v3 --> v4: - Moved Prerequisite section from mempool/octeontx.rst to platf

[dpdk-dev] [PATCH v4 1/3] doc: add platform device

2017-10-20 Thread Santosh Shukla
/octeontx.rst. Cc: John McNamara Signed-off-by: Santosh Shukla --- v3 --> v4: - Added doc/guide/platform/ as per v3 discussion. - Moved common content of "Prerequisite" section from eventdev/octeontx.rst to platform/octeontx.rst. doc/guides/eventdevs/octeontx.rst | 28 +-

[dpdk-dev] [PATCH v3 6/6] eal/common/rte_malloc: use pointer diff in virt2iova

2017-10-20 Thread Santosh Shukla
Use RTE_PTR_DIFF macro in rte_mem_virt2iova api. Suggested-by: Anatoly Burakov Signed-off-by: Santosh Shukla --- lib/librte_eal/common/rte_malloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/rte_malloc.c b/lib/librte_eal/common/rte_malloc.c index

[dpdk-dev] [PATCH v3 5/6] doc: remove dpdk iova aware notice

2017-10-20 Thread Santosh Shukla
Removed dpdk iova aware ABI deprecation notice, and updated ABI change details in release_17.11.rst. Signed-off-by: Santosh Shukla Acked-by: John McNamara --- doc/guides/rel_notes/deprecation.rst | 7 --- doc/guides/rel_notes/release_17_11.rst | 28 2 files

[dpdk-dev] [PATCH v3 4/6] eal/memory: rename memory API to iova types

2017-10-20 Thread Santosh Shukla
: Santosh Shukla --- app/proc_info/main.c | 2 +- app/test-crypto-perf/cperf_test_vector_parsing.c | 4 ++-- app/test-crypto-perf/cperf_test_vectors.c| 6 +++--- app/test-pmd/cmdline.c | 2 +- doc/guides/rel_notes/release_17_11.rst

[dpdk-dev] [PATCH v3 3/6] eal/memory: rename memseg member phys to iova addr

2017-10-20 Thread Santosh Shukla
Renaming rte_memseg {.phys_addr} to {.iova_addr} Signed-off-by: Santosh Shukla Reviewed-by: Anatoly Burakov --- lib/librte_eal/bsdapp/eal/eal_memory.c | 4 ++-- lib/librte_eal/common/eal_common_memory.c | 2 +- lib/librte_eal/common/include/rte_memory.h | 4 ++-- lib/librte_eal/common

  1   2   3   4   5   6   7   8   >