I'll try updating it, thank you.
Hi, Thomas
I tested(See below) this patch locally and it can suppress this error(github
build: failed).
Is the difference in CI results from patchwork due to different versions of
abidiff?
My abidiff version:
[root@localhost dpdk.chc1]# abidiff --version
abidiff: 1.6.0
There is currently no versi
Hi Konstantin, thank you very much for your question!
I have modified the __rte_ring_rts_v2_update_tail function(See at the
bottom)and it works properly when
using your test command in my local environment(KVM). The local environment
parameters are as follows:
Architecture:x86_64
C
Hi,Thomas
This patch adds a field to the ABI structure.I have added the suppress_type
field in the file libabigail.abignore, but "ci/github-robot: Build" still
reported
an error, could you please advise on how to fill in the suppress_type field?
to increase concurrency.
Add some corresponding test cases.
Signed-off-by: Huichao Cai
---
app/test/meson.build | 1 +
app/test/test_ring.c | 26 +++
app/test/test_ring_rts_v2_stress.c | 32
app/test/test_ring_stress.c| 3 +
app/test
to increase concurrency.
Add some corresponding test cases.
Signed-off-by: Huichao Cai
---
app/test/meson.build | 1 +
app/test/test_ring.c | 26 +++
app/test/test_ring_rts_v2_stress.c | 32
app/test/test_ring_stress.c| 3 +
app/test
to increase concurrency.
Add some corresponding test cases.
Signed-off-by: Huichao Cai
---
app/test/meson.build | 1 +
app/test/test_ring.c | 26 +++
app/test/test_ring_rts_v2_stress.c | 32
app/test/test_ring_stress.c| 3 +
app/test
Hi David, does "has_data_member_inserted_between =
{offset_of(total_sched_fail), offset_of(xstat_off)}" need to be on the same
line?
In the function __rte_graph_mcore_dispatch_sched_node_enqueue,
use a slower loop to search for the graph, modify the search logic
to record the result of the first search, and use this record for
subsequent searches to improve search speed.
Signed-off-by: Huichao Cai
---
devtools
In the function __rte_graph_mcore_dispatch_sched_node_enqueue,
use a slower loop to search for the graph, modify the search logic
to record the result of the first search, and use this record for
subsequent searches to improve search speed.
Signed-off-by: Huichao Cai
---
doc/guides/rel_notes
The members "dispatch" and "xstat_off" of the structure "rte_node"
can be min cache aligned to make room for future expansion and to
make sure have better performance. Add corresponding comments.
Signed-off-by: Huichao Cai
---
doc/guides/rel_notes/releas
Hi, Jerin. Like this?
diff --git a/lib/graph/rte_graph_worker_common.h
b/lib/graph/rte_graph_worker_common.h
index a518af2b2a..f9ff7dd8c9 100644
--- a/lib/graph/rte_graph_worker_common.h
+++ b/lib/graph/rte_graph_worker_common.h
@@ -104,15 +104,19 @@ struct __rte_cache_aligned rte_node {
release_24_11.rst.
Signed-off-by: Huichao Cai
---
doc/guides/rel_notes/release_24_11.rst | 3 +++
lib/graph/rte_graph_worker_common.h| 7 ++-
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/doc/guides/rel_notes/release_24_11.rst
b/doc/guides/rel_notes/release_24_11.rst
index
"rte_node" structure,
update file release_24_11.rst.
Signed-off-by: Huichao Cai
---
doc/guides/rel_notes/release_24_11.rst | 1 +
lib/graph/rte_graph_model_mcore_dispatch.c | 11 +++
lib/graph/rte_graph_worker_common.h| 1 +
3 files changed, 9 insertions(+), 4 dele
"rte_node" structure,
update file release_24_11.rst.
Signed-off-by: Huichao Cai
---
doc/guides/rel_notes/release_24_11.rst | 1 +
lib/graph/rte_graph_model_mcore_dispatch.c | 11 +++
lib/graph/rte_graph_worker_common.h| 1 +
3 files changed, 9 insertions(+), 4 dele
> [main] [dpdk.org] $ git diff> diff --git
> a/lib/graph/rte_graph_worker_common.h b/lib/graph/rte_graph_worker_common.h>
> index a518af2b2a..ec9a82186d 100644> ---
> a/lib/graph/rte_graph_worker_common.h> +++
> b/lib/graph/rte_graph_worker_common.h> @@ -104,6 +104,7 @@ struct
> __rte_cache_al
> [main] [dpdk.org] $ git diff
> diff --git a/lib/graph/rte_graph_worker_common.h
> b/lib/graph/rte_graph_worker_common.h
> index a518af2b2a..ec9a82186d 100644
> --- a/lib/graph/rte_graph_worker_common.h
> +++ b/lib/graph/rte_graph_worker_common.h
> @@ -104,6 +104,7 @@ struct __rte_cache_aligned r
date file release_24_11.rst.
Signed-off-by: Huichao Cai
---
doc/guides/rel_notes/release_24_11.rst | 3 +++
lib/graph/rte_graph_worker_common.h| 5 -
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/doc/guides/rel_notes/release_24_11.rst
b/doc/guides/rel_notes/release_24_11
>OK. @Huichao Cai Please send two patches (a) new proposal and (b) your
>improvement as series.
>Update ABI Changes section in doc/guides/rel_notes/release_24_11.rst Ok.I
>will send these two patches soon.
By the way, I don't know where to consult about this issue at the moment.
Please forgive me for discussing this issue here. Can we set up a chat box on
this
page instead of having to comment through email or git send email? Many email
clients
cannot set the In Reply To header or do not currently
Do these newly added functions need to protect the linked list with spin lock
graph_stpinlock_lock?
From: Huichao cai
In the function __rte_graph_mcore_dispatch_sched_node_enqueue,
use a slower loop to search for the graph, modify the search logic
to record the result of the first search, and use this record for
subsequent searches to improve search speed.
Signed-off-by: Huichao cai
---
lib
> Is n't breaking the ABI?
So can't we modify the ABI, or is there any special operation required to
modify the ABI?
In the function __rte_graph_ccore_ispatch_stched_node_dequeue,
use a slower loop to search for the graph, modify the search logic
to record the result of the first search, and use this record for
subsequent searches to improve search speed.
Signed-off-by: Huichao cai
---
lib/graph
There is one more place in the node_clone function that needs to be modified:
if (clone_name(reg->name, node->name, name))
//goto free;
goto free_xstat;
From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path:
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id EB02345C14;
Wed, 30 Oct 2024 13:13:05 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpd
There is one more place in the node_clone function that needs to be modified:
if (clone_name(reg->name, node->name, name))
//goto free;
goto free_xstat;
从 Windows 版邮件发送
>We can fix this node id issue also. Something similar to this has been fixed
>for graph id
>Recently. We can do the same thing for node id as well.
>https://patches.dpdk.org/project/dpdk/patch/20240618092324.54166-2-rja...@redhat.com/
So will you be able to complete this change in the near fu
There is a problem with deleting static nodes: the node ID is recorded using
the global variable node_id,
which is continuously increasing. If an intermediate node is deleted, the node
ID will appear empty, which
can introduce some problems, such as how to choose the node ID for cloning
later
At present rte_graph_destroy will only clean up the struct rte_node and struct
graph_node,
not the struct node, rte_node_clone creates the struct node, inserts the global
node_list linked list,
there is no function to clean up the node_list linked list, if you want to
clean up the node
create
The function node_dump add some printing of node information.
Signed-off-by: Huichao cai
---
lib/graph/graph_debug.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/lib/graph/graph_debug.c b/lib/graph/graph_debug.c
index 9def306..37088ce 100644
--- a/lib/graph
Start dpdk-test, execute the graph_autotest test command for
the first time, the result is successful, and then test again,
the result is always failing, modify this problem to make this
test command idempotent.
Signed-off-by: Huichao cai
---
app/test/test_graph.c | 21 -
1
some test data for this API.
Signed-off-by: Huichao Cai
---
app/test/test_ipfrag.c | 9 +-
lib/ip_frag/rte_ip_frag.h| 34 +++
lib/ip_frag/rte_ipv4_fragmentation.c | 174 +++
lib/ip_frag/version.map | 1 +
4 files
At 2022-07-25 23:42:06, "Stephen Hemminger" wrote:
>On Sun, 24 Jul 2022 16:10:03 +0800
>Huichao Cai wrote:
>
>> +
>> +/*
>> + * Formal parameter checking.
>> + */
>> +if (unlikely(pkt_in == NULL) || unlikely(pkts
some test data for this API.
Signed-off-by: Huichao Cai
---
app/test/test_ipfrag.c | 9 +-
lib/ip_frag/rte_ip_frag.h| 34 +++
lib/ip_frag/rte_ipv4_fragmentation.c | 175 +++
lib/ip_frag/version.map | 1 +
4 files
some test data for this API.
Signed-off-by: Huichao Cai
---
app/test/test_ipfrag.c | 9 +-
lib/ip_frag/rte_ip_frag.h| 34 +++
lib/ip_frag/rte_ipv4_fragmentation.c | 174 +++
lib/ip_frag/version.map | 1 +
4 files
At 2022-07-22 23:52:28, "Morten Brørup" wrote:
>> From: Stephen Hemminger [mailto:step...@networkplumber.org]
>> Sent: Friday, 22 July 2022 16.49
>>
>> On Fri, 22 Jul 2022 21:01:50 +0800
>> Huichao Cai wrote:
>>
>> >
this API.
Signed-off-by: Huichao Cai
---
app/test/test_ipfrag.c | 8 +-
lib/ip_frag/rte_ip_frag.h| 29 +
lib/ip_frag/rte_ipv4_fragmentation.c | 208 +++
lib/ip_frag/version.map | 1 +
4 files changed, 245 insertions
this API.
Signed-off-by: Huichao Cai
---
app/test/test_ipfrag.c | 8 +-
lib/ip_frag/rte_ip_frag.h| 27 +
lib/ip_frag/rte_ipv4_fragmentation.c | 208 +++
lib/ip_frag/version.map | 1 +
4 files changed, 243 insertions
_rte_experimental when declaring a function?
Huichao,Cai
To resolve the compilation warning,replace the rte_memcpy with memcpy.
Modify in file test_ipfrag.c and rte_ipv4_fragmentation.c.
Signed-off-by: Huichao Cai
---
app/test/test_ipfrag.c | 13 ++---
lib/ip_frag/rte_ipv4_fragmentation.c | 7 +++
2 files changed, 9
ixed), different compilers, and
>different CPU's.
>There might be surprising results.
So I hope this can go on and provide a more professional rte_memcpy
manual.Thanks!
Huichao,Cai
:
../app/test/test_ipfrag.c:57:17: note: at offset [5, 40] into object‘data’ of
size 40
4.Under what circumstances can we use rte_memcpy?
Huichao,Cai
this API.
Signed-off-by: Huichao Cai
---
app/test/test_ipfrag.c | 8 +-
lib/ip_frag/rte_ip_frag.h| 26 ++
lib/ip_frag/rte_ipv4_fragmentation.c | 165 +++
lib/ip_frag/version.map | 1 +
4 files changed, 199 insertions
this API.
Signed-off-by: Huichao Cai
---
app/test/test_ipfrag.c | 8 +-
lib/ip_frag/rte_ip_frag.h| 26 ++
lib/ip_frag/rte_ipv4_fragmentation.c | 165 +++
lib/ip_frag/version.map | 1 +
4 files changed, 199 insertions
I've seen some applications that have to rewrite fragment
functions themselves in order to use MBUF_FAST_FREE
features, such as iQiYi's DPVS.
so I want to add a choice for the application, do you
think it
is necessary（like rte_ipv4_fragment_clone_packet）?
Huichao,Cai
existing fragment logic(attach mbuf,
so it is fast,we can call it fast fragment mode) and add the fragment
logic in the non-attach mbuf mode(slow fragment mode).Add some test
data for this modification.
Signed-off-by: Huichao Cai
---
app/test/test_ipfrag.c | 14 +++--
lib/ip_frag
Hi Konstantin,
This patch has been around for a long time, so what's next?
Huichao,Cai
At 2022-04-15 16:29:10, "Ananyev, Konstantin"
wrote:
>> According to RFC791,the options may appear or not in datagrams.
>> They must be implemented by all IP modules (host and gatewa
Hi Konstantin,
This patch has been around for a long time, so what's next?
Huichao,Cai
At 2022-04-15 16:29:10, "Ananyev, Konstantin"
wrote:
>> According to RFC791,the options may appear or not in datagrams.
>> They must be implemented by all IP modules (host and gatewa
for the IPv4 header optional
field fragmenting.
Signed-off-by: Huichao Cai
---
app/test/test_ipfrag.c | 219 ---
lib/ip_frag/rte_ipv4_fragmentation.c | 70 ++-
lib/net/rte_ip.h | 6 +
3 files changed, 272 insertions
>No sorry, it cannot be applied as-is.
>
>Some IP constants should be defined in lib/net/rte_ip.h
>and should be named RTE_IPV4_HDR_OPT_* for consistency.
Ok,I will modify it and resubmit the patch.Thanks.
Hi everyone,
I have resubmitted the patch.Thanks.
https://patchwork.dpdk.org/project/dpdk/patch/1649649325-1942-1-git-send-email-chcch...@163.com/
Huichao,Cai
for the IPv4 header optional
field fragmenting.
Signed-off-by: Huichao Cai
---
app/test/test_ipfrag.c | 219 ---
lib/ip_frag/rte_ip_frag.h| 6 +
lib/ip_frag/rte_ipv4_fragmentation.c | 70 ++-
3 files changed, 272 insertions
Hi Konstantin,
This patch has a test case failure:ci/iol-broadcom-Functional.
Failed Tests:
- mtu_update
- scatter
The same goes for many other patches,Do I need to deal with it, how to deal
with it?
Huichao,Cai
for the IPv4 header optional
field fragmenting.
Signed-off-by: Huichao Cai
---
app/test/test_ipfrag.c | 219 ---
lib/ip_frag/rte_ip_frag.h| 6 +
lib/ip_frag/rte_ipv4_fragmentation.c | 70 ++-
3 files changed, 272 insertions
need to stitch all the data together manually, but it is not
as freely organized as the '#if' part of the code, and it was intended that as
an alternative, I will remove the code of the '#else' part and resend the patch.
Huichao Cai
for the IPv4 header optional
field fragmenting.
Signed-off-by: Huichao Cai
---
app/test/test_ipfrag.c | 319 ---
lib/ip_frag/rte_ip_frag.h| 6 +
lib/ip_frag/rte_ipv4_fragmentation.c | 70 +++-
3 files changed, 372 insertions(+), 23
t look as
brief as before.I would like to hear from you.
Some minor issues：
1. There are some RTE_ prefixes in the rte_ipv4_fragmentation.c.Do I need to
move to a public header file?
/* Fragment Offset */
#define RTE_IPV4_HDR_DF_SHIFT 14 #define RTE_IPV4_HDR_MF_SHIFT 13 #define
RTE_IPV4_HDR_FO_SHIFT 3
2. Some comments are in the following format：/**< xxx */,What does this
symbol(**<) mean?
Huichao,Cai
for the IPv4 header optional
field fragmenting.
Signed-off-by: Huichao Cai
---
app/test/test_ipfrag.c | 263 ---
lib/ip_frag/rte_ipv4_fragmentation.c | 77 +-
2 files changed, 318 insertions(+), 22 deletions(-)
diff --git a/app/test
Hi Konstantin,
>Who will define this macro and when?
>In general we trying to avoid conditional compilations within DPDK.
>Can we always use one way or another?
>As you are doing a copy anyway, probably no harm just
>completely remove RTE_IPOPT_KEEP_IP_HLEN and related behaviour
>and copy only op
for the IPv4 header optional
field fragmenting.
Signed-off-by: Huichao Cai
---
app/test/test_ipfrag.c | 292 ---
lib/ip_frag/rte_ipv4_fragmentation.c | 85 +-
2 files changed, 355 insertions(+), 22 deletions(-)
diff --git a/app/test
>AFAIK, we can't copy-paste code from Linux kernel.
>As you noted it is under GPL, while DPDK is under BSD-3 license.
Well, I'll rewrite the code.
>Library routine has no idea would original IP packet will be used later or not.
>In your particular case it might be not needed, but there might be
A small problem.Why is the content of the email just sent to you not visible at
Patchwork (this patch).
ag’，so the first fragment have a copy of all options present
in original packet.
Huichao Cai
Hi everyone,
This patch hasn't changed status for a long time, I want to know what the
current situation of this patch is?
Huichao Cai
Perhaps performance is more important.This code comes from the linux
kernel(5.10.9 and so on). :)
It is more performance-focused based on comments. :)
If options with copied flag unset are not copied, then IPv4 headers in the
fragments (despite 1st fragment) will be shorter. This leaves more byte space
for the payload and in effect fragmentation might produce less fragments.
--Do I need to modify it this way?
der and reassembling the data,which has some performance implications.
Huichao Cai
for the IPv4 header optional
field fragmenting.
Signed-off-by: Huichao Cai
---
app/test/test_ipfrag.c | 269 ---
lib/ip_frag/rte_ipv4_fragmentation.c | 52 ++-
2 files changed, 301 insertions(+), 20 deletions(-)
diff --git a/app/test
Add some test data for the IPv4 header optional field fragmenting.
Signed-off-by: Huichao Cai
---
Depends-on: patch-104642 (ip_frag: add fragmenting IPv4 header optional field)
app/test/test_ipfrag.c | 269 +
1 file changed, 250 insertions
: Huichao Cai
---
lib/ip_frag/rte_ipv4_fragmentation.c | 52 +++-
1 file changed, 51 insertions(+), 1 deletion(-)
diff --git a/lib/ip_frag/rte_ipv4_fragmentation.c
b/lib/ip_frag/rte_ipv4_fragmentation.c
index 2e7739d..bcafa29 100644
--- a/lib/ip_frag
>You seem ok with this title, I'll go with it.
-Thank you!
Hi Marchand
I think it should be a matter of message text format, maybe I should send a
link in text form, as follows：
https://patchwork.dpdk.org/project/dpdk/patch/1635148553-50086-1-git-send-email-chcch...@163.com/
Thank you!
Huichao Cai
it tests.
>test/ipfrag: check fragment offsets
--Thank you for reminding me, do I need to send another patch to modify the
title?
Huichao Cai
ix the buf of fragmenting IPv4 fragment - Patchwork (dpdk.org)
Huichao Cai
Add the test content of the fragment_offset(offset and MF)
to the test_ip_frag function. Add test data for a fragment
that is not the last fragment.
Signed-off-by: huichao cai
---
app/test/test_ipfrag.c | 95 +-
1 file changed, 79 insertions
sta...@dpdk.org
Signed-off-by: huichao cai
---
lib/ip_frag/rte_ipv4_fragmentation.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/lib/ip_frag/rte_ipv4_fragmentation.c
b/lib/ip_frag/rte_ipv4_fragmentation.c
index fead5a9..2e7739d 100644
--- a/lib/ip_frag/rte_ipv4_fra
provided in the original IPv4 packet.
Fixes: 4c38e5532a07 ("ip_frag: refactor IPv4 fragmentation into a proper
library")
Cc: sta...@dpdk.org
Signed-off-by: huichao cai
---
v2:
* Reword commit message.
lib/ip_frag/rte_ipv4_fragmentation.c | 9 ++---
1 file changed, 6 insert
From: huichao cai
According to RFC791,the fragment offset value should be
calculated based on the long datagram,the more fragments flag
for the last fragment carries the same value as the long datagram.
Signed-off-by: huichao cai
---
lib/ip_frag/rte_ipv4_fragmentation.c | 9 ++---
1 file
80 matches
Mail list logo
