RE: [PATCH] bus/vmbus: remove unnecessary packed attribute

2024-10-21 Thread Wei Hu
> -Original Message- > From: Stephen Hemminger > Sent: Tuesday, October 22, 2024 10:37 AM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Long Li > ; Wei Hu > Subject: [PATCH] bus/vmbus: remove unnecessary packed attribute > > The VMBus ring structure was mar

RE: [PATCH] net/netvsc: use rte_eth_dev_set_mtu to set VF MTU

2024-07-18 Thread Wei Hu
> Signed-off-by: Stephen Hemminger > > Fixes: 45c83603087e ("net/netvsc: support MTU set") > Cc: sta...@dpdk.org > Signed-off-by: Long Li Reviewed-by: Wei Hu > --- > drivers/net/netvsc/hn_vf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > &

[PATCH 1/1] maintainers: update for vmbus/mana/netvsc drivers

2024-06-27 Thread Wei Hu
Add myself as maintainer for vmbus, mana and netvsc. Signed-off-by: Wei Hu --- MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c9adff9846..58947b57ce 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -624,6 +624,7 @@ F: app/test/test_vdev.c

[PATCH v3 1/1] net/mana: add vlan tagging support

2024-03-13 Thread Wei Hu
For tx path, use LONG_PACKET_FORMAT if vlan tag is present. For rx, extract vlan id from oob, put into mbuf and set the vlan flags in mbuf. Signed-off-by: Wei Hu --- v3: - Adjust the pkt_idx position in the code so it will be executed even when adding vlan header fails. v2: - Use existing vlan

[PATCH v2 1/1] net/mana: add vlan tagging support

2024-03-12 Thread Wei Hu
For tx path, use LONG_PACKET_FORMAT if vlan tag is present. For rx, extract vlan id from oob, put into mbuf and set the vlan flags in mbuf. Signed-off-by: Wei Hu --- v2: - Use existing vlan tag processing macros. - Add vlan header back if vlan_strip flag is not set on the receiving path

RE: [PATCH 1/1] net/mana: add vlan tagging support

2024-02-19 Thread Wei Hu
> -Original Message- > From: Long Li > Sent: Saturday, February 10, 2024 2:48 AM > To: Wei Hu ; ferruh.yi...@amd.com; > andrew.rybche...@oktetlabs.ru; Thomas Monjalon > ; Alan Elder > Cc: dev@dpdk.org > Subject: RE: [PATCH 1/1] net/mana: add vlan tagging suppo

RE: [PATCH 1/1] net/mana: add vlan tagging support

2024-02-19 Thread Wei Hu
> -Original Message- > From: Ferruh Yigit > Sent: Saturday, February 10, 2024 12:06 AM > To: Wei Hu ; andrew.rybche...@oktetlabs.ru; Thomas > Monjalon ; Long Li > Cc: dev@dpdk.org > Subject: Re: [PATCH 1/1] net/mana: add vlan tagging support > > On 2/9

[PATCH 1/1] net/mana: add vlan tagging support

2024-02-09 Thread Wei Hu
For tx path, use LONG_PACKET_FORMAT if vlan tag is present. For rx, extract vlan id from oob, put into mbuf and set the vlan flags in mbuf. Also add myself to the maintainers list for vmbus, mana and netvsc. Signed-off-by: Wei Hu --- MAINTAINERS | 3 +++ drivers/net/mana/mana.h

[PATCH 2/2] net/mana: add 32 bit short doorbell

2023-09-21 Thread Wei Hu
would greatly suffer and it is not recommended. Cc: sta...@dpdk.org Signed-off-by: Wei Hu --- drivers/net/mana/gdma.c | 92 + drivers/net/mana/mana.h | 26 drivers/net/mana/rx.c | 45 drivers/net/mana/tx.c | 25

[PATCH 1/2] net/mana: enable 32 bit build for mana driver

2023-09-21 Thread Wei Hu
-off-by: Wei Hu --- drivers/net/mana/mana.c | 2 +- drivers/net/mana/meson.build | 4 ++-- drivers/net/mana/mr.c| 18 +- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/net/mana/mana.c b/drivers/net/mana/mana.c index 7630118d4f..896b53ed35

[PATCH 0/2] net/mana: 32 bit support

2023-09-21 Thread Wei Hu
not supported - add a couple missing ifdefs - fix the short doorbell threshold counting in wqes Need to backport these to 22.11.x Cc: sta...@dpdk.org Wei Hu (2): net/mana: enable 32 bit build for mana driver net/mana: add 32 bit short doorbell drivers/net/mana/gdma.c | 92

RE: [PATCH 1/1] net/mana: add 32 bit short doorbell

2023-09-20 Thread Wei Hu
> -Original Message- > From: Long Li > Sent: Wednesday, September 20, 2023 3:24 AM > To: Wei Hu ; dev@dpdk.org > Cc: sta...@dpdk.org; Ferruh Yigit ; Luca Boccassi > ; Kevin Traynor > Subject: RE: [PATCH 1/1] net/mana: add 32 bit short doorbell > >

RE: [PATCH 1/1] net/mana: add 32 bit short doorbell

2023-09-19 Thread Wei Hu
> -Original Message- > From: Ferruh Yigit > > > > 32bit applications cannot use 64bit doorbells. 64bit applications can > > use 32bit doorbells, however the performance would suffer and it definitely > not recommended. > > > > OK, can you please add this detail to the commit log? > Wil

RE: [PATCH v2 1/1] net/mana: enable 32 bit build for mana driver

2023-09-19 Thread Wei Hu
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, September 19, 2023 7:05 PM > To: Wei Hu ; dev@dpdk.org; Long Li > > Cc: sta...@dpdk.org; Kevin Traynor ; Luca Boccassi > > Subject: Re: [PATCH v2 1/1] net/mana: enable 32 bit build for mana driver >

RE: [PATCH 1/1] net/mana: add 32 bit short doorbell

2023-09-18 Thread Wei Hu
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, September 19, 2023 2:03 AM > To: Wei Hu ; dev@dpdk.org; Long Li > > Cc: sta...@dpdk.org; Kevin Traynor ; Luca Boccassi > > Subject: Re: [PATCH 1/1] net/mana: add 32 bit short doorbell > > On

RE: [PATCH v2 1/1] net/mana: enable 32 bit build for mana driver

2023-09-18 Thread Wei Hu
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, September 19, 2023 1:41 AM > To: Wei Hu ; dev@dpdk.org; Long Li > > Cc: sta...@dpdk.org; Kevin Traynor ; Luca Boccassi > > Subject: Re: [PATCH v2 1/1] net/mana: enable 32 bit build for mana driver >

RE: [PATCH 1/1] net/mana: add 32 bit short doorbell

2023-09-18 Thread Wei Hu
> -Original Message- > From: Long Li > Sent: Tuesday, September 19, 2023 4:02 AM > To: Wei Hu ; dev@dpdk.org > Cc: sta...@dpdk.org; Ferruh Yigit ; Luca Boccassi > ; Kevin Traynor > Subject: RE: [PATCH 1/1] net/mana: add 32 bit short doorbell > > > Subject

RE: [PATCH 1/1] net/mana: add 32 bit short doorbell

2023-09-13 Thread Wei Hu
> -Original Message- > From: Long Li > Sent: Thursday, September 14, 2023 5:11 AM > To: Wei Hu ; dev@dpdk.org; Ferruh Yigit > ; Andrew Rybchenko > > Cc: sta...@dpdk.org > Subject: RE: [PATCH 1/1] net/mana: add 32 bit short doorbell > > > + > > +/

[PATCH v2 1/1] net/mana: enable 32 bit build for mana driver

2023-09-13 Thread Wei Hu
Enable 32 bit build on x86 Linux. Fixed build warnings and errors when building in 32 bit. Cc: sta...@dpdk.org Signed-off-by: Wei Hu --- v2: change port casting from size_t to uintptr_t. --- drivers/net/mana/mana.c | 2 +- drivers/net/mana/meson.build | 4 ++-- drivers/net/mana/mr.c

RE: [PATCH 1/1] net/mana: enable 32 bit build for mana driver

2023-09-12 Thread Wei Hu
> From: Stephen Hemminger > Sent: Saturday, September 9, 2023 10:52 PM > > diff --git a/drivers/net/mana/mana.c b/drivers/net/mana/mana.c index > > 7630118d4f..a20ca1a988 100644 > > --- a/drivers/net/mana/mana.c > > +++ b/drivers/net/mana/mana.c > > @@ -1260,7 +1260,7 @@ mana_probe_port(struct ibv

[PATCH 1/1] net/mana: add 32 bit short doorbell

2023-09-09 Thread Wei Hu
Add 32 bit short doorbell support. Ring short doorbell when running in 32 bit applicactions. Cc: sta...@dpdk.org Signed-off-by: Wei Hu --- drivers/net/mana/gdma.c | 95 + drivers/net/mana/mana.h | 25 +++ drivers/net/mana/rx.c | 52

[PATCH 1/1] net/mana: enable 32 bit build for mana driver

2023-09-09 Thread Wei Hu
Enable 32 bit build on x86 Linux. Fixed build warnings and errors when building in 32 bit. Cc: sta...@dpdk.org Signed-off-by: Wei Hu --- drivers/net/mana/mana.c | 2 +- drivers/net/mana/meson.build | 4 ++-- drivers/net/mana/mr.c| 18 +- 3 files changed, 12

Re: [dpdk-dev] Fwd: [PATCH] maintainers: update hns3 pmd maintainers

2020-10-23 Thread Wei Hu (Xavier)
Hi, Thomas hns3 driver will be sent or acked by Lijun Ou,  Thanks. Acked-by: Wei Hu (Xavier) Regards Xavier On 2020/10/20 9:11, oulijun wrote: 转发的消息 From: 15 2020 <> X-Account-Key: account1 X-UIDL: 199657 X-Mozilla-Status: 0001 X-Mozilla-Status2: X-M

[dpdk-dev] [PATCH 2/2] net/hns3: support SVE Tx

2020-10-14 Thread Wei Hu (Xavier)
From: Chengwen Feng This patch adds SVE vector instructions to optimize Tx burst process. Signed-off-by: Chengwen Feng Signed-off-by: Wei Hu (Xavier) Signed-off-by: Huisong Li --- drivers/net/hns3/hns3_rxtx.c | 17 +++- drivers/net/hns3/hns3_rxtx.h | 2 + drivers/net/hns3

[dpdk-dev] [PATCH 1/2] net/hns3: support SVE Rx

2020-10-14 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch adds SVE vector instructions to optimize Rx burst process. Signed-off-by: Chengwen Feng Signed-off-by: Wei Hu (Xavier) Signed-off-by: Huisong Li Signed-off-by: Chengchang Tang --- drivers/net/hns3/hns3_rxtx.c | 28 +++- driver

[dpdk-dev] [PATCH 0/2] net/hns3: support SVE Tx/Rx

2020-10-14 Thread Wei Hu (Xavier)
This series add support SVE Tx/Rx operation. Chengwen Feng (1): net/hns3: support SVE Tx Wei Hu (Xavier) (1): net/hns3: support SVE Rx drivers/net/hns3/hns3_rxtx.c | 43 +++- drivers/net/hns3/hns3_rxtx.h | 4 + drivers/net/hns3/hns3_rxtx_vec.h | 34 ++- drivers/net

[dpdk-dev] [PATCH v5 3/3] ethdev: check queue id in Rx interrupt control routine

2020-10-13 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch add queue ID checks to Rx interrupt control routines. Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) Signed-off-by: Chengwen Feng Acked-by: Stephen Hemminger Reviewed-by: Kalesh AP --- lib/librte_ethdev/rte_ethdev.c | 10

[dpdk-dev] [PATCH v5 1/3] ethdev: extract checking queue id into common functions

2020-10-13 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch extact checking rx_queue_id or tx_queue_id into two separate common functions named eth_dev_validate_rx_queue and eth_dev_validate_tx_queue. Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) Signed-off-by: Chengwen Feng Acked-b

[dpdk-dev] [PATCH v5 2/3] ethdev: check if queue setup in queue-related APIs

2020-10-13 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch adds checking whether the related Tx or Rx queue has been setup in the queue-related API functions to avoid illegal address access. Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) Signed-off-by: Chengwen Feng Acked-by: Stephen

[dpdk-dev] [PATCH v5 0/3] check queue id in queue-related APIs

2020-10-13 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This series check queue id in queue-related API functions. Wei Hu (Xavier) (3): ethdev: extract checking queue id into common functions ethdev: check if queue setup in queue-related APIs ethdev: check queue id in Rx interrupt control routine lib/lib

[dpdk-dev] [PATCH v4] ethdev: check if queue setup in queue-related APIs

2020-10-12 Thread Wei Hu (Xavier)
. Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) Signed-off-by: Chengwen Feng Acked-by: Stephen Hemminger --- v3 -> v4: 1. dropping the 'rte_' prefix from the funcitons names. 2. get "struct rte_eth_dev *dev" as parameter and drop the port_id

[dpdk-dev] [PATCH v3] ethdev: check if queue setupped in queue-related APIs

2020-10-12 Thread Wei Hu (Xavier)
. Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) Signed-off-by: Chengwen Feng --- v2 -> v3: don't break lines in format strings. v1 -> v2: 1. replace %"PRIu16" with %u. 2. extact two common functions which validate RXQ/TXQ ids and

Re: [dpdk-dev] [PATCH v6 1/2] eal/arm64: update CPU flags

2020-10-11 Thread Wei Hu (Xavier)
Hi, Thomas Monjalon For this series, ARM engineer has already given them backed by. If you have no other opinion, can we merge them? so we can continue to promote other patch sets accelerated by using SVE instructions. Hope for your reply, thanks.   Regards Xavier On 2020/8/19 18:56, Wei Hu

Re: [dpdk-dev] [PATCH] ethdev: check if queue setupped in queue-related APIs

2020-10-11 Thread Wei Hu (Xavier)
Hi, Kalesh Anakkur Purayil On 2020/10/11 0:38, Kalesh Anakkur Purayil wrote: On Sat, Oct 10, 2020 at 12:42 PM Wei Hu (Xavier) mailto:huwei...@chinasoftinc.com>> wrote: From: Chengchang Tang mailto:tangchengch...@huawei.com>> This patch adds checking whether the rela

Re: [dpdk-dev] [PATCH] ethdev: check if queue setupped in queue-related APIs

2020-10-11 Thread Wei Hu (Xavier)
Hi, Stephen Hemminger On 2020/10/10 23:24, Stephen Hemminger wrote: On Sat, 10 Oct 2020 15:12:12 +0800 "Wei Hu (Xavier)" wrote: + if (dev->data->rx_queues[rx_queue_id] == NULL) { + RTE_ETHDEV_LOG(ERR, "Rx queue %"PRIu1

[dpdk-dev] [PATCH v2] ethdev: check if queue setupped in queue-related APIs

2020-10-11 Thread Wei Hu (Xavier)
. Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) Signed-off-by: Chengwen Feng --- v1 -> v2: 1. replace %"PRIu16" with %u. 2. extact two common functions which validate RXQ/TXQ ids and whether it has been set up or not. --- lib/

[dpdk-dev] [PATCH] ethdev: check if queue setupped in queue-related APIs

2020-10-10 Thread Wei Hu (Xavier)
. Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) Signed-off-by: Chengwen Feng --- lib/librte_ethdev/rte_ethdev.c | 56 ++ lib/librte_ethdev/rte_ethdev.h | 3 ++- 2 files changed, 58 insertions(+), 1 deletion(-) diff --git a/lib

Re: [dpdk-dev] [PATCH] maintainers: update for bonding

2020-10-09 Thread Wei Hu (Xavier)
ed-by: Wei Hu (Xavier) ---   MAINTAINERS | 1 +   1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 75a17d5..ba97f23 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -530,6 +530,7 @@ F: doc/guides/nics/features/default.ini   Link bonding   M: Chas Williams   M: Wei Hu (Xavier

Re: [dpdk-dev] [PATCH v6 0/2] update CPU flags for arm64 platform

2020-10-08 Thread Wei Hu (Xavier)
Wang wrote: -Original Message- From: Wei Hu (Xavier) Sent: Wednesday, August 19, 2020 6:57 PM To: dev@dpdk.org Cc: nd ; Honnappa Nagarahalli ; Ruifeng Wang ; jerinjac...@gmail.com; xavier.hu...@huawei.com Subject: [PATCH v6 0/2] update CPU flags for arm64 platform This series updates

Re: [dpdk-dev] [PATCH] net/bonding: fix a possible unbalance packet receiving

2020-09-30 Thread Wei Hu (Xavier)
Hi, Li RongQing Please add fixes statements in the commit log. And for the patch [2/2] of this series:    Reviewed-by: Wei Hu (Xavier) On 2020/9/30 13:40, Li RongQing wrote: ping thanks -Li

[dpdk-dev] [PATCH v2 7/9] net/hns3: support start and stop Tx or Rx queue

2020-09-29 Thread Wei Hu (Xavier)
improve readability. Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_cmd.c | 2 +- drivers/net/hns3/hns3_cmd.h | 4 +- drivers/net/hns3/hns3_ethdev.c| 98 -- drivers/net/hns3/hns3_ethdev_vf.c | 93 -- drivers/net/hns3/hns3_regs.c

[dpdk-dev] [PATCH v2 5/9] net/hns3: offload calculating the shapping para to firmware

2020-09-29 Thread Wei Hu (Xavier)
Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_dcb.c | 55 +++-- drivers/net/hns3/hns3_dcb.h | 39 +--- 2 files changed, 74 insertions(+), 20 deletions(-) diff --git a/drivers/net/hns3/hns3_dcb.c b/drivers/net/hns3

[dpdk-dev] [PATCH v2 2/9] net/hns3: maximize the queue number

2020-09-29 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" The maximum number of queues for hns3 PF and VF driver is 64 based on hns3 network engine with revision_id equals 0x21. Based on hns3 network engine with revision_id equals 0x30, the hns3 PF PMD driver can support up to 1280 queues, and hns3 VF PMD driver can

[dpdk-dev] [PATCH v2 8/9] net/hns3: check return value when reading PCI config space

2020-09-29 Thread Wei Hu (Xavier)
From: Hongbo Zheng This patch add return value check when calling rte_pci_read_config function. Fixes: cea37e513329 ("net/hns3: fix FLR reset") Cc: sta...@dpdk.org Signed-off-by: Hongbo Zheng Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_ethdev

[dpdk-dev] [PATCH v2 9/9] net/hns3: remove redundant return value assignments

2020-09-29 Thread Wei Hu (Xavier)
From: Hongbo Zheng When an error occurs in the reset process, -EIO is returned. The assignment of ret here is redundant, so deleted it. Signed-off-by: Hongbo Zheng Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_intr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net

[dpdk-dev] [PATCH v2 3/9] net/hns3: fix error type when validating RSS flow action

2020-09-29 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" Because the macro named RTE_FLOW_ERROR_TYPE_ACTION_CONF indicates a action configuration and the macro named RTE_FLOW_ERROR_TYPE_ACTION indicates a specific action, the driver needs to return RTE_FLOW_ERROR_ACTION_CONF type and notify the user when a RSS config

[dpdk-dev] [PATCH v2 6/9] net/hns3: set max scheduling rate based on actual board

2020-09-29 Thread Wei Hu (Xavier)
environment. The max_tm_rate in struct hns3_hw, meaning the rate, is obtained from firmware. So we should use the variable to configure the max scheduling rate. Signed-off-by: Huisong Li Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_dcb.c | 12 ++-- 1 file changed, 6 insertions

[dpdk-dev] [PATCH v2 1/9] net/hns3: expand the number of queues for one TC up to 512

2020-09-29 Thread Wei Hu (Xavier)
rss_result_h, while rss_result_l records the lower 8 bits and rss_result_h records the higher 1 bit. In addition, 2~4 modifications is also compatible with hns3 VF PMD driver. Signed-off-by: Huisong Li Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_cmd.h| 17 - drivers

[dpdk-dev] [PATCH v2 0/9] updates and fixes for hns3 PMD driver

2020-09-29 Thread Wei Hu (Xavier)
the number of queues for one TC up to 512 net/hns3: offload calculating the shapping para to firmware net/hns3: set max scheduling rate based on actual board Wei Hu (Xavier) (3): net/hns3: maximize the queue number net/hns3: fix error type when validating RSS flow action net/hns3: set

[dpdk-dev] [PATCH v2 4/9] net/hns3: set suitable type when initial flow error struct

2020-09-29 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" The API of rte_flow_error_set is used to pass detail error information to caller, this patch sets suitable type when calling rte_flow_error_set API. Fixes: fcba820d9b9e ("net/hns3: support flow director") Fixes: c37ca66f2b27 ("net/hns3: support

[dpdk-dev] [PATCH 7/9] net/hns3: support start and stop Tx or Rx queue

2020-09-29 Thread Wei Hu (Xavier)
improve readability. Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_cmd.c | 2 +- drivers/net/hns3/hns3_cmd.h | 4 +- drivers/net/hns3/hns3_ethdev.c| 98 -- drivers/net/hns3/hns3_ethdev_vf.c | 93 -- drivers/net/hns3/hns3_regs.c

[dpdk-dev] [PATCH 9/9] net/hns3: remove redundant return value assignments

2020-09-29 Thread Wei Hu (Xavier)
From: Hongbo Zheng When an error occurs in the reset process, -EIO is returned. The assignment of ret here is redundant, so deleted it. Signed-off-by: Hongbo Zheng Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_intr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net

[dpdk-dev] [PATCH 8/9] net/hns3: check return value when reading PCI config space

2020-09-29 Thread Wei Hu (Xavier)
From: Hongbo Zheng This patch add return value check when calling rte_pci_read_config function. Fixes: cea37e513329 ("net/hns3: fix FLR reset") Cc: sta...@dpdk.org Signed-off-by: Hongbo Zheng Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_ethdev

[dpdk-dev] [PATCH 5/9] net/hns3: offload calculating the shapping para to firmware

2020-09-29 Thread Wei Hu (Xavier)
Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_dcb.c | 55 +++-- drivers/net/hns3/hns3_dcb.h | 39 +--- 2 files changed, 74 insertions(+), 20 deletions(-) diff --git a/drivers/net/hns3/hns3_dcb.c b/drivers/net/hns3

[dpdk-dev] [PATCH 6/9] net/hns3: set max scheduling rate based on actual board

2020-09-29 Thread Wei Hu (Xavier)
environment. The max_tm_rate in struct hns3_hw, meaning the rate, is obtained from firmware. So we should use the variable to configure the max scheduling rate. Signed-off-by: Huisong Li Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_dcb.c | 12 ++-- 1 file changed, 6 insertions

[dpdk-dev] [PATCH 0/9] updates and fixes for hns3 PMD driver

2020-09-29 Thread Wei Hu (Xavier)
the number of queues for one TC up to 512 net/hns3: offload calculating the shapping para to firmware net/hns3: set max scheduling rate based on actual board Wei Hu (Xavier) (3): net/hns3: maximize the queue number net/hns3: fix error type when validating RSS flow action net/hns3: set

[dpdk-dev] [PATCH 3/9] net/hns3: fix error type when validating RSS flow action

2020-09-29 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" Because the macro named RTE_FLOW_ERROR_TYPE_ACTION_CONF indicates a action configuration and the macro named RTE_FLOW_ERROR_TYPE_ACTION indicates a specific action, the driver needs to return RTE_FLOW_ERROR_ACTION_CONF type and notify the user when a RSS config

[dpdk-dev] [PATCH 2/9] net/hns3: maximize the queue number

2020-09-29 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" The maximum number of queues for hns3 PF and VF driver is 64 based on hns3 network engine with revision_id equals 0x21. Based on hns3 network engine with revision_id equals 0x30, the hns3 PF PMD driver can support up to 1280 queues, and hns3 VF PMD driver can

[dpdk-dev] [PATCH 4/9] net/hns3: set suitable type when initial flow error struct

2020-09-29 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" The API of rte_flow_error_set is used to pass detail error information to caller, this patch sets suitable type when calling rte_flow_error_set API. Fixes: fcba820d9b9e ("net/hns3: support flow director") Fixes: c37ca66f2b27 ("net/hns3: support

[dpdk-dev] [PATCH 1/9] net/hns3: expand the number of queues for one TC up to 512

2020-09-29 Thread Wei Hu (Xavier)
rss_result_h, while rss_result_l records the lower 8 bits and rss_result_h records the higher 1 bit. In addition, 2~4 modifications is also compatible with hns3 VF PMD driver. Signed-off-by: Huisong Li Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_cmd.h| 17 - drivers

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: update Rx RSS HASH offload when setting MQ RSS

2020-09-28 Thread Wei Hu (Xavier)
Hi, Ferruh Yigit On 2020/9/23 17:35, Ferruh Yigit wrote: On 9/23/2020 8:04 AM, Wei Hu (Xavier) wrote: Hi, Ferruh Yigit On 2020/9/23 0:21, Ferruh Yigit wrote: On 9/8/2020 3:16 AM, Wei Hu (Xavier) wrote: From: Huisong Li Currently, when starting testpmd application without '--disabl

Re: [dpdk-dev] [PATCH v6 0/2] update CPU flags for arm64 platform

2020-09-27 Thread Wei Hu (Xavier)
Friendly ping. On 2020/8/19 18:56, Wei Hu (Xavier) wrote: This series updates CPU flags for arm64 platform. Wei Hu (Xavier) (2): eal/arm64: update CPU flags test/cpuflag: add new flags for ARM64 platform app/test/test_cpuflags.c | 39 lib

[dpdk-dev] [PATCH v4 6/6] app/testpmd: fix displaying Rx Tx queues information

2020-09-25 Thread Wei Hu (Xavier)
1 ("app/testpmd: fix port configuration print") Fixes: d44f8a485f5d1f ("app/testpmd: enable per queue configure") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Wei Hu (Xavier) Reviewed-by: Ferruh Yigit --- app/test-pmd/config.c | 64 +++

[dpdk-dev] [PATCH v4 3/6] app/testpmd: remove restriction on txpkts set

2020-09-25 Thread Wei Hu (Xavier)
.@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) --- v3 -> v4: add check 'rte_eth_rx_queue_info_get()' return value and if it is '-ENOSTUP' calculate the 'ring_size'. v3: initi

[dpdk-dev] [PATCH v4 0/6] minor fixes for testpmd

2020-09-25 Thread Wei Hu (Xavier)
This series are minor fixes for testpmd application. Chengchang Tang (5): app/testpmd: fix missing verification of port id app/testpmd: fix VLAN offload configuration when config fail app/testpmd: remove restriction on txpkts set app/testpmd: fix packet header in txonly mode app/testpmd:

[dpdk-dev] [PATCH v4 1/6] app/testpmd: fix missing verification of port id

2020-09-25 Thread Wei Hu (Xavier)
member of non-existent port. This patch adds verification of port id in tx vlan offloads and remove duplicated check. Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) Reviewed-by: Fe

[dpdk-dev] [PATCH v4 4/6] app/testpmd: fix packet header in txonly mode

2020-09-25 Thread Wei Hu (Xavier)
32b7 ("app/testpmd: add ability to split outgoing packets") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) --- app/test-pmd/txonly.c | 32 1 file changed, 32 insertions(+) diff --git a/app/test-pmd/txonly.c b/app/tes

[dpdk-dev] [PATCH v4 2/6] app/testpmd: fix VLAN offload configuration when config fail

2020-09-25 Thread Wei Hu (Xavier)
. This patch makes the function return directly insead of refreshing the configuration when execution fails. Fixes: 384161e00627 ("app/testpmd: adjust on the fly VLAN configuration") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) Reviewed-by: Fe

[dpdk-dev] [PATCH v4 5/6] app/testpmd: fix valid desc id check

2020-09-25 Thread Wei Hu (Xavier)
use a default value to confiure the queue if nb_rx_desc or nb_tx_desc is zero. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) --- v3 -> v4: add check 'rte_eth_rx_queue_info_get()' return val

Re: [dpdk-dev] [PATCH 2/2] app/testpmd: retain original FDIR mode when configuring DCB

2020-09-23 Thread Wei Hu (Xavier)
Hi, Ajit Khaparde On 2020/9/23 15:14, Wei Hu (Xavier) wrote: Hi, Ajit Khaparde On 2020/9/22 13:15, Ajit Khaparde wrote: On Mon, Sep 7, 2020 at 7:16 PM Wei Hu (Xavier) wrote: From: Huisong Li Sometimes, we have to start testpmd application with --pkt-filter-mode to test flow table

Re: [dpdk-dev] [PATCH v3 3/6] app/testpmd: remove restriction on txpkts set

2020-09-23 Thread Wei Hu (Xavier)
Hi, Ferruh Yigit On 2020/9/23 11:14, Wei Hu (Xavier) wrote: Hi, Ferruh Yigit On 2020/9/22 22:51, Ferruh Yigit wrote: On 9/19/2020 11:47 AM, Wei Hu (Xavier) wrote: From: Chengchang Tang Currently, if nb_txd is not set, the txpkts is not allowed to be set because the nb_txd is used to avoid

[dpdk-dev] [PATCH v2] app/testpmd: update Rx RSS HASH offload when setting MQ RSS

2020-09-23 Thread Wei Hu (Xavier)
rivers. Signed-off-by: Huisong Li Signed-off-by: Wei Hu (Xavier) --- v1 -> v2: add check if PMD support DEV_RX_OFFLOAD_RSS_HASH before setting it. --- app/test-pmd/testpmd.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/te

Re: [dpdk-dev] [PATCH 2/2] app/testpmd: retain original FDIR mode when configuring DCB

2020-09-23 Thread Wei Hu (Xavier)
Hi, Ajit Khaparde On 2020/9/22 13:15, Ajit Khaparde wrote: On Mon, Sep 7, 2020 at 7:16 PM Wei Hu (Xavier) wrote: From: Huisong Li Sometimes, we have to start testpmd application with --pkt-filter-mode to test flow table feature. When using 'port config 0 dcb vt off 4 pfc on' co

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: update Rx RSS HASH offload when setting MQ RSS

2020-09-23 Thread Wei Hu (Xavier)
Hi, Ferruh Yigit On 2020/9/23 0:21, Ferruh Yigit wrote: On 9/8/2020 3:16 AM, Wei Hu (Xavier) wrote: From: Huisong Li Currently, when starting testpmd application without '--disable-rss' and the number of Rx queue configured is greater than 1, ETH_MQ_RX_RSS flag is s

Re: [dpdk-dev] [PATCH v3 3/6] app/testpmd: remove restriction on txpkts set

2020-09-22 Thread Wei Hu (Xavier)
Hi, Ferruh Yigit On 2020/9/22 22:51, Ferruh Yigit wrote: On 9/19/2020 11:47 AM, Wei Hu (Xavier) wrote: From: Chengchang Tang Currently, if nb_txd is not set, the txpkts is not allowed to be set because the nb_txd is used to avoid the numer of segments exceed the Tx ring size and the default

[dpdk-dev] [PATCH v2 16/17] net/hns3: fix configuring device with RSS is enabled

2020-09-22 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" Currently, when running the following commands in the CLI of testpmd application, the driver reports an -EINVAL error when performing the No.3 step. 1) flow create 0 ingress pattern end actions rss key func simple_xor types all end / end 2) flow flush

[dpdk-dev] [PATCH v2 14/17] net/hns3: fix flow RSS queue num with 0

2020-09-22 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" When user specifies RSS queue num for 0 in action list by flow create API, it should create a valid flow rule. The following flow rule should be success in the command line of the testpmd application: flow create 0 actions rss queues / end Fixes: c37ca66f

[dpdk-dev] [PATCH v2 17/17] net/hns3: fix storing RSS info when creating flow action

2020-09-22 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" Currently, when calling the rte_flow_query API function to query the RSS information, the queue related information is not as expected. The root cause is that when application call the rte_flow_create API function to create RSS action, the operation of storin

[dpdk-dev] [PATCH v2 15/17] net/hns3: fix flushing RSS rule

2020-09-22 Thread Wei Hu (Xavier)
Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_flow.c | 79 drivers/net/hns3/hns3_rss.h | 1 + 2 files changed, 58 insertions(+), 22 deletions(-) diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flow.c index 5b5124c..05cc95e

[dpdk-dev] [PATCH v2 07/17] net/hns3: add default branch to switch when parsing fd tuple

2020-09-22 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch solves the static check warning in the internal function named hns3_fd_convert_tuple as follow: "The switch statement must have a 'default' branch". Signed-off-by: Chengwen Feng Signed-off-by: Wei Hu (Xavier) --- dr

[dpdk-dev] [PATCH v2 12/17] net/hns3: set RSS hash type input configuration

2020-09-22 Thread Wei Hu (Xavier)
jun Ou Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_cmd.h| 9 +- drivers/net/hns3/hns3_ethdev.h | 2 + drivers/net/hns3/hns3_rss.c| 244 +++-- drivers/net/hns3/hns3_rss.h| 20 +--- 4 files changed, 197 insertions(+), 78 deletions(-)

[dpdk-dev] [PATCH v2 10/17] net/hns3: support querying RSS flow rule

2020-09-22 Thread Wei Hu (Xavier)
From: Lijun Ou This patch enables to query some RSS configurations of the specified rule. For example, show RSS hash function and rss types. Signed-off-by: Lijun Ou Signed-off-by: Chengwen Feng Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_flow.c | 23 --- 1

[dpdk-dev] [PATCH v2 09/17] net/hns3: support flow action of queue region

2020-09-22 Thread Wei Hu (Xavier)
_END after calling rte_flow_create, one FDIR rule will be created. Signed-off-by: Chengwen Feng Signed-off-by: Wei Hu (Xavier) --- v1 -> v2: fix TYPO_SPELLING with 'QUEUE'. --- drivers/net/hns3/hns3_cmd.c| 5 +- drivers/net/hns3/hns3_cmd.h| 2 +- drivers/net/hns3/hns3_ethdev.h | 8 +-

[dpdk-dev] [PATCH v2 08/17] net/hns3: add break to exit loop when err stat item found

2020-09-22 Thread Wei Hu (Xavier)
statistical item without traversing the remaining table entries. Signed-off-by: Hongbo Zheng Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_stats.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/hns3/hns3_stats.c b/drivers/net/hns3/hns3_stats.c index 067673c..e8846b9 100644

[dpdk-dev] [PATCH v2 11/17] net/hns3: check input RSS type when creating flow with RSS

2020-09-22 Thread Wei Hu (Xavier)
From: Lijun Ou This patch adds checking the input RSS type when creating a flow with RSS. If the input RSS type are not supported based on hns3 network engine, an error is returned. Signed-off-by: Lijun Ou Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_flow.c | 26

[dpdk-dev] [PATCH v2 13/17] net/hns3: fix config when creating RSS rule after flush

2020-09-22 Thread Wei Hu (Xavier)
parameters in the hardware is unavailable. Also we set hw->rss_info.func to RTE_ETH_HASH_FUNCTION_MAX that indicate it is invalid. Fixes: c37ca66f2b27 ("net/hns3: support RSS") Cc: sta...@dpdk.org Signed-off-by: Lijun Ou Signed-off-by: Wei Hu (Xavier) --- driver

[dpdk-dev] [PATCH v2 06/17] net/hns3: avoid accessing nonexistent VF reg when PF in FLR

2020-09-22 Thread Wei Hu (Xavier)
to be processed by PMD driver. Fixes: 2790c6464725 ("net/hns3: support device reset") Cc: sta...@dpdk.org Signed-off-by: Hongbo Zheng Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_ethdev.h| 7 +++ drivers/net/hns3/hns3_ethdev_vf.c | 15 +++ 2 files changed

[dpdk-dev] [PATCH v2 05/17] net/hns3: add TSO pseudo header calculation compatibility

2020-09-22 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" In kunpeng 920, when process pkts which need TSO, the network driver need to erase the L4 len value of the TCP TSO pseudo header and recalculate the pseudo header checksum. kunpeng930 support not need to erase the L4 len value of the TCP TSO pseudo header. Sig

[dpdk-dev] [PATCH v2 01/17] net/hns3: add VLAN configuration compatibility

2020-09-22 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" Because of hardware limitation based on the old version of hns3 network engine, there are some restrictions: a) HNS3 PMD driver needs select different processing mode for VLAN based on whether PVID is set which means our driver need sense the PVID stat

[dpdk-dev] [PATCH v2 00/17] updates for hns3 PMD driver

2020-09-22 Thread Wei Hu (Xavier)
hash type input configuration net/hns3: fix config when creating RSS rule after flush net/hns3: fix flushing RSS rule Wei Hu (Xavier) (6): net/hns3: add VLAN configuration compatibility net/hns3: add TSO pseudo header calculation compatibility net/hns3: add default branch to switch when pa

[dpdk-dev] [PATCH v2 04/17] net/hns3: add max number of segs compatibility

2020-09-22 Thread Wei Hu (Xavier)
: Hongbo Zheng Signed-off-by: Wei Hu (Xavier) Signed-off-by: Chengchang Tang --- drivers/net/hns3/hns3_ethdev.c| 2 +- drivers/net/hns3/hns3_ethdev_vf.c | 2 +- drivers/net/hns3/hns3_rxtx.c | 30 -- drivers/net/hns3/hns3_rxtx.h | 1 + 4 files changed

[dpdk-dev] [PATCH v2 02/17] net/hns3: fix default VLAN won't be deleted when set PF PVID

2020-09-22 Thread Wei Hu (Xavier)
from the hardware VLAN table when device is closed. Fixes: 411d23b9eafb ("net/hns3: support VLAN") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) --- v1 -> v2: fix TYPO_SPELLING with INVALID. --- drivers/net/hns3/hns3_e

[dpdk-dev] [PATCH v2 03/17] net/hns3: add default branch to switch in Rx VLAN processing

2020-09-22 Thread Wei Hu (Xavier)
From: Chengchang Tang This patch solves the static check warning as follow: "The switch statement must have a 'default' branch". Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_rxtx.c | 3 +++ 1 file changed, 3 insertions(+) diff

[dpdk-dev] [PATCH 16/17] net/hns3: fix configuring device with RSS is enabled

2020-09-22 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" Currently, when running the following commands in the CLI of testpmd application, the driver reports an -EINVAL error when performing the No.3 step. 1) flow create 0 ingress pattern end actions rss key func simple_xor types all end / end 2) flow flush

[dpdk-dev] [PATCH 14/17] net/hns3: fix flow RSS queue num with 0

2020-09-22 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" When user specifies RSS queue num for 0 in action list by flow create API, it should create a valid flow rule. The following flow rule should be success in the command line of the testpmd application: flow create 0 actions rss queues / end Fixes: c37ca66f

[dpdk-dev] [PATCH 17/17] net/hns3: fix storing RSS info when creating flow action

2020-09-22 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" Currently, when calling the rte_flow_query API function to query the RSS information, the queue related information is not as expected. The root cause is that when application call the rte_flow_create API function to create RSS action, the operation of storin

[dpdk-dev] [PATCH 15/17] net/hns3: fix flushing RSS rule

2020-09-22 Thread Wei Hu (Xavier)
Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_flow.c | 79 drivers/net/hns3/hns3_rss.h | 1 + 2 files changed, 58 insertions(+), 22 deletions(-) diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flow.c index 5b5124c..4f078e8

[dpdk-dev] [PATCH 09/17] net/hns3: support flow action of queue region

2020-09-22 Thread Wei Hu (Xavier)
_END after calling rte_flow_create, one FDIR rule will be created. Signed-off-by: Chengwen Feng Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_cmd.c| 5 +- drivers/net/hns3/hns3_cmd.h| 2 +- drivers/net/hns3/hns3_ethdev.h | 8 +-- drivers/net/hns3/hns3_fdir.c | 35 +++-

[dpdk-dev] [PATCH 12/17] net/hns3: set RSS hash type input configuration

2020-09-22 Thread Wei Hu (Xavier)
jun Ou Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_cmd.h| 9 +- drivers/net/hns3/hns3_ethdev.h | 2 + drivers/net/hns3/hns3_rss.c| 244 +++-- drivers/net/hns3/hns3_rss.h| 20 +--- 4 files changed, 197 insertions(+), 78 deletions(-)

[dpdk-dev] [PATCH 10/17] net/hns3: support querying RSS flow rule

2020-09-22 Thread Wei Hu (Xavier)
From: Lijun Ou This patch enables to query some RSS configurations of the specified rule. For example, show RSS hash function and rss types. Signed-off-by: Lijun Ou Signed-off-by: Chengwen Feng Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_flow.c | 23 --- 1

  1   2   3   4   5   6   >