Re: [PATCH v3] net/gve: add support for TSO in DQO RDA

2024-08-19 Thread Tathagat Priyadarshi
On Sat, Aug 10, 2024 at 12:19 AM Tathagat Priyadarshi wrote: > > The patch intends on adding support for TSO in DQO RDA format. > > Signed-off-by: Tathagat Priyadarshi > Signed-off-by: Varun Lakkur Ambaji Rao > --- > drivers/net/gve/gve_tx_dqo.c | 26 +++

[PATCH v3] net/gve: add support for TSO in DQO RDA

2024-08-09 Thread Tathagat Priyadarshi
The patch intends on adding support for TSO in DQO RDA format. Signed-off-by: Tathagat Priyadarshi Signed-off-by: Varun Lakkur Ambaji Rao --- drivers/net/gve/gve_tx_dqo.c | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/drivers/net/gve

Re: [PATCH v2] net/gve: add support for TSO in DQO RDA

2024-08-08 Thread Tathagat Priyadarshi
Supersedes https://patches.dpdk.org/project/dpdk/patch/1722507548-2401507-1-git-send-email-tathagat.d...@gmail.com/

Re: [PATCH] net/gve: Add support for TSO in DQO RDA

2024-08-08 Thread Tathagat Priyadarshi
> Hi Tathagat, > > This patch has bits from other patch just merged, can you please send a > new version of this patch, on top of latest next-net [1] tree? > > [1] > https://git.dpdk.org/next/dpdk-next-net/ Superseded via https://patches.dpdk.org/project/dpdk/patch/1723141392-2437012-1-git-send-e

[PATCH v2] net/gve: add support for TSO in DQO RDA

2024-08-08 Thread Tathagat Priyadarshi
The patch intends on adding support for TSO in DQO RDA format. Signed-off-by: Tathagat Priyadarshi Signed-off-by: Varun Lakkur Ambaji Rao --- drivers/net/gve/gve_tx_dqo.c | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/drivers/net/gve

Re: [PATCH v5] net/gve : Update EOP & csum bit in txd rte_mbuf chain

2024-08-06 Thread Tathagat Priyadarshi
hi Ferruh, Could you please accept the updated patch?! let us know what's pending. https://patches.dpdk.org/project/dpdk/patch/1722575288-2408630-1-git-send-email-tathagat.d...@gmail.com/ TIA On Fri, Aug 2, 2024 at 10:40 AM Tathagat Priyadarshi wrote: > > Updated the if-else bl

Re: [PATCH v5] net/gve : Update EOP & csum bit in txd rte_mbuf chain

2024-08-01 Thread Tathagat Priyadarshi
Updated the if-else block with an optimised inverse operator. Thanks for your suggestion Stephen. On Fri, Aug 2, 2024 at 10:36 AM Tathagat Priyadarshi wrote: > > The EOP and csum bit was not set for all the packets in mbuf chain > causing packet transmission stalls for packets spl

[PATCH v5] net/gve : Update EOP & csum bit in txd rte_mbuf chain

2024-08-01 Thread Tathagat Priyadarshi
The EOP and csum bit was not set for all the packets in mbuf chain causing packet transmission stalls for packets split across mbuf in chain. Fixes: 4022f99 ("net/gve: support basic Tx data path for DQO") Cc: sta...@dpdk.org Signed-off-by: Tathagat Priyadarshi Signed-off-by: Varun Lak

Re: [PATCH v3] net/gve : Update EOP & csum bit in txd rte_mbuf chain

2024-08-01 Thread Tathagat Priyadarshi
Thanks for your suggestion Stephen, I have already updated the patch with v4 & fixed the typo. Will consider your suggestion in the next version of the patch. On Fri, 2 Aug 2024 at 00:24, Stephen Hemminger wrote: > On Thu, 1 Aug 2024 17:27:53 + > Tathagat Priyadar

Re: [PATCH] net/gve : Update EOP bit in txd rte_mbuf chain

2024-08-01 Thread Tathagat Priyadarshi
Hi Josh, Updated the patch (https://patches.dpdk.org/project/dpdk/patch/1722534481-2405601-1-git-send-email-tathagat.d...@gmail.com/), please ACK if it looks good. Thanks! On Thu, Aug 1, 2024 at 9:55 PM Joshua Washington wrote: > > Hi, can we try to serialize these patches? Let's fix the multi

[PATCH v4] net/gve : Update EOP & csum bit in txd rte_mbuf chain

2024-08-01 Thread Tathagat Priyadarshi
The EOP and csum bit was not set for all the packets in mbuf chain causing packet transmission stalls for packets split across mbuf in chain. Fixes: 4022f99 ("net/gve: support basic Tx data path for DQO") Cc: sta...@dpdk.org Signed-off-by: Tathagat Priyadarshi Signed-off-by: Varun Lak

[PATCH v3] net/gve : Update EOP & csum bit in txd rte_mbuf chain

2024-08-01 Thread Tathagat Priyadarshi
The EOP and csum bit was not set for all the packets in mbuf chain causing packet transmission stalls for packets split across mbuf in chain. Fixes: 4022f99 ("net/gve: support basic Tx data path for DQO") Cc: sta...@dpdk.org Signed-off-by: Tathagat Priyadarshi Signed-off-by: Varun Lak

[PATCH v2] net/gve : Update EOP bit in txd rte_mbuf chain

2024-08-01 Thread Tathagat Priyadarshi
The EOP bit was not set for all the packets in mbuf chain causing packet transmission stalls for packets split across mbuf in chain. Fixes: 4022f99 ("net/gve: support basic Tx data path for DQO") Cc: sta...@dpdk.org Signed-off-by: Tathagat Priyadarshi Signed-off-by: Varun Lakkur

Re: [PATCH] net/gve: Add support for TSO in DQO RDA

2024-08-01 Thread Tathagat Priyadarshi
The following patch depends on https://patches.dpdk.org/project/dpdk/patch/1722443901-2400194-1-git-send-email-tathagat.d...@gmail.com/ Will retrigger git patch checks post its approved and upstreamed. To avoid conflicts. On Thu, Aug 1, 2024 at 3:47 PM Tathagat Priyadarshi wrote: > > The

Re: [PATCH] net/gve : Update EOP bit in txd rte_mbuf chain

2024-08-01 Thread Tathagat Priyadarshi
Washington wrote: > > On Wed, Jul 31, 2024, 09:37 Tathagat Priyadarshi > wrote: > > > > The EOP bit was not set for all the packets in mbuf chain > > causing packet transmission stalls for packets split across > > mbuf in chain. > > > > Signed-off-by: T

[PATCH] net/gve: Add support for TSO in DQO RDA

2024-08-01 Thread Tathagat Priyadarshi
The patch intends on adding support for TSO in DQO RDA format. Signed-off-by: Tathagat Priyadarshi Signed-off-by: Varun Lakkur Ambaji Rao --- drivers/net/gve/gve_tx_dqo.c | 42 -- 1 file changed, 36 insertions(+), 6 deletions(-) diff --git a/drivers/net

[PATCH] net/gve : Update EOP bit in txd rte_mbuf chain

2024-07-31 Thread Tathagat Priyadarshi
The EOP bit was not set for all the packets in mbuf chain causing packet transmission stalls for packets split across mbuf in chain. Signed-off-by: Tathagat Priyadarshi Signed-off-by: Varun Lakkur Ambaji Rao Fixes: 4022f99 ("net/gve: support basic Tx data path for DQO") --- drive

[PATCH v2] net/gve: Fix TX/RX queue setup and stop

2024-07-30 Thread Tathagat Priyadarshi
The PR aims to update the TX/RQ queue setup/stop routines that are unique to DQO, so that they may be called for instances that use the DQO RDA format during dev start/stop Fixes: b044845 ("net/gve: support queue start/stop") Cc: sta...@dpdk.org Signed-off-by: Tathagat Priyadarshi --

Re: [PATCH v2] net/gve: Fix TX/RX queue setup and stop

2024-07-26 Thread Tathagat Priyadarshi
/) , let me know if this is fine. On Thu, Jul 25, 2024 at 6:59 PM Tathagat Priyadarshi < tathagat.d...@gmail.com> wrote: > The PR aims to update the TX/RQ queue setup/stop routines that are > unique to DQO, so that they may be called for instances that use the > DQO RDA format during

[PATCH v2] net/gve: Fix TX/RX queue setup and stop

2024-07-25 Thread Tathagat Priyadarshi
The PR aims to update the TX/RQ queue setup/stop routines that are unique to DQO, so that they may be called for instances that use the DQO RDA format during dev start/stop Signed-off-by: Tathagat Priyadarshi --- drivers/net/gve/gve_ethdev.c | 29 +++-- 1 file changed

Re: [PATCH] net/gve: Fix TX/RX queue setup and stop

2024-07-25 Thread Tathagat Priyadarshi
ed by Joshua, since the diff was originally shared with him and he was okay with it. Regards, TP On Thu, 25 Jul 2024 at 18:08, Ferruh Yigit wrote: > On 7/24/2024 2:35 PM, Tathagat Priyadarshi wrote: > > The PR aims to update the TX/RQ queue setup/stop routines that are > > unique

[PATCH] net/gve: Fix TX/RX queue setup and stop

2024-07-24 Thread Tathagat Priyadarshi
The PR aims to update the TX/RQ queue setup/stop routines that are unique to DQO, so that they may be called for instances that use the DQO RDA format during dev start/stop. Signed-off-by: Tathagat Priyadarshi Acked-by: Joshua Washington --- drivers/net/gve/gve_ethdev.c | 29

[PATCH v2] net/gve: Fix TX/RX queue setup and stop

2024-07-24 Thread Tathagat Priyadarshi
The PR aims to update the TX/RQ queue setup/stop routines that are unique to DQO, so that they may be called for instances that use the DQO RDA format during dev start/stop. Signed-off-by: Tathagat Priyadarshi Acked-by: Joshua Washington --- drivers/net/gve/gve_ethdev.c | 29

[PATCH] net/gve: Fix TX/RX queue setup and stop for DQO

2024-07-23 Thread Tathagat Priyadarshi
The PR aims to update the TX/RQ queue setup/stop routines that are unique to DQO, so that they may be called for instances that use the DQO RDA format during dev start/stop. Signed-off-by: Tathagat Priyadarshi Acked-by: Joshua Washington --- drivers/net/gve/gve_ethdev.c | 26

Re: [PATCH] net/gve: Update TX queue state

2024-07-22 Thread Tathagat Priyadarshi
Thanks Ferruh. On Mon, Jul 22, 2024 at 7:41 PM Ferruh Yigit wrote: > On 7/22/2024 12:10 PM, Tathagat Priyadarshi wrote: > > Fixing Typo in updating the TX queue state > > > > Signed-off-by: Tathagat Priyadarshi > > > > Good catch, thanks Tathagat. > > I

[PATCH] net/gve: Update TX queue state

2024-07-22 Thread Tathagat Priyadarshi
Fixing Typo in updating the TX queue state Signed-off-by: Tathagat Priyadarshi --- drivers/net/gve/gve_tx.c | 2 +- drivers/net/gve/gve_tx_dqo.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/gve/gve_tx.c b/drivers/net/gve/gve_tx.c index 70d3ef0..500ae31

Re: [PATCH] net/gve: Update Rx/Tx functions for RTE_PROC_SECONDARY

2024-07-18 Thread Tathagat Priyadarshi
Thanks Joshua, I will fix all the nits in my next email. On Fri, Jul 19, 2024 at 8:53 AM Joshua Washington wrote: > My ack might have been a bit premature. This patch seems to have a > number of style errors, and does not seem to apply to HEAD of > dpdk-next-net. See http://dpdk.org/patch/142498

[PATCH] net/gve: Update Rx/Tx functions for RTE_PROC_SECONDARY

2024-07-17 Thread Tathagat Priyadarshi
ers. This requires initializing the eth_dev_ops and updating the RX/TX functions for these pollers. Signed-off-by: Tathagat Priyadarshi Acked-by: Rushil Gupta --- drivers/net/gve/gve_ethdev.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/net/