Thanks for your suggestion Stephen, I have already updated the patch with v4 & fixed the typo. Will consider your suggestion in the next version of the patch.
On Fri, 2 Aug 2024 at 00:24, Stephen Hemminger <step...@networkplumber.org> wrote: > On Thu, 1 Aug 2024 17:27:53 +0000 > Tathagat Priyadarshi <tathagat.d...@gmail.com> wrote: > > > + if (ol_flags & GVE_TX_CKSUM_OFFLOAD_MASK_DQO) > > + csum = 1; > > + else > > + cusm = 0; > > + > > Obvious typo, did you do a final test build? > > Could also use logical inverse operator instead of if() which will > generate better code sometimes. > > csum = !!(ol_flags & GVE_TX_CKSUM_OFFLOAD_MASK_DQO); > >
