[dpdk-dev] [PATCH v5] ethdev: fix MAC address replay

2017-01-27 Thread Steve Shin
multiple pools exist in the mac_pool_sel array. v4: removed a coding style warning. v5: Added default MAC replay with dev_ops->mac_addr_add. Signed-off-by: Steve Shin --- lib/librte_ether/rte_ethdev.c | 48 --- 1 file changed, 27 insertions(+), 21 d

[dpdk-dev] [PATCH v4] ethdev: fix MAC address replay

2017-01-23 Thread Steve Shin
multiple pools exist in the mac_pool_sel array. v4: removed a coding style warning Signed-off-by: Steve Shin --- lib/librte_ether/rte_ethdev.c | 43 --- 1 file changed, 24 insertions(+), 19 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c b/li

[dpdk-dev] [PATCH v3] ethdev: fix MAC address replay

2017-01-23 Thread Steve Shin
se (ex, SR-IOV) where multiple pools exist in the mac_pool_sel array. Signed-off-by: Steve Shin --- lib/librte_ether/rte_ethdev.c | 42 +++--- 1 file changed, 23 insertions(+), 19 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c b/li

Re: [dpdk-dev] [PATCH v2] ethdev: fix MAC address replay

2017-01-23 Thread Steve Shin (jonshin)
Dear Igor, Yes, you’re right. We need to handle a case (ex, SR-IOV) where multiple pools exist in the mac_pool_sel array. A new diff file will be uploaded with PATCH v3. Thanks & Regards, Steve From: Igor Ryzhov Date: Monday, January 23, 2017 at 12:50 AM To: Steve Shin Cc: "dev

[dpdk-dev] [PATCH v2] ethdev: fix MAC address replay

2017-01-20 Thread Steve Shin
This patch fixes a bug in replaying MAC address to the hardware in rte_eth_dev_config_restore() routine. Added default MAC replay as well. Fixes: 4bdefaade6d1 ("ethdev: VMDQ enhancements") --- v2: Added default MAC replay & Code optimization Signed-off-by: Steve Shin --- li

Re: [dpdk-dev] [PATCH] lib/librte_ether: error handling on MAC address replay

2017-01-20 Thread Steve Shin (jonshin)
Ferruh recommended to change tag in patch subject title. So next patch will have a different tile as “ethdev: fix MAC address replay”. Thanks & Regards, Steve From: Igor Ryzhov Date: Friday, January 20, 2017 at 4:17 AM To: Steve Shin Cc: "dev@dpdk.org" , "ferruh.yi...@intel.com&

Re: [dpdk-dev] [PATCH] lib/librte_ether: error handling on MAC address replay

2017-01-19 Thread Steve Shin (jonshin)
l_sel[0] = 1; + return 0; Any thoughts would be appreciated. Regards, Steve From: Igor Ryzhov Date: Thursday, January 19, 2017 at 2:39 PM To: Steve Shin Cc: "dev@dpdk.org" , "ferruh.yi...@intel.com" Subject: Re: [dpdk-dev] [PATCH] lib/librte_ether: error handling on

Re: [dpdk-dev] [PATCH] lib/librte_ether: error handling on MAC address replay

2017-01-19 Thread Steve Shin (jonshin)
Dear maintainer, Sorry that I forgot to add “Fixes:” line as follows: Fixes: 4bdefaade6d1 ("ethdev: VMDQ enhancements") Can you please add the above line as part of comment? Thanks, Steve On 1/19/17, 10:47 AM, "Steve Shin (jonshin)" wrote: This patch fixes a

[dpdk-dev] [PATCH] lib/librte_ether: error handling on MAC address replay

2017-01-19 Thread Steve Shin
This patch fixes a bug in replaying MAC address to the hardware in rte_eth_dev_config_restore() routine. Signed-off-by: Steve Shin --- lib/librte_ether/rte_ethdev.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether

Re: [dpdk-dev] replay MAC address in rte_eth_dev_config_restore()

2017-01-18 Thread Steve Shin (jonshin)
Thanks Ferruh for your quick turnaround! Sure, I’ll send a patch for your review. Regards, Steve On 1/18/17, 10:39 AM, "Ferruh Yigit" wrote: On 1/18/2017 4:12 AM, Steve Shin (jonshin) wrote: > Hi, > > I have a question on MAC addr

[dpdk-dev] replay MAC address in rte_eth_dev_config_restore()

2017-01-17 Thread Steve Shin (jonshin)
Hi, I have a question on MAC address replay logic in rte_eth_dev_config_restore(): lib/librte_ether/rte_ethdev.c: code snippet of rte_eth_dev_config_restore() ~~ /* replay MAC address configuration */ for (i = 0; i < dev_info.max_mac_addrs; i++) { addr = dev->data-