Re: [dpdk-dev] [PATCH v2] eal: use c11 atomic built-ins for interrupt status

2020-07-09 Thread Stefan Puiu
Hi, Noticed 2 typos: On Thu, Jul 9, 2020 at 9:46 AM Phil Yang wrote: > > The event status is defined as a volatile variable and shared between > threads. Use c11 atomic built-ins with explicit ordering instead of > rte_atomic ops which enforce unnecessary barriers on aarch64. > > The event statu

Re: [dpdk-dev] Use rte_malloc in application

2017-08-03 Thread Stefan Puiu
Hi, This is not strictly DPDK-related, but still... On Thu, Aug 3, 2017 at 9:12 AM, Rohit Saini (Stellus) wrote: > With below code, I am getting this warning. > > warning: cast to pointer from integer of different size > [-Wint-to-pointer-cast] > > my_node_t *data_ptr = (my_node_t *) rte_malloc

[dpdk-dev] [PATCH v4] vmxnet3: fix Rx deadlock

2016-12-19 Thread Stefan Puiu
nd it was causing weird issues in our app. Also, reusing rxm without checking if it's NULL could cause the code to crash. Signed-off-by: Stefan Puiu --- v4: * no change, just added sign-off v3: * rework description after review, explain how HW signals receipt of packets v2: * address revi

[dpdk-dev] [PATCH v3] vmxnet3: fix Rx deadlock

2016-12-16 Thread Stefan Puiu
Our use case is that we have an app that needs to keep mbufs around for a while. We've seen cases when calling vmxnet3_post_rx_bufs() from vmxet3_recv_pkts(), it might not succeed to add any mbufs to any RX descriptors (where it returns -err). Since there are no mbufs that the virtual hardware can

Re: [dpdk-dev] [PATCH] vmxnet3: fix Rx deadlock

2016-12-12 Thread Stefan Puiu
Hello and thanks for reviewing the patch. On Wed, Nov 30, 2016 at 6:59 AM, Yong Wang wrote: [...] > I think a more accurate description is that the particular descriptor's > generation bit never got flipped properly when an mbuf failed to be refilled > which caused the rx stuck, rather than vmx

[dpdk-dev] [PATCH v2] vmxnet3: fix Rx deadlock

2016-12-12 Thread Stefan Puiu
Our use case is that we have an app that needs to keep mbufs around for a while. We've seen cases when calling vmxnet3_post_rx_bufs() from vmxet3_recv_pkts(), it might not succeed to add any mbufs to any RX descriptors (where it returns -err). Since there are no mbufs that the virtual hardware can

[dpdk-dev] [PATCH] vmxnet3: fix Rx deadlock

2016-11-14 Thread Stefan Puiu
27;s NULL could cause the code to crash. Signed-off-by: Stefan Puiu --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 38 -- 1 file changed, 36 insertions(+), 2 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c index

[dpdk-dev] [PATCH] vmxnet3: fix Rx deadlock

2016-11-14 Thread Stefan Puiu
Our use case is that we have an app that needs to keep mbufs around for a while. We've seen cases when calling vmxnet3_post_rx_bufs() from vmxet3_recv_pkts(), it might not succeed to add any mbufs to any RX descriptors (where it returns -err). Since there are no mbufs that the virtual hardware can

[dpdk-dev] including rte.app.mk from a Makefile.am

2016-02-24 Thread Stefan Puiu
On Wed, Feb 24, 2016 at 3:26 AM, Thomas Monjalon wrote: > Yes it is prefixed when used instead of assignment. > In 2.2, it is better fixed: > > ifeq ($(LINK_USING_CC),1) > override EXTRA_LDFLAGS := $(call linkerprefix,$(EXTRA_LDFLAGS)) > O_TO_EXE = $(CC) $(CFLAGS) $(LDFLAGS_$(@)) \ > -Wl,-Map

[dpdk-dev] including rte.app.mk from a Makefile.am

2016-02-23 Thread Stefan Puiu
Hi, I'm working on a Linux project that uses the DPDK and (unfornately, IMO) automake; so we have a Makefile.am where we include rte.extapp.mk and rte.vars.mk from the DPDK, add LDLIBS to the linker However, I've tried building against DPDK 2.2 and I'm getting linker errors about options like '--

[dpdk-dev] [PATCH v2 1/4] mk: Remove combined library and related options

2015-03-18 Thread Stefan Puiu
Hi, On Wed, Mar 18, 2015 at 2:59 PM, Thomas Monjalon wrote: > Hi Sergio, > > Thank you for explaining the situation. > > 2015-03-18 12:11, Gonzalez Monroy, Sergio: >> Given that the patch to remove combined libraries is not welcome, I'll >> try to explain the current situation so we can agree on

[dpdk-dev] [PATCH v2 1/4] mk: Remove combined library and related options

2015-03-13 Thread Stefan Puiu
Hi, 2 cents from a DPDK library user - I make 2 changes to the default linux+gcc configuration: combine libraries and build shared libraries (since I want 2 instances of the app, it didn't make sense to me to link statically). I tried working with the individual libs, but adding all of them with -

[dpdk-dev] [PATCH 2/2] Headers: more C++11 compilation fixes

2015-02-20 Thread Stefan Puiu
Fixed two more places where non-C++11 string concatenation is used. Spotted by John McNamara. Signed-off-by: Stefan Puiu --- lib/librte_mempool/rte_mempool.h |8 lib/librte_vhost/vhost-net-cdev.h |4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lib

[dpdk-dev] [PATCH 1/2] rte_pci.h: Fix C++11 compilation

2015-02-20 Thread Stefan Puiu
From: Stefan Puiu In C++11 concatenated string literals need to have a space in between. Found with clang++-3.4, IIRC g++-4.8 also complains about this. Sample error message: dpdk/include/rte_pci.h:96:26: error: invalid suffix on literal; C++11 requires a space between literal and

[dpdk-dev] [PATCH 1/2] rte_pci.h: Fix C++11 compilation

2015-02-20 Thread Stefan Puiu
-defined-literal] Signed-off-by: Stefan Puiu --- lib/librte_eal/common/include/rte_pci.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/common/include/rte_pci.h b/lib/librte_eal/common/include/rte_pci.h index 66ed793..12ae5a7 100644 --- a/lib/librte_eal

[dpdk-dev] [PATCH] Minor C++11 compilation fix for rte_pci.h

2015-02-20 Thread Stefan Puiu
;> To: Mcnamara, John >> Cc: Stefan Puiu; dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] Minor C++11 compilation fix for rte_pci.h >> >> > > >> > > In C++11 concatenated string literals need to have a space in between. >> > > clang 3.

[dpdk-dev] [PATCH] rte_pci.h: Fix C++11 compilation

2015-02-20 Thread Stefan Puiu
first one?) > > Please check http://dpdk.org/dev#send for versioning and set the old versions > to "superseded" in patchwork. > Thanks > > > 2015-02-20 11:35, Stefan Puiu: >> In C++11 concatenated string literals need to have a >> space in between. Found wit

[dpdk-dev] [PATCH] rte_pci.h: Fix C++11 compilation

2015-02-20 Thread Stefan Puiu
-defined-literal] Signed-off-by: Stefan Puiu --- lib/librte_eal/common/include/rte_pci.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/common/include/rte_pci.h b/lib/librte_eal/common/include/rte_pci.h index 66ed793..12ae5a7 100644 --- a/lib/librte_eal

[dpdk-dev] [PATCH] Fix compilation error when compiling with clang-3.4 in C++11 mode: in C++11 concatenated string literals need to have a space in between.

2015-02-20 Thread Stefan Puiu
Hi Pablo, On Fri, Feb 20, 2015 at 10:19 AM, De Lara Guarch, Pablo wrote: > Hi Stefan, > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stefan Puiu >> Sent: Thursday, February 19, 2015 8:59 PM >> To: dev at dpdk.org >&g

[dpdk-dev] [PATCH] Fix compilation error when compiling with clang-3.4 in C++11 mode: in C++11 concatenated string literals need to have a space in between.

2015-02-19 Thread Stefan Puiu
From: Stefan Puiu Sample error message: dpdk/include/rte_pci.h:96:26: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal] --- lib/librte_eal/common/include/rte_pci.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[dpdk-dev] [PATCH] Fix C++11 compilation error with rte_pci.h

2015-02-19 Thread Stefan Puiu
] Signed-off-by: Stefan Puiu --- lib/librte_eal/common/include/rte_pci.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/common/include/rte_pci.h b/lib/librte_eal/common/include/rte_pci.h index 66ed793..12ae5a7 100644 --- a/lib/librte_eal/common/include

[dpdk-dev] [PATCH] Minor C++11 compilation fix for rte_pci.h

2015-02-11 Thread Stefan Puiu
: Stefan Puiu --- lib/librte_eal/common/include/rte_pci.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/common/include/rte_pci.h b/lib/librte_eal/common/include/rte_pci.h index 66ed793..12ae5a7 100644 --- a/lib/librte_eal/common/include/rte_pci.h +++ b

[dpdk-dev] upper limit on the size of allocation through rte_malloc in dpdk-1.8.0?

2015-02-10 Thread Stefan Puiu
Hi and thanks for replying, On Fri, Feb 6, 2015 at 1:25 PM, Olivier MATZ wrote: > Hi, > > On 02/06/2015 12:00 PM, Bruce Richardson wrote: >> On Wed, Feb 04, 2015 at 05:24:58PM +0200, Stefan Puiu wrote: >>> Hi, >>> >>> I'm trying to alter an existi

[dpdk-dev] upper limit on the size of allocation through rte_malloc in dpdk-1.8.0?

2015-02-04 Thread Stefan Puiu
Hi, I'm trying to alter an existing program to use the Intel DPDK. I'm using 1.8.0, compiled by me as a shared library (CONFIG_RTE_BUILD_COMBINE_LIBS=y and CONFIG_RTE_BUILD_SHARED_LIB=y in .config) on Ubuntu 12.04. The program needs to allocate large blocks of memory (between 1 and 4 chunks of 4.5