}
> - rte_memcpy(((uint8_t *)&tenant_id_be + 1),
> - nvgre_spec->tni, 3);
> + memcpy(((uint8_t *)&tenant_id_be + 1),
> + nvgre_spec->tni, 3);
> filter->vni =
> rte_be_to_cpu_32(tenant_id_be);
> filter->tunnel_type =
> --
> 2.43.0
>
Acked-by: Somnath Kotur
smime.p7s
Description: S/MIME Cryptographic Signature
RTE_LOG_DP(ERR, PMD,
> - "Unhandled CMP type %02x\n",
> - CMP_TYPE(txcmp));
> + PMD_DRV_LOG_DP(ERR, "Unhandled CMP type %02x\n",
> CMP_TYPE(txcmp));
> raw_cons = NEXT_RAW_CMP(raw_cons);
> } while (nb_tx_pkts < ring_mask);
>
> --
> 2.42.0
>
Acked-by: Somnath Kotur
smime.p7s
Description: S/MIME Cryptographic Signature
resource subtype and session id are passed in.
> * An identifier (previously allocated) corresponding to all these is
> - * freed, only after various sanity checks are completed.
> + * freed, only after various checks are completed.
> */
> /* hwrm_tfc_ident_free_input (size:192b/2
e_ether_addr eth_addr;
> @@ -399,8 +399,8 @@ parse_fup(struct ptpv2_data_slave_ordinary *ptp_data)
> eth_hdr = rte_pktmbuf_mtod(m, struct rte_ether_hdr *);
> ptp_hdr = (struct ptp_header *)(rte_pktmbuf_mtod(m, char *)
> + sizeof(struct rte_et
On Tue, Feb 28, 2023 at 2:30 PM Vita Batrla wrote:
>
> Hi all,
>
> I don't know where to report this nit. It's not a real bug and I don't want
> to even send a patch for it. I'm looking if someone could just fix it in
> the source code. Here's the problem:
>
> drivers/net/bnxt/bnxt_hwrm.c
>
>
rte_unused)
>
> rte_eth_copy_pci_info(eth_dev, pci_dev);
> eth_dev->data->dev_flags |= RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS;
> + eth_dev->data->dev_flags |= RTE_ETH_DEV_INTR_LSC;
>
> bp = eth_dev->data->dev_private;
>
> --
> 2.35.0.4.g44a5d4affccf
>
Acked-by: Somnath Kotur
smime.p7s
Description: S/MIME Cryptographic Signature
inimum size of RX buffer: 1
>> Maximum configurable length of RX packet: 9600
>> Maximum configurable size of LRO aggregated packet: 0
>> Maximum number of VMDq pools: 64
>> Current number of RX queues: 2
>> Max possible RX queues: 117
>> Max possible number of R
On Thu, Jan 19, 2023 at 7:07 PM Edwin Brossette
wrote:
>
> Hello,
>
Hi Edwin,
Thanks for reaching out, here's my attempt at answering your questions
> I am trying to operate a Broadcom BCM57414 2x10G nic using dpdk bnxt pmd. I
> use DPDK 22.11.
> However, doing so I stumbled over a number of dif
led_on)
> uint16_t duration = 0;
> int rc, i;
>
> - if (!bp->leds->num_leds || BNXT_VF(bp))
> + if (BNXT_VF(bp) || !bp->leds || !bp->leds->num_leds)
> return -EOPNOTSUPP;
>
> HWRM_PREP(&req, HWRM_PORT_LED_CFG, BNXT_USE_CHIMP_MB);
> --
> 1.8.3.1
>
Acked-by: Somnath Kotur
smime.p7s
Description: S/MIME Cryptographic Signature
On Tue, Aug 2, 2022 at 9:17 AM Mao YingMing wrote:
>
> For VFs, bp->leds is uninitialized, check bp->leds is
> not null before use bp->leds->num_leds.
Sorry for missing this the first time around, Rephrase it to say
'before checking for bp->leds->num_leds'
> segfault backtrace in trex program when
On Tue, Aug 2, 2022 at 8:33 AM Mao YingMing wrote:
>
Thanks for the patch
> From: maoyingming
>
> VFs's "bp->leds" is allways null, check bp->leds is
> not null before use bp->leds->num_leds.
Typo in 'always'
You can just say ' For VFs , bp->leds is uninitialized'
>
> segfault backtrace in trex p
On Thu, Nov 25, 2021 at 5:23 PM Ferruh Yigit wrote:
>
> On 11/24/2021 3:37 PM, Viacheslav Ovsiienko wrote:
> > The generic RTE_FLOW_ACTION_TYPE_MODIFY_FIELD action was
> > introduced by [1]. This action provides an unified way
> > to perform various arithmetic and transfer operations over
> > pack
- a/lib/ip_frag/rte_ipv6_fragmentation.c
> +++ b/lib/ip_frag/rte_ipv6_fragmentation.c
> @@ -90,7 +90,7 @@ rte_ipv6_fragment_packet(struct rte_mbuf *pkt_in,
>
> /*
> * Ensure the IP payload length of all fragments (except the
> -* the last fragment) are a multiple of 8 bytes per RFC2460.
> +* last fragment) are a multiple of 8 bytes per RFC2460.
> */
>
> frag_size = mtu_size - sizeof(struct rte_ipv6_hdr) -
> diff --git a/lib/rawdev/rte_rawdev_pmd.h b/lib/rawdev/rte_rawdev_pmd.h
> index b1bed13ee2..3b7be57d3e 100644
> --- a/lib/rawdev/rte_rawdev_pmd.h
> +++ b/lib/rawdev/rte_rawdev_pmd.h
> @@ -126,7 +126,7 @@ rte_rawdev_pmd_is_valid_dev(uint8_t dev_id)
> }
>
> /**
> - * Definitions of all functions exported by a driver through the
> + * Definitions of all functions exported by a driver through
> * the generic structure of type *rawdev_ops* supplied in the
> * *rte_rawdev* structure associated with a device.
> */
> --
> 2.25.1
>
Acked-by: Somnath Kotur
uot;)
Signed-off-by: Somnath Kotur
Reviewed-by: Kalesh AP
---
drivers/net/bnxt/bnxt_ethdev.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index c1bdf9a921..f79f33ab4e 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++
ummy ones set by bnxt_stop_rxtx() leading to crashes
in the data path (e.g. dereferencing freed structures)
Fix the segfault by updating the fast-path pointer as well
Fixes: c87d435a4d79 ("ethdev: copy fast-path API into separate structure")
Signed-off-by: Somnath Kotur
Rev
alid settings being retrieved and configured in subsequent
application loads resulting in launch failures.
Fixes: c23f9ded0391 ("net/bnxt: support 200G PAM4 link")
Reported-by: Charlie Brtee
Reviewed-by: Ajit Khaparde
Signed-off-by: Somnath Kotur
---
drivers/net/bnxt/bnxt_hwrm.c |
testpmd
Fixes: 03c8f2fe111c ("net/bnxt: detect bad opaque in Rx completion")
Cc: sta...@dpdk.org
Signed-off-by: Somnath Kotur
Signed-off-by: Ajit Khaparde
Reviewed-by: Ajit Khaparde
Reviewed-by: Kalesh Anakkur Purayil
---
drivers/net/bnxt/bnxt_rxr.c | 2 +-
1 file changed, 1 inser
/tf_ulp/ulp_utils.c
> > index df3afaa6fd..c60d81d14a 100644
> > --- a/drivers/net/bnxt/tf_ulp/ulp_utils.c
> > +++ b/drivers/net/bnxt/tf_ulp/ulp_utils.c
> > @@ -200,7 +200,6 @@ ulp_bs_push_msb(uint8_t *bs, uint16_t pos, uint8_t len,
> > uint8_t *val)
> > {
> > int i;
> > int cnt = (len + 7) / 8;
> > - int tlen = len;
> >
> > /* Handle any remainder bits */
> > int tmp = len % 8;
> > @@ -211,12 +210,10 @@ ulp_bs_push_msb(uint8_t *bs, uint16_t pos, uint8_t
> > len, uint8_t *val)
> > ulp_bs_put_msb(bs, pos, tmp, val[0]);
> >
> > pos += tmp;
> > - tlen -= tmp;
> >
> > for (i = 1; i < cnt; i++) {
> > ulp_bs_put_msb(bs, pos, 8, val[i]);
> > pos += 8;
> > - tlen -= 8;
> > }
> >
> > return len;
>
> Review please.
Acked-by: Somnath Kotur
>
>
> --
> David Marchand
>
; Syntax fixed on lines that this patch touches.
> >
> > Signed-off-by: Ferruh Yigit
> > Acked-by: Tyler Retzlaff
> > Acked-by: Andrew Rybchenko
> > Acked-by: Ajit Khaparde
> > Acked-by: Jerin Jacob
> > Acked-by: Wisam Jaddo
> > Acked-by: Rosen Xu
> > Acked-by: Chenbo Xia
> > Acked-by: Hemant Agrawal
>
Acked-by: Somnath Kotur
somnath.ko...@broadcom.com
>
>
> Suggested-by: Ferruh Yigit
> > Signed-off-by: Dmitry Kozlyuk
> Acked-by: Ajit Khaparde
>
Acked-by: Somnath Kotur
>
ame. The old flags remain usable, but a deprecation warning is issued
> > > at compilation.
> > >
> > > Signed-off-by: Olivier Matz
> >
> > Acked-by: Andrew Rybchenko
>
> Acked-by: Ajit Khaparde
> >
Acked-by: Somnath Kotur
ecause David pointed me that these flags are still used by
> other projects. Adding an explicit RTE_DEPRECATED() would prevent this,
> and... it doesn't bother to add one more year :)
>
> Thank you for the review.
Acked-by Somnath Kotur
.
> *
> diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map
> index efd729c0f2..c516837723 100644
> --- a/lib/ethdev/version.map
> +++ b/lib/ethdev/version.map
> @@ -245,6 +245,9 @@ EXPERIMENTAL {
> rte_mtr_meter_policy_delete;
> rte_mtr_meter_policy_update;
> rte_mtr_meter_policy_validate;
> +
> + # added in 21.11
> + rte_eth_dev_conf_get;
> };
>
> INTERNAL {
> --
Acked-by: Somnath kotur
> 2.25.1
>
tnic_flow.c
> b/drivers/net/softnic/rte_eth_softnic_flow.c
> index 27eaf380cd..39038d26d8 100644
> --- a/drivers/net/softnic/rte_eth_softnic_flow.c
> +++ b/drivers/net/softnic/rte_eth_softnic_flow.c
> @@ -1448,13 +1448,6 @@ flow_rule_action_get(struct pmd_internals *softnic,
> action,
> "COUNT: Null configuration");
>
> - if (conf->shared)
> - return rte_flow_error_set(error,
> - ENOTSUP,
> - RTE_FLOW_ERROR_TYPE_ACTION_CONF,
> - conf,
> - "COUNT: Shared counters not
> supported");
> -
> if (n_count)
> return rte_flow_error_set(error,
> ENOTSUP,
> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h
> index 7b1ed7f110..5306e8ca4b 100644
> --- a/lib/ethdev/rte_flow.h
> +++ b/lib/ethdev/rte_flow.h
> @@ -75,7 +75,7 @@ extern "C" {
> * At least one direction must be specified.
> *
> * Specifying both directions at once for a given rule is not recommended
> - * but may be valid in a few cases (e.g. shared counter).
> + * but may be valid in a few cases.
> */
> struct rte_flow_attr {
> uint32_t group; /**< Priority group. */
> @@ -2498,24 +2498,11 @@ struct rte_flow_query_age {
> * Counters can be retrieved and reset through ``rte_flow_query()``, see
> * ``struct rte_flow_query_count``.
> *
> - * @deprecated Shared attribute is deprecated, use generic
> - * RTE_FLOW_ACTION_TYPE_INDIRECT action.
> - *
> - * The shared flag indicates whether the counter is unique to the flow rule
> the
> - * action is specified with, or whether it is a shared counter.
> - *
> - * For a count action with the shared flag set, then then a global device
> - * namespace is assumed for the counter id, so that any matched flow rules
> using
> - * a count action with the same counter id on the same port will contribute
> to
> - * that counter.
> - *
> * For ports within the same switch domain then the counter id namespace
> extends
> * to all ports within that switch domain.
> */
> struct rte_flow_action_count {
> - /** @deprecated Share counter ID with other flow rules. */
> - uint32_t shared:1;
> - uint32_t reserved:31; /**< Reserved, must be zero. */
> + uint32_t reserved; /**< Reserved, must be zero. */
> uint32_t id; /**< Counter ID. */
> };
>
> --
> 2.30.2
>
Acked-by: Somnath Kotur
mandatory, because flow API does not supply users with
> > capabilities, so
> > this is the only way for a user to learn that configuration is invalid. For
> > example, if queue count changes and the action of a flow rule specifies
> > queues
> > that are going away
Rx/Tx size limitation,
> > Rx buffer is where to store Rx packets, many PMDs use mbuf data buffer
> > size as Rx buffer size.
> > PMDs compare MTU against Rx buffer size to decide enabling scattered Rx
> > or not. If scattered Rx is not supported by device, MTU bigger than Rx
> > buffer size should fail.
> >
> > Signed-off-by: Ferruh Yigit
> > ---
> > Cc: Min Hu (Connor)
> >
> > v2:
> > * Converted to explicit checks for zero/non-zero
> > * fixed hns3 checks
> > * fixed some sample app rxmode.mtu value
> > * fixed some sample app max-pkt-len argument and updated doc for it
> >
> > v3:
> > * rebased
> >
> > v4:
> > * fix typos in commit logs
>
> That's a lot of detail in the log. Thanks
>
> Acked-by: Ajit Khaparde
Acked-by: Somnath Kotur
7;s ability to deliver received metadata to the user
> > by virtue of mbuf fields should be covered by mbuf library.
> > It is also out of scope of the new API in question.
> >
> > Signed-off-by: Ivan Malov
> > Reviewed-by: Andrew Rybchenko
> > Reviewed-by: Andy Moreton
> > Acked-by: Ray Kinsella
> > Acked-by: Jerin Jacob
>
> Acked-by: Ajit Khaparde
Acked-by: Somnath Kotur
On Mon, Oct 4, 2021 at 10:42 AM Somnath Kotur
wrote:
>
> On Fri, Oct 1, 2021 at 8:07 PM Ferruh Yigit wrote:
> >
> > Removing 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag.
> >
> > Instead of drivers announce this capability, application can deduct
net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -3025,7 +3025,7 @@ int bnxt_mtu_set_op(struct rte_eth_dev *eth_dev,
> uint16_t new_mtu)
> uint32_t overhead = BNXT_MAX_PKT_LEN - BNXT_MAX_MTU;
> struct bnxt *bp = eth_dev->data->dev_private;
>
}
>
> - if (new_mtu > RTE_ETHER_MTU) {
> + if (new_mtu > RTE_ETHER_MTU)
> bp->flags |= BNXT_FLAG_JUMBO;
> - bp->eth_dev->data->dev_conf.rxmode.offloads |=
> - DEV_RX_OFFLOAD_JUMBO_FRAME;
> - } else {
> -
.@dpdk.org
Signed-off-by: Somnath Kotur
Reviewed-by: Kalesh AP
Reviewed-by: Ajit Khaparde
---
v4: Updated commit log as requested by Ferruh
v3: Updated commit log and summary as requested by Ferruh
v2: Updated commit log as requested by Ferruh
drivers/net/bnxt/bnxt_rxr.c | 3 +++
1 file changed, 3
.@dpdk.org
Signed-off-by: Somnath Kotur
Reviewed-by: Kalesh AP
Reviewed-by: Ajit Khaparde
---
v4: Updated commit log as requested by Ferruh
v3: Updated commit log and summary as requested by Ferruh
v2: Updated commit log as requested by Ferruh
drivers/net/bnxt/bnxt_rxr.c | 3 +++
1 file changed, 3
point to a stale value.
Fixes: 03c8f2fe111c ("net/bnxt: detect bad opaque in Rx completion")
Cc: sta...@dpdk.org
Signed-off-by: Somnath Kotur
Reviewed-by: Kalesh AP
Reviewed-by: Ajit Khaparde
---
v3: Updated commit log and summary as requested by Ferruh
drivers/net/bnxt/bnxt_rxr.c
Thank you Ferruh, have sent V2 with updated commit log, please see if it
sounds good now?
-Som
On Fri, Aug 20, 2021 at 6:17 PM Ferruh Yigit wrote:
> On 8/10/2021 7:07 AM, Somnath Kotur wrote:
> > In bnxt_init_one_rx_ring(), reset this variable internal to the driver
> > rin
variable would still point to a stale value.
Fixes: 03c8f2fe111c ("net/bnxt: detect bad opaque in Rx completion")
Cc: sta...@dpdk.org
Signed-off-by: Somnath Kotur
Reviewed-by: Kalesh AP
Reviewed-by: Ajit Khaparde
---
v2: Updated commit log as requested by Ferruh
drivers/net/bnxt/bnxt
In bnxt_init_one_rx_ring(), reset this variable internal to the driver
ring to 0, so that there is no mismatch with actual value in HW on
traffic resumption.
Fixes: 03c8f2fe111c ("net/bnxt: detect bad opaque in Rx completion")
Cc: sta...@dpdk.org
Signed-off-by: Somnath Kotur
Reviewed-
post
accounting for the spurious zero stat value.
Signed-off-by: Somnath Kotur
Reviewed-by: Lance Richardson
Reviewed-by: Kalesh AP
---
v2:
- Sum counters across ALL rings for function stats instead of the ones
reported for
- Allocate/free the previous ring stats(Rx/Tx) in dev_start
Hi Owen,
Thank you for the heads up. I still could not figure out how
to reproduce this though, i did not run into any issue on my end and i
tried launching testpmd with similar cmdline parameters as specified here
in the log(TestNicSingleCorePerf) , but no luck
In any case, looks lik
post
accounting for the spurious zero stat value.
Signed-off-by: Somnath Kotur
Reviewed-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt.h| 45 +++
drivers/net/bnxt/bnxt_ethdev.c | 14
drivers/net/bnxt/bnxt_hwrm.c | 106 +
drivers/net/bnxt/bnxt_h
the next one.
Signed-off-by: Somnath Kotur
Reviewed-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt_hwrm.c | 19 +++
drivers/net/bnxt/bnxt_hwrm.h | 1 +
drivers/net/bnxt/bnxt_rxq.h | 1 +
drivers/net/bnxt/bnxt_rxr.c | 101 ++-
drivers/net/bnxt/bnxt_rxr.h
t;net/bnxt: add Rx queue create/destroy")
Signed-off-by: Somnath Kotur
Reviewed-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt_rxq.c | 30 --
1 file changed, 30 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c
index 2b0d3d4ac7..
Fix to clear the Rx FIFO while reading the timestamp.
If the Rx FIFO has pending bit set, keep reading to clear it
and return the last valid timestamp instead of unconditionally
returning an error.
Fixes: b11cceb83a34 ("net/bnxt: support timesync")
Cc: sta...@dpdk.org
Signed-off-b
Reviewed-by: Kalesh Anakkur Purayil
Reviewed-by: Lance Richardson
Reviewed-by: Ajit Kumar Khaparde
Signed-off-by: Somnath Kotur
---
drivers/net/bnxt/bnxt_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index
he actual stats populated by the driver.
Fixes: 063e59ddd28 ("net/bnxt: fix crash in xstats get")
Cc: sta...@dpdk.org
Reviewed-by: Kalesh Anakkur Purayil
Reviewed-by: Lance Richardson
Signed-off-by: Somnath Kotur
---
drivers/net/bnxt/bnxt_stats.c | 23 +--
1 file cha
Please apply the following fixes
Somnath Kotur (2):
net/bnxt: fix to return count in xstats get op in all cases
net/bnxt: fix Rx and Tx timestamp assignment
drivers/net/bnxt/bnxt_ethdev.c | 4
drivers/net/bnxt/bnxt_stats.c | 23 +--
2 files changed, 13 insertions
timesync adjust and write_time APIs needed to account for the Rx and Tx
timestamp counters as well. Fix it since it was not done earlier.
Fixes: b11cceb83a3 ("net/bnxt: support timesync")
Cc: sta...@dpdk.org
Reviewed-by: Lance Richardson
Reviewed-by: Ajit Kumar Khaparde
Signed-off-b
bnxt_alloc_hwrm_rings() was duplicating a snippet of code that was
already present in bnxt_alloc_hwrm_rx_ring() with just one line/function
invocation missing. Add that line and replace the snippet of code
with a call to bnxt_hwrm_alloc_rx_ring
Signed-off-by: Somnath Kotur
---
drivers/net/bnxt
err_recovery_lock needs to be released before returning in
stop and close_op if FW_RESET flag is set.
Fixes: 647ca0b35830 ("net/bnxt: check chip reset in dev stop and close")
Signed-off-by: Somnath Kotur
---
drivers/net/bnxt/bnxt_ethdev.c | 2 ++
1 file changed, 2 insertions(+)
di
On Thu, Jan 7, 2021 at 12:08 PM Xueming(Steven) Li wrote:
>
>
>
> >-Original Message-
> >From: Somnath Kotur
> >Sent: Thursday, January 7, 2021 2:32 PM
> >To: Xueming(Steven) Li
> >Cc: NBU-Contact-Thomas Monjalon ; Ferruh Yigit
> >;
On Wed, Jan 6, 2021 at 9:48 PM Xueming Li wrote:
>
> To support extended representor syntax, this patch refactor represntor
Typo in 'representor'
> infrastructure:
> 1. introduces representor type enum
> 2. devargs representor port range extraction from partial value
>
> Signed-off-by: Xueming Li
confusion with some of the other
bnxt_init_xxx routines.
Rename bnxt_init_fw() to bnxt_get_config() as that is what that routine
is doing mostly functionality wise.
Cc: sta...@dpdk.org
Signed-off-by: Somnath Kotur
---
drivers/net/bnxt/bnxt_ethdev.c | 150 +++--
1 file c
Call bnxt_dev_stop in error path of bnxt_dev_start_op() to keep
it simple and consistent
Fixes: c09f57b49c13 ("net/bnxt: add start/stop/link update operations")
Signed-off-by: Somnath Kotur
---
drivers/net/bnxt/bnxt_ethdev.c | 144 -
1 file c
adapter is in the middle of recovery when dev_stop
or dev_close ops are invoked
Signed-off-by: Somnath Kotur
---
drivers/net/bnxt/bnxt.h| 5
drivers/net/bnxt/bnxt_cpr.c| 2 ++
drivers/net/bnxt/bnxt_ethdev.c | 49 +-
3 files changed, 49 insertions
the driver.
Fixes: 1cb3d39a48f7 ("net/bnxt: synchronize between flow related functions")
Signed-off-by: Somnath Kotur
---
drivers/net/bnxt/bnxt_ethdev.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_
A couple of bnxt PMD fixes and an enhancement
Somnath Kotur (3):
net/bnxt: fix to init/destroy locks only once
net/bnxt: fix error path handling of dev start op
net/bnxt: check for chip reset in dev stop/close ops
drivers/net/bnxt/bnxt.h| 5 +
drivers/net/bnxt/bnxt_cpr.c
Call bnxt_dev_stop in error path of bnxt_dev_start_op() to keep
it simple and consistent
Fixes: c09f57b49c13 ("net/bnxt: add start/stop/link update operations")
Signed-off-by: Somnath Kotur
---
drivers/net/bnxt/bnxt_ethdev.c | 144 -
1 file c
the driver.
Fixes: 1cb3d39a48f7 ("net/bnxt: synchronize between flow related functions")
Signed-off-by: Somnath Kotur
---
drivers/net/bnxt/bnxt_ethdev.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_
A couple of bnxt PMD fixes and an enhancement
Somnath Kotur (3):
net/bnxt: fix to init/destroy locks only once
net/bnxt: fix error path handling of dev start op
net/bnxt: check for chip reset in dev stop/close ops
drivers/net/bnxt/bnxt.h| 5 +
drivers/net/bnxt/bnxt_cpr.c
adapter is in the middle of recovery when dev_stop
or dev_close ops are invoked
Signed-off-by: Somnath Kotur
---
drivers/net/bnxt/bnxt.h| 5
drivers/net/bnxt/bnxt_cpr.c| 2 ++
drivers/net/bnxt/bnxt_ethdev.c | 49 +-
3 files changed, 49 insertions
Call bnxt_dev_stop in error path of bnxt_dev_start_op() to keep
it simple and consistent
Fixes: c09f57b49c13 ("net/bnxt: add start/stop/link update operations")
Cc: sta...@dpdk.org
Signed-off-by: Somnath Kotur
---
drivers/net/bnxt/bnxt_ethdev.c | 144 ---
adapter is in the middle of recovery when dev_stop
or dev_close ops are invoked
Signed-off-by: Somnath Kotur
---
drivers/net/bnxt/bnxt.h| 5
drivers/net/bnxt/bnxt_cpr.c| 2 ++
drivers/net/bnxt/bnxt_ethdev.c | 49 +-
3 files changed, 49 insertions
the driver.
Fixes: 1cb3d39a48f7 ("net/bnxt: synchronize between flow related functions")
Cc: sta...@dpdk.org
Signed-off-by: Somnath Kotur
---
drivers/net/bnxt/bnxt_ethdev.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/driver
Some fixes and enchancements in the core bnxt PMD
Somnath Kotur (3):
net/bnxt: fix to init/destroy locks only once
net/bnxt: fix error path handling of dev start op
net/bnxt: check for chip reset in dev stop/close ops
drivers/net/bnxt/bnxt.h| 5 +
drivers/net/bnxt/bnxt_cpr.c
APs or any other cmd in dev_configure_op()
as that would just override the actual max values obtained above.
Fixes: f8168ca0e69 ("net/bnxt: support thor controller")
Cc: sta...@dpdk.org
Signed-off-by: Somnath Kotur
---
drivers/net/bnxt/bnxt_ethdev.c | 7 ---
drivers/net/bnx
Pass 'eth_da' pointer instead of pass by value to
bnxt_rep_port_probe()
Coverity issue: 360841
Fixes: 322bd6e70272 ("net/bnxt: add port representor infrastructure")
Cc: sta...@dpdk.org
Signed-off-by: Somnath Kotur
Reviewed-by: Kalesh Anakkur Purayil
---
drivers/net/bnx
Check and log an error message if switch domain free API fails
Coverity issue: 362757
Fixes: 322bd6e70272 ("net/bnxt: add port representor infrastructure")
Cc: sta...@dpdk.org
Signed-off-by: Somnath Kotur
Reviewed-by: Kalesh Anakkur Purayil
---
drivers/net/bnxt/bnxt_eth
()
Fixes: 6133f207970c ("net/bnxt: add Rx queue create/destroy")
Fixes: 51c87ebafc7d ("net/bnxt: add Tx queue create/destroy")
Cc: sta...@dpdk.org
Signed-off-by: Somnath Kotur
---
drivers/net/bnxt/bnxt_rxq.c | 44 +++-
drivers/net/
On Fri, Oct 16, 2020 at 1:43 PM Ciara Power wrote:
>
> When choosing a vector path to take, an extra condition must be
> satisfied to ensure the max SIMD bitwidth allows for the CPU enabled
> path.
>
> Cc: Ajit Khaparde
> Cc: Somnath Kotur
>
> Signed-off-by: Ciara P
From: Kishore Padmanabha
Added support in the ulp mapper to enable parent child flow
creation and destroy. This feature enables support for the vxlan
decap functionality
Signed-off-by: Kishore Padmanabha
Reviewed-by: Michael Baucom
---
drivers/net/bnxt/tf_ulp/ulp_flow_db.c | 177
org
Signed-off-by: Venkat Duvvuru
Reviewed-by: Somnath Kotur
---
drivers/net/bnxt/bnxt_cpr.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_cpr.c b/drivers/net/bnxt/bnxt_cpr.c
index 5492394..91d1ffe 100644
--- a/drivers/net/bnxt/bnxt_cpr.c
+++ b/d
From: Mike Baucom
FDB type is now driven by the caller, not the template.
Signed-off-by: Mike Baucom
Reviewed-by: Ajit Kumar Khaparde
Reviewed-by: Kishore Padmanabha
---
.../net/bnxt/tf_ulp/ulp_template_db_stingray_act.c | 18 ++
.../bnxt/tf_ulp/ulp_template_db_stingray_class.c | 69 ++
From: Mike Baucom
Name changes due to consolidating the template table processing.
- chip before type in name
- removal of class in key field info
Signed-off-by: Mike Baucom
Reviewed-by: Ajit Kumar Khaparde
Reviewed-by: Kishore Padmanabha
---
drivers/net/bnxt/tf_ulp/ulp_mapper.c
From: Kishore Padmanabha
Added support for parent child flow database apis. This
feature adds support to enable vxlan decap support where
flows needs to maintain parent-child flow relationship.
Signed-off-by: Kishore Padmanabha
Reviewed-by: Michael Baucom
---
drivers/net/bnxt/tf_ulp/ulp_flow_
From: Kishore Padmanabha
The default and regular flows are stored in the same flow table
instead of different flow tables.
Signed-off-by: Kishore Padmanabha
Reviewed-by: Michael Baucom
Reviewed-by: Ajit Kumar Khaparde
---
drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 2 +-
drivers/net/bnxt/tf_
From: Venkat Duvvuru
Currently, we are only registering to this event if the function
is a trusted VF. This patch extends it for PFs as well.
Fixes: 322bd6e70272 ("net/bnxt: add port representor infrastructure")
Cc: sta...@dpdk.org
Signed-off-by: Venkat Duvvuru
Reviewed-by: Som
Venkat Duvvuru
Reviewed-by: Somnath Kotur
---
drivers/net/bnxt/bnxt.h| 6 +-
drivers/net/bnxt/bnxt_cpr.c| 6 +-
drivers/net/bnxt/bnxt_ethdev.c | 40 +---
drivers/net/bnxt/bnxt_hwrm.c | 458 +
drivers/net/bnxt/bnxt_hwrm.h | 12 +-
5 fil
From: Mike Baucom
The table processing has been consolidated to be able to reuse the same
code for action and classification template processing.
Signed-off-by: Mike Baucom
Reviewed-by: Kishore Padmanabha
---
drivers/net/bnxt/tf_ulp/bnxt_ulp_flow.c| 1 +
drivers/net/bnxt/tf_ulp/
From: Kishore Padmanabha
The session details that is shared among multiple ports
need to be outside the bnxt structure.
Fixes: 70e64b27af5b ("net/bnxt: support ULP session manager cleanup")
Cc: sta...@dpdk.org
Signed-off-by: Kishore Padmanabha
Reviewed-by: Michael Baucom
Reviewed-by: Ajit Kum
Fixes and enchancements in the bnxt PMD, mostly in the
TRUFLOW layer, including templates support for another chip
Kishore Padmanabha (4):
net/bnxt: fix the corruption of the session details
net/bnxt: combine default and regular flows in flow database
net/bnxt: add support for parent child f
On Fri, Sep 25, 2020 at 4:16 PM Somnath Kotur
wrote:
>
> On Fri, Sep 25, 2020 at 2:12 PM Ferruh Yigit wrote:
> >
> > On 9/25/2020 3:04 AM, Somnath Kotur wrote:
> > > On Thu, Sep 24, 2020 at 8:17 PM Ferruh Yigit
> > > wrote:
> > >>
> > >&
Check for num_rep before invoking rep port probe.
Fixes: 6dc83230b43b ("net/bnxt: support port representor data path")
Signed-off-by: Somnath Kotur
Reviewed-by: Venkat Duvvuru
---
v2: Check against num_rep instead of devargs ptr
drivers/net/bnxt/bnxt_ethdev.c | 4
1 file
On Fri, Sep 25, 2020 at 2:12 PM Ferruh Yigit wrote:
>
> On 9/25/2020 3:04 AM, Somnath Kotur wrote:
> > On Thu, Sep 24, 2020 at 8:17 PM Ferruh Yigit wrote:
> >>
> >> On 9/22/2020 8:06 AM, Somnath Kotur wrote:
> >>> Check for devargs before invoking rep p
Check for num_rep before invoking rep port probe.
Fixes: 6dc83230b43b ("net/bnxt: support port representor data path")
Signed-off-by: Somnath Kotur
Reviewed-by: Venkat Duvvuru
---
v2: Check against num_rep instead of devargs ptr
drivers/net/bnxt/bnxt_ethdev.c | 4
1 file
On Thu, Sep 24, 2020 at 8:17 PM Ferruh Yigit wrote:
>
> On 9/22/2020 8:06 AM, Somnath Kotur wrote:
> > Check for devargs before invoking rep port probe.
> >
> > Fixes: 6dc83230b43b ("net/bnxt: support port representor data path")
> >
> > Signed-
From: Kishore Padmanabha
Initialize the global parms structure to avoid seg fault
in the truflow global configuration set api.
Fixes: 0a58be6f7c1e ("net/bnxt: add access to NAT global register")
Signed-off-by: Kishore Padmanabha
Reviewed-by: Michael Baucom
Reviewed-by: Ajit Kumar Khaparde
--
=8,
rep-is-pf=1,rep-q-r2f=1,rep-fc-r2f=0,rep-q-f2r=1,rep-fc-f2r=1
Also, Call CFA_PAIR_ALLOC only in case of Stingray instead of CFA_VFR_ALLOC
Signed-off-by: Somnath Kotur
Reviewed-by: Michael Baucom
Reviewed-by: Venkat Duvvuru
---
drivers/net/bnxt/bnxt.h | 21 +-
drivers/net
From: Kishore Padmanabha
Add a template to support ipv6 VXLAN flows to enable support for
vxlan decap for those flows.
Signed-off-by: Kishore Padmanabha
Reviewed-by: Michael Baucom
---
drivers/net/bnxt/tf_ulp/ulp_template_db_class.c | 1206 +++
drivers/net/bnxt/tf_ulp/ulp_
From: Kishore Padmanabha
The pkt_type field in the profile tcam table needs to be ignored
and should not be set to normal packet type. The pkt_type for the packets
that are segmented due to transmit segment offload feature in the
driver are not marked as normal pkt_type and this shall result in
p
Set the TRUFLOW Enable bit in bp->flags only if the value passed in
devargs was 1.
Fixes: 313ac35ac701 ("net/bnxt: support ULP session manager init")
Signed-off-by: Somnath Kotur
Reviewed-by: Venkat Duvvuru
Reviewed-by: Michael Baucom
Reviewed-by: Ajit Kumar Khaparde
---
dri
Check for devargs before invoking rep port probe.
Fixes: 6dc83230b43b ("net/bnxt: support port representor data path")
Signed-off-by: Somnath Kotur
Reviewed-by: Venkat Duvvuru
---
drivers/net/bnxt/bnxt_ethdev.c | 4
1 file changed, 4 insertions(+)
diff --git a/driver
ring
Signed-off-by: Somnath Kotur
Reviewed-by: Venkat Duvvuru
---
drivers/net/bnxt/bnxt_reps.c | 33 +
1 file changed, 29 insertions(+), 4 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_reps.c b/drivers/net/bnxt/bnxt_reps.c
index 17010f1..d4d0a9e 100644
--- a
or to properly allocate resources for
PF/VF")
Cc: sta...@dpdk.org
Signed-off-by: Somnath Kotur
Reviewed-by: Venkat Duvvuru
Reviewed-by: Ajit Kumar Khaparde
---
drivers/net/bnxt/bnxt_hwrm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/d
Fixes and enchancements in the bnxt PMD, mostly
in the TRUFLOW layer
Kishore Padmanabha (3):
net/bnxt: add support for decap action for ipv6 VXLAN flows
net/bnxt: fix flow match to ignore pkt type
net/bnxt: fix seg fault during NAT configuration
Somnath Kotur (5):
net/bnxt: simplify
: df6cd7c1f73a ("net/bnxt: handle reset notify async event from FW")
Cc: sta...@dpdk.org
Signed-off-by: Kalesh AP
Reviewed-by: Somnath Kotur
---
drivers/net/bnxt/bnxt_ethdev.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/driver
ype
> [-Werror=type-limits]
> for (port_id = 0; port_id < RTE_MAX_ETHPORTS; port_id++) {
> ^
>
> Fixes: 769de16872ab9 ('net/bnxt: fix port default rule create/destroy')
> Cc: Ajit Khaparde
> Cc: Somnath Kotur
>
> Signed-off
id entries instead of active entries as the active entry can be in
any slot in the table.
This is a critical fix for OVS-DPDK flow aging.
Fixes: 306c2d28e247 ("net/bnxt: support count action in flow query")
Reviewed-by: Venkat Duvvuru
Signed-off-by: Somnath Kotur
---
drivers/net/bnxt
From: Shahaji Bhosle
Adjusted resource allocations for the hardware resources
like TCAM entries, action records, stat counters, exact match records to
scale up offload flows.
Also increased ipv4 nat entries to 1023.
This patch is a critical fix to enable driver load on current and all
FW versions
On Thu, Jul 30, 2020 at 8:43 PM Xueming(Steven) Li
wrote:
>
> Hi Som,
>
> > -Original Message-
> > From: Somnath Kotur
> > Sent: Thursday, July 30, 2020 11:10 PM
> > To: Iremonger, Bernard
> > Cc: Xueming(Steven) Li ; Burakov, Anatoly
> >
On Tue, Apr 21, 2020 at 7:11 PM Iremonger, Bernard
wrote:
>
> > -Original Message-
> > From: dev On Behalf Of Xueming Li
> > Sent: Friday, April 17, 2020 9:04 AM
> > To: Burakov, Anatoly ; Yigit, Ferruh
> > ; Stephen Hemminger
> >
> > Cc: dev@dpdk.org; Asaf Penso
> > Subject: [dpdk-dev]
infrastructure")
Signed-off-by: Venkat Duvvuru
Reviewed-by: Somnath Kotur
---
drivers/net/bnxt/bnxt.h| 21 +
drivers/net/bnxt/bnxt_cpr.c| 51 ++
drivers/net/bnxt/bnxt_ethdev.c | 12 +++-
drivers/net/bnxt/bnxt_hwrm.c | 4 +++
1 - 100 of 539 matches
Mail list logo
