Re: [PATCH v2] net/ice: fix link update

2024-01-03 Thread Shuang Han
ice_atomic_write_link_status in ice_link_update function is not protected by the spinlock, there maybe a situation: 1.dev_start call ice_link_update with wait_to_complete = 1,and get link_status = 0 2.LSC interrupt handler call ice_link_update and get link_status = 1 3.LSC interrupt handler call ic

Re: [PATCH] net/ice: fix get link status timeout

2023-02-06 Thread Shuang Han
> -Original Message- > From: Mingjin Ye > Sent: Monday, February 06, 2023 2:23 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; yidingx.z...@intel.com; Mingjin Ye > ; Qiming Yang ; Qi Zhang > > Subject: [PATCH] net/ice: fix get link status timeout > > > When hw is just started, it will immedi

Re: [PATCH] net/ice: fix link status error when dev start

2022-12-12 Thread Shuang Han
I agree. Maybe this is the better solution Zhang, Qi Z 于2022年12月13日周二 09:50写道: > > > > -Original Message- > > From: Shuang Han > > Sent: Wednesday, November 23, 2022 8:42 PM > > To: dev@dpdk.org > > Cc: Yang, Qiming ; Zhang, Qi Z > > ; Shuang H

[PATCH] net/ice: fix link status error when dev start

2022-11-23 Thread Shuang Han
ink to up. After a while the rte_delay_ms(CHECK_INTERVAL) finished and update dev->data->dev_link to down. Signed-off-by: Shuang Han --- drivers/net/ice/ice_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_et