RE: [PATCH v3 1/4] drivers: merge common and net idpf drivers

2025-02-03 Thread Shetty, Praveen
Rather than having some of the idpf code split out into the "common" directory, used by both a net/idpf and a net/cpfl driver, we can merge all idpf code together under net/idpf and have the cpfl driver depend on "net/idpf" rather than "common/idpf". Signed-off-by: Bruce Richardson --- devtool

RE: [PATCH v3 2/4] net/idpf: re-enable unused variable warnings

2025-02-03 Thread Shetty, Praveen
The idpf driver was being built with warnings disabled for unused variables. However, while the warning was being disabled in the base code directory, all suppressed warnings were in the main directory. Therefore, just remove the unused variables and re-enable the warnings. Signed-off-by: Bruc

RE: [PATCH v6 00/25] Reduce code duplication across Intel NIC drivers

2025-01-27 Thread Shetty, Praveen
This patchset attempts to reduce the amount of code duplication across a number of Intel NIC drivers, specifically: ixgbe, i40e, iavf, and ice. As part of this process of deduplication, and in preparation for further cleanup work, it moves all existing Intel drivers to a net/intel directory, w

RE: [PATCH v2] net/cpfl: fix cpfl parser issue

2024-08-23 Thread Shetty, Praveen
> CPFL parser was incorrectly parsing the mask value of the > next_proto_id field from recipe.json file as a string instead of > unsigned integer. > > Fixes: 41f20298ee8c ("net/cpfl: parse flow offloading hint from JSON") > Cc: sta...@dpdk.org > > Signed-off-by: Praveen Shetty > > --- > v2: >

RE: [PATCH v1] net/cpfl: fix invalid action types

2024-08-23 Thread Shetty, Praveen
> In case of CPFL PMD, port_representor action is used for the local > vport and represented_port action is used for the remote port(remote > port in this case is either the idpf pf or the vf port that is being > represeted by the cpfl pmd). > Any mismatch in either of the cases PMD will throw a

Re: [dpdk-dev] [PATCH v2] doc: add deprecation notice for sched changes

2020-07-27 Thread Shetty, Praveen
-Original Message- From: dev On Behalf Of Savinay Dharmappa Sent: Thursday, July 16, 2020 6:56 PM To: Dharmappa, Savinay ; dev@dpdk.org Cc: Dumitrescu, Cristian ; Singh, Jasvinder Subject: [dpdk-dev] [PATCH v2] doc: add deprecation notice for sched changes Add deprecation note for ma

Re: [dpdk-dev] [PATCH v2] examples/ipsec-secgw: fix negative argument passing

2020-05-06 Thread Shetty, Praveen
-Original Message- From: Lukasz Wojciechowski Sent: Wednesday, May 6, 2020 4:20 PM To: Shetty, Praveen ; dev@dpdk.org; Doherty, Declan ; akhil.go...@nxp.com; ano...@marvell.com Cc: Iremonger, Bernard ; Ananyev, Konstantin Subject: Re: [dpdk-dev] [PATCH v2] examples/ipsec-secgw: fix

Re: [dpdk-dev] [EXT] [PATCH v1] examples/ipsec-secgw: resolve coverity issue

2020-05-06 Thread Shetty, Praveen
Hi Anoob, Thank you. I have modified the commit message and headline accordingly and sent v2. Regards, Praveen -Original Message- From: Anoob Joseph Sent: Wednesday, May 6, 2020 3:13 PM To: Shetty, Praveen ; dev@dpdk.org; Doherty, Declan ; akhil.go...@nxp.com Cc: Iremonger, Bernard

Re: [dpdk-dev] [PATCH v5] examples/ipsec-secgw: support flow director feature

2020-04-16 Thread Shetty, Praveen
Hi Akhil, Thank you. Please see my response inline. -Original Message- From: Akhil Goyal Sent: Thursday, April 16, 2020 12:30 AM To: Shetty, Praveen ; dev@dpdk.org; Doherty, Declan ; ano...@marvell.com Cc: Iremonger, Bernard ; Ananyev, Konstantin Subject: RE: [PATCH v5] examples

Re: [dpdk-dev] [PATCH v5] examples/ipsec-secgw: support flow director feature

2020-04-14 Thread Shetty, Praveen
Hi Akhil/Anoob Do you have any further review comments ? Regards, Praveen -Original Message- From: dev On Behalf Of Praveen Shetty Sent: Thursday, April 9, 2020 3:40 PM To: dev@dpdk.org; Doherty, Declan ; akhil.go...@nxp.com; ano...@marvell.com Cc: Iremonger, Bernard ; Ananyev, Konstan

Re: [dpdk-dev] [EXT] [PATCH v3] examples/ipsec-secgw: support flow director feature

2020-04-03 Thread Shetty, Praveen
-Original Message- From: Akhil Goyal Sent: Friday, April 3, 2020 11:22 AM To: Anoob Joseph ; Shetty, Praveen ; dev@dpdk.org; Doherty, Declan Cc: Iremonger, Bernard ; Ananyev, Konstantin Subject: RE: [EXT] [PATCH v3] examples/ipsec-secgw: support flow director feature > >

Re: [dpdk-dev] [EXT] [PATCH v3] examples/ipsec-secgw: support flow director feature

2020-04-02 Thread Shetty, Praveen
Hi Anoob, See my response inline. Regards, Praveen -Original Message- From: Anoob Joseph Sent: Thursday, April 2, 2020 7:09 PM To: Shetty, Praveen ; dev@dpdk.org; Doherty, Declan Cc: Iremonger, Bernard ; Ananyev, Konstantin Subject: RE: [EXT] [PATCH v3] examples/ipsec-secgw

Re: [dpdk-dev] [PATCH v3] examples/ipsec-secgw: support flow director feature

2020-04-02 Thread Shetty, Praveen
-Original Message- From: Akhil Goyal Sent: Wednesday, April 1, 2020 7:24 PM To: Anoob Joseph ; Shetty, Praveen ; dev@dpdk.org; Doherty, Declan Cc: Iremonger, Bernard ; Ananyev, Konstantin Subject: RE: [dpdk-dev] [PATCH v3] examples/ipsec-secgw: support flow director feature

Re: [dpdk-dev] [PATCH v2] examples/ipsec-secgw: support flow director feature

2020-03-23 Thread Shetty, Praveen
Hi Anoob, Thank you. Please see my response inline. Regards, Praveen -Original Message- From: Anoob Joseph Sent: Friday, March 20, 2020 1:45 PM To: Shetty, Praveen ; dev@dpdk.org; Doherty, Declan ; bernard.iremon...@intel.co; Ananyev, Konstantin Cc: Narayana Prasad Raju Athreya

Re: [dpdk-dev] [PATCH v1] examples/ipsec-secgw: support flow director feature

2020-03-13 Thread Shetty, Praveen
Hi Anoob, Please see my response inline. Regards, Praveen -Original Message- From: Anoob Joseph Sent: Friday, March 13, 2020 4:22 PM To: Shetty, Praveen ; Doherty, Declan ; Ananyev, Konstantin ; Iremonger, Bernard ; dev@dpdk.org Subject: RE: [dpdk-dev] [PATCH v1] examples/ipsec

Re: [dpdk-dev] [PATCH v1] examples/ipsec-secgw: support flow director feature

2020-03-13 Thread Shetty, Praveen
Hi Anoob, Thank you. Please see my answers below. Regards, Praveen -Original Message- From: Anoob Joseph Sent: Thursday, March 12, 2020 4:31 PM To: Shetty, Praveen ; dev@dpdk.org; Doherty, Declan ; Iremonger, Bernard ; Ananyev, Konstantin Subject: RE: [dpdk-dev] [PATCH v1] examples

Re: [dpdk-dev] [PATCH v1] examples/ipsec-secgw: load/unload esp-ah DDP file

2020-03-10 Thread Shetty, Praveen
Hi Anoob, Thanks for the review. Please see my response inline. Regards, Praveen -Original Message- From: Anoob Joseph Sent: Friday, March 6, 2020 3:30 PM To: Shetty, Praveen ; dev@dpdk.org; Doherty, Declan ; Iremonger, Bernard ; Ananyev, Konstantin Subject: RE: [dpdk-dev] [PATCH